From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH v2 05/11] qmi: Pass two dedicated WDS services to gprs-context
Date: Thu, 11 Jul 2024 11:49:27 -0500 [thread overview]
Message-ID: <20240711164936.1688973-5-denkenz@gmail.com> (raw)
In-Reply-To: <20240711164936.1688973-1-denkenz@gmail.com>
gprs-context driver will not take two qmi_service objects, each with a
dedicated WDS service. This will allow gprs-context to support dual
stack (ipv4 + ipv6) contexts (in future commits). For now, the behavior
is left unchanged with the second qmi_service being destroyed.
---
drivers/qmimodem/gprs-context.c | 8 +++++---
plugins/gobi.c | 11 +++++++++--
plugins/qrtrqmi.c | 7 +++++--
3 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/qmimodem/gprs-context.c b/drivers/qmimodem/gprs-context.c
index 7d13889bf603..5582a8052c0b 100644
--- a/drivers/qmimodem/gprs-context.c
+++ b/drivers/qmimodem/gprs-context.c
@@ -554,21 +554,23 @@ static int qmi_gprs_context_probev(struct ofono_gprs_context *gc,
unsigned int vendor, va_list args)
{
int mux_id = va_arg(args, int);
- _auto_(qmi_service_free) struct qmi_service *wds =
+ _auto_(qmi_service_free) struct qmi_service *ipv4 =
+ va_arg(args, struct qmi_service *);
+ _auto_(qmi_service_free) struct qmi_service *ipv6 =
va_arg(args, struct qmi_service *);
struct gprs_context_data *data;
DBG("");
if (mux_id != -1) {
- int r = qmi_gprs_context_bind_mux(gc, wds, mux_id);
+ int r = qmi_gprs_context_bind_mux(gc, ipv4, mux_id);
if (r < 0)
return r;
}
data = l_new(struct gprs_context_data, 1);
- data->wds = l_steal_ptr(wds);
+ data->wds = l_steal_ptr(ipv4);
data->mux_id = mux_id;
qmi_service_register(data->wds, QMI_WDS_PACKET_SERVICE_STATUS,
diff --git a/plugins/gobi.c b/plugins/gobi.c
index 76e1e133860d..cb20824cc424 100644
--- a/plugins/gobi.c
+++ b/plugins/gobi.c
@@ -803,10 +803,14 @@ static void gobi_setup_gprs(struct ofono_modem *modem)
/* Simple case of 802.3 interface, no QMAP */
if (data->n_premux == 0) {
+ struct qmi_service *ipv4 = data->context_services[0].wds_ipv4;
+ struct qmi_service *ipv6 = data->context_services[0].wds_ipv6;
+
interface = ofono_modem_get_string(modem, "NetworkInterface");
gc = ofono_gprs_context_create(modem, 0, "qmimodem", -1,
- qmi_service_clone(data->wds));
+ qmi_service_clone(ipv4),
+ qmi_service_clone(ipv6));
if (!gc) {
ofono_warn("Unable to create gprs-context for: %s",
ofono_modem_get_path(modem));
@@ -826,13 +830,16 @@ static void gobi_setup_gprs(struct ofono_modem *modem)
DBG("max_aggregation_size: %u", data->max_aggregation_size);
for (i = 0; i < data->n_premux; i++) {
+ struct qmi_service *ipv4 = data->context_services[i].wds_ipv4;
+ struct qmi_service *ipv6 = data->context_services[i].wds_ipv6;
int mux_id;
sprintf(buf, "PremuxInterface%dMuxId", i + 1);
mux_id = ofono_modem_get_integer(modem, buf);
gc = ofono_gprs_context_create(modem, 0, "qmimodem", mux_id,
- qmi_service_clone(data->wds));
+ qmi_service_clone(ipv4),
+ qmi_service_clone(ipv6));
if (!gc) {
ofono_warn("gprs-context creation failed for [%d] %s",
diff --git a/plugins/qrtrqmi.c b/plugins/qrtrqmi.c
index b64ab355a2e8..21103371046a 100644
--- a/plugins/qrtrqmi.c
+++ b/plugins/qrtrqmi.c
@@ -324,10 +324,13 @@ static int setup_gprs_context(uint8_t mux_id, const char *interface,
struct ofono_modem *modem = ofono_gprs_get_modem(gprs);
struct qrtrqmi_data *data = ofono_modem_get_data(modem);
struct qmi_qrtr_node *node = data->node;
+ struct qmi_service *ipv4 = qmi_qrtr_node_get_dedicated_service(node,
+ QMI_SERVICE_WDS);
+ struct qmi_service *ipv6 = qmi_qrtr_node_get_dedicated_service(node,
+ QMI_SERVICE_WDS);
struct ofono_gprs_context *gc;
- gc = ofono_gprs_context_create(modem, 0, "qmimodem", mux_id,
- qmi_qrtr_node_get_service(node, QMI_SERVICE_WDS));
+ gc = ofono_gprs_context_create(modem, 0, "qmimodem", mux_id, ipv4, ipv6);
if (!gc) {
ofono_warn("Unable to create gprs-context for: %s, %s[%u]",
ofono_modem_get_path(modem), interface, mux_id);
--
2.45.2
next prev parent reply other threads:[~2024-07-11 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 16:49 [PATCH v2 01/11] gobi: Limit number of premultiplexed contexts to 4 Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 02/11] gobi: Request dedicated WDS services for contexts Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 03/11] qmi: Enable _auto_ use for some classes Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 04/11] qmi: gprs-context: Declare qmi_service objects using _auto_ Denis Kenzior
2024-07-11 16:49 ` Denis Kenzior [this message]
2024-07-11 16:49 ` [PATCH v2 06/11] qmi: gprs-context: Remove parsing of unused TLVs Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 07/11] qmi: gprs-context: Treat IP family TLV as mandatory Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 08/11] qmi: gprs-context: Set up WDS service for IPv6 Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 09/11] qmi: gprs-context: refactor detach_shutdown path Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 10/11] qmi: gprs-context: refactor deactivate_primary Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 11/11] qmi: gprs-context: Dual-Stack context activation support Denis Kenzior
2024-07-11 17:53 ` [PATCH v2 01/11] gobi: Limit number of premultiplexed contexts to 4 patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711164936.1688973-5-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.