From: Denis Kenzior <denkenz@gmail.com>
To: ofono@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH v2 06/11] qmi: gprs-context: Remove parsing of unused TLVs
Date: Thu, 11 Jul 2024 11:49:28 -0500 [thread overview]
Message-ID: <20240711164936.1688973-6-denkenz@gmail.com> (raw)
In-Reply-To: <20240711164936.1688973-1-denkenz@gmail.com>
The information from these TLVs is currently unused and only printed to
debug output. Same can be accomplished using an external sniffer.
Remove this code until the information in these TLVs is needed for
something.
---
drivers/qmimodem/gprs-context.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/qmimodem/gprs-context.c b/drivers/qmimodem/gprs-context.c
index 5582a8052c0b..f29f10720710 100644
--- a/drivers/qmimodem/gprs-context.c
+++ b/drivers/qmimodem/gprs-context.c
@@ -173,29 +173,17 @@ static void get_settings_ipv4(struct ofono_gprs_context *gc,
static void get_settings_cb(struct qmi_result *result, void *user_data)
{
- static const uint8_t RESULT_PDP_TYPE = 0x11; /* uint8 */
- static const uint8_t RESULT_APN = 0x14; /* string */
static const uint8_t RESULT_IP_FAMILY = 0x2b; /* uint8 */
struct cb_data *cbd = user_data;
ofono_gprs_context_cb_t cb = cbd->cb;
struct ofono_gprs_context *gc = cbd->user;
- uint8_t pdp_type, ip_family;
- char *apn;
+ uint8_t ip_family;
DBG("");
if (qmi_result_set_error(result, NULL))
goto done;
- apn = qmi_result_get_string(result, RESULT_APN);
- if (apn) {
- DBG("APN: %s", apn);
- l_free(apn);
- }
-
- if (qmi_result_get_uint8(result, RESULT_PDP_TYPE, &pdp_type))
- DBG("PDP type %d", pdp_type);
-
if (!qmi_result_get_uint8(result, RESULT_IP_FAMILY, &ip_family)) {
ofono_error("No IP family in results");
goto done;
--
2.45.2
next prev parent reply other threads:[~2024-07-11 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 16:49 [PATCH v2 01/11] gobi: Limit number of premultiplexed contexts to 4 Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 02/11] gobi: Request dedicated WDS services for contexts Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 03/11] qmi: Enable _auto_ use for some classes Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 04/11] qmi: gprs-context: Declare qmi_service objects using _auto_ Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 05/11] qmi: Pass two dedicated WDS services to gprs-context Denis Kenzior
2024-07-11 16:49 ` Denis Kenzior [this message]
2024-07-11 16:49 ` [PATCH v2 07/11] qmi: gprs-context: Treat IP family TLV as mandatory Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 08/11] qmi: gprs-context: Set up WDS service for IPv6 Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 09/11] qmi: gprs-context: refactor detach_shutdown path Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 10/11] qmi: gprs-context: refactor deactivate_primary Denis Kenzior
2024-07-11 16:49 ` [PATCH v2 11/11] qmi: gprs-context: Dual-Stack context activation support Denis Kenzior
2024-07-11 17:53 ` [PATCH v2 01/11] gobi: Limit number of premultiplexed contexts to 4 patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240711164936.1688973-6-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.