* [PATCH 1/1] iommufd: Fix error pointer checking
@ 2024-07-12 2:58 Lu Baolu
2024-07-12 12:52 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Lu Baolu @ 2024-07-12 2:58 UTC (permalink / raw)
To: Jason Gunthorpe, Kevin Tian, Dan Carpenter; +Cc: iommu, linux-kernel, Lu Baolu
Smatch static checker reported below warning:
drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
warn: 'handle' is an error pointer or valid
Fix it by checking 'handle' with IS_ERR().
Fixes: b7d8833677ba ("iommufd: Fault-capable hwpt attach/detach/replace")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-iommu/8bb4f37a-4514-4dea-aabb-7380be303895@stanley.mountain/
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
---
drivers/iommu/iommufd/fault.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommufd/fault.c b/drivers/iommu/iommufd/fault.c
index e6bda84865f0..29f522819759 100644
--- a/drivers/iommu/iommufd/fault.c
+++ b/drivers/iommu/iommufd/fault.c
@@ -128,7 +128,7 @@ iommufd_device_get_attach_handle(struct iommufd_device *idev)
struct iommu_attach_handle *handle;
handle = iommu_attach_handle_get(idev->igroup->group, IOMMU_NO_PASID, 0);
- if (!handle)
+ if (IS_ERR(handle))
return NULL;
return to_iommufd_handle(handle);
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] iommufd: Fix error pointer checking
2024-07-12 2:58 [PATCH 1/1] iommufd: Fix error pointer checking Lu Baolu
@ 2024-07-12 12:52 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2024-07-12 12:52 UTC (permalink / raw)
To: Lu Baolu; +Cc: Kevin Tian, Dan Carpenter, iommu, linux-kernel
On Fri, Jul 12, 2024 at 10:58:19AM +0800, Lu Baolu wrote:
> Smatch static checker reported below warning:
>
> drivers/iommu/iommufd/fault.c:131 iommufd_device_get_attach_handle()
> warn: 'handle' is an error pointer or valid
>
> Fix it by checking 'handle' with IS_ERR().
>
> Fixes: b7d8833677ba ("iommufd: Fault-capable hwpt attach/detach/replace")
> Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
> Closes: https://lore.kernel.org/linux-iommu/8bb4f37a-4514-4dea-aabb-7380be303895@stanley.mountain/
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
> drivers/iommu/iommufd/fault.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-12 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 2:58 [PATCH 1/1] iommufd: Fix error pointer checking Lu Baolu
2024-07-12 12:52 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.