* [Buildroot] [PATCH v2] package/ncftp: fix GCC 14.x related build errors
@ 2024-06-17 9:36 yegorslists
2024-07-12 6:43 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: yegorslists @ 2024-06-17 9:36 UTC (permalink / raw)
To: buildroot; +Cc: yann.morin.1998
From: Yegor Yefremov <yegorslists@googlemail.com>
Patches were taken from Gentoo:
https://bugs.gentoo.org/921487
https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
Fixes:
http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes v1 -> v2:
- add Upstream tags to the patches (Yann E. MORIN)
.../ncftp/0001-ncftp-3.2.7-fix-gcc14.patch | 19 +++++
.../ncftp/0002-ncftp-3.2.7-fix-clang.patch | 72 +++++++++++++++++++
2 files changed, 91 insertions(+)
create mode 100644 package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
create mode 100644 package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
diff --git a/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
new file mode 100644
index 0000000000..e2cda631d4
--- /dev/null
+++ b/package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch
@@ -0,0 +1,19 @@
+fix select arg detection
+
+Reference:
+ https://bugs.gentoo.org/921487
+
+Upstream: N/A, unresponsive contact email address.
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+--- a/autoconf_local/aclocal.m4
++++ b/autoconf_local/aclocal.m4
+@@ -4196,7 +4196,7 @@
+ #include <sys/select.h>
+ #endif
+ #include <sys/socket.h> /* MG: always incl */
+-extern select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
++extern int select ($ac_cv_func_select_arg1,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg234,$ac_cv_func_select_arg5);],,dnl
+ [ac_not_found=no ; break 3],ac_not_found=yes)
+ done
+ done
diff --git a/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
new file mode 100644
index 0000000000..bed103609c
--- /dev/null
+++ b/package/ncftp/0002-ncftp-3.2.7-fix-clang.patch
@@ -0,0 +1,72 @@
+Fix compilation with clang-16
+
+aclocal.m4 contains code that no longer compiles: missing headers and missing
+return types.
+
+Reference:
+ https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
+
+Upstream: N/A, unresponsive contact email address.
+
+Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
+--- a/autoconf_local/aclocal.m4
++++ b/autoconf_local/aclocal.m4
+@@ -3057,6 +3057,7 @@
+ #include <sys/uio.h>
+ #include <sys/socket.h>
+ #include <sys/un.h>
++#include <string.h>
+ ],[
+ struct sockaddr_un uaddr;
+
+@@ -3285,6 +3286,7 @@
+ #ifdef HAVE_RESOLV_H
+ # include <resolv.h>
+ #endif
++#include <string.h>
+ ],[
+ /* function-body */
+ int len;
+@@ -3363,6 +3365,7 @@
+ #include <stdio.h>
+ #include <stdlib.h>
+
++ int
+ main(int argc, char **argv)
+ {
+ /* Note: don't actually call readline,
+@@ -5145,6 +5148,7 @@
+ #ifdef HAVE_STDLIB_H
+ # include <stdlib.h>
+ #endif
++#include <string.h>
+
+ #ifdef HAVE_NCURSES_H
+ # define NCURSES_OPAQUE 0
+@@ -5176,6 +5180,7 @@
+ #endif
+
+
++int
+ main(int argc, char **argv)
+ {
+ /* Note: don't actually call curses, since it may block;
+@@ -6510,7 +6515,6 @@
+ #endif
+ #endif /* MG */
+
+-int
+ int main(void)
+ {
+ char *data, *data2, *data3;
+@@ -6607,8 +6611,9 @@
+ AC_CACHE_CHECK(whether setvbuf arguments are reversed,
+ ac_cv_func_setvbuf_reversed,
+ [AC_TRY_RUN([#include <stdio.h>
++ $include <stdlib.h>
+ /* If setvbuf has the reversed format, exit 0. */
+- main () {
++ int main (void) {
+ /* This call has the arguments reversed.
+ A reversed system may check and see that the address of main
+ is not _IOLBF, _IONBF, or _IOFBF, and return nonzero. */
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-28 10:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-17 9:36 [Buildroot] [PATCH v2] package/ncftp: fix GCC 14.x related build errors yegorslists
2024-07-12 6:43 ` Thomas Petazzoni via buildroot
2024-07-28 10:21 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.