Re: [RFC PATCH 04/18] KVM: Fail __gfn_to_hva_many for userfault gfns.

[kernel test robot <lkp@intel.com>]

Hi James,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on 02b0d3b9d4dd1ef76b3e8c63175f1ae9ff392313]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Houghton/KVM-Add-KVM_USERFAULT-build-option/20240711-101935
base:   02b0d3b9d4dd1ef76b3e8c63175f1ae9ff392313
patch link:    https://lore.kernel.org/r/20240710234222.2333120-5-jthoughton%40google.com
patch subject: [RFC PATCH 04/18] KVM: Fail __gfn_to_hva_many for userfault gfns.
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240714/202407140801.z25gh0Q5-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407140801.z25gh0Q5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407140801.z25gh0Q5-lkp@intel.com/

All errors (new ones prefixed by >>):

   arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function '__gfn_to_hva_many':
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:2690:24: error: 'KVM_HVA_ERR_USERFAULT' undeclared (first use in this function); did you mean 'KVM_CAP_USERFAULT'?
    2690 |                 return KVM_HVA_ERR_USERFAULT;
         |                        ^~~~~~~~~~~~~~~~~~~~~
         |                        KVM_CAP_USERFAULT
   arch/s390/kvm/../../../virt/kvm/kvm_main.c:2690:24: note: each undeclared identifier is reported only once for each function it appears in


vim +2690 arch/s390/kvm/../../../virt/kvm/kvm_main.c

  2679	
  2680	static unsigned long __gfn_to_hva_many(const struct kvm_memory_slot *slot, gfn_t gfn,
  2681					       gfn_t *nr_pages, bool write)
  2682	{
  2683		if (!slot || slot->flags & KVM_MEMSLOT_INVALID)
  2684			return KVM_HVA_ERR_BAD;
  2685	
  2686		if (memslot_is_readonly(slot) && write)
  2687			return KVM_HVA_ERR_RO_BAD;
  2688	
  2689		if (gfn_has_userfault(slot->kvm, gfn))
> 2690			return KVM_HVA_ERR_USERFAULT;
  2691	
  2692		if (nr_pages)
  2693			*nr_pages = slot->npages - (gfn - slot->base_gfn);
  2694	
  2695		return __gfn_to_hva_memslot(slot, gfn);
  2696	}
  2697	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki