Re: [RFC PATCH 14/18] KVM: Add asynchronous userfaults, KVM_READ_USERFAULT

[kernel test robot <lkp@intel.com>]

Hi James,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 02b0d3b9d4dd1ef76b3e8c63175f1ae9ff392313]

url:    https://github.com/intel-lab-lkp/linux/commits/James-Houghton/KVM-Add-KVM_USERFAULT-build-option/20240711-101935
base:   02b0d3b9d4dd1ef76b3e8c63175f1ae9ff392313
patch link:    https://lore.kernel.org/r/20240710234222.2333120-15-jthoughton%40google.com
patch subject: [RFC PATCH 14/18] KVM: Add asynchronous userfaults, KVM_READ_USERFAULT
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20240714/202407141130.FQSlMZIJ-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240714/202407141130.FQSlMZIJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407141130.FQSlMZIJ-lkp@intel.com/

All warnings (new ones prefixed by >>):

   arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function '__gfn_to_hva_many':
   arch/s390/kvm/../../../virt/kvm/kvm_main.c:2729:32: error: 'KVM_HVA_ERR_USERFAULT' undeclared (first use in this function); did you mean 'KVM_PFN_ERR_USERFAULT'?
    2729 |                         return KVM_HVA_ERR_USERFAULT;
         |                                ^~~~~~~~~~~~~~~~~~~~~
         |                                KVM_PFN_ERR_USERFAULT
   arch/s390/kvm/../../../virt/kvm/kvm_main.c:2729:32: note: each undeclared identifier is reported only once for each function it appears in
   arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function '__gfn_to_pfn_memslot':
   arch/s390/kvm/../../../virt/kvm/kvm_main.c:3059:29: error: 'KVM_HVA_ERR_USERFAULT' undeclared (first use in this function); did you mean 'KVM_PFN_ERR_USERFAULT'?
    3059 |                 if (addr == KVM_HVA_ERR_USERFAULT)
         |                             ^~~~~~~~~~~~~~~~~~~~~
         |                             KVM_PFN_ERR_USERFAULT
   arch/s390/kvm/../../../virt/kvm/kvm_main.c: At top level:
>> arch/s390/kvm/../../../virt/kvm/kvm_main.c:2681:12: warning: 'read_userfault' defined but not used [-Wunused-function]
    2681 | static int read_userfault(struct kvm_userfault_ctx __rcu *ctx, gfn_t *gfn)
         |            ^~~~~~~~~~~~~~


vim +/read_userfault +2681 arch/s390/kvm/../../../virt/kvm/kvm_main.c

  2680	
> 2681	static int read_userfault(struct kvm_userfault_ctx __rcu *ctx, gfn_t *gfn)
  2682	{
  2683		struct kvm_userfault_list_entry *entry;
  2684	
  2685		spin_lock(&ctx->list_lock);
  2686	
  2687		entry = list_first_entry_or_null(&ctx->gfn_list,
  2688						 struct kvm_userfault_list_entry,
  2689						 list);
  2690	
  2691		list_del(&entry->list);
  2692	
  2693		spin_unlock(&ctx->list_lock);
  2694	
  2695		if (!entry)
  2696			return -ENOENT;
  2697	
  2698		*gfn = entry->gfn;
  2699		return 0;
  2700	}
  2701	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki