All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Kadir Yilmaz <kadir.c.yilmaz@gmail.com>
Cc: Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Julien Corjon <corjon.j@ecagroup.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/qt5webengine: don't use system ICU libraries
Date: Mon, 15 Jul 2024 12:15:36 +0200	[thread overview]
Message-ID: <20240715121536.1db28c1e@windsurf> (raw)
In-Reply-To: <20231025212924.1957581-1-kadir.c.yilmaz@gmail.com>

Hello Kadir,

On Wed, 25 Oct 2023 23:29:24 +0200
Kadir Yilmaz <kadir.c.yilmaz@gmail.com> wrote:

> With the "-webengine-icu" config option qt5webengine uses icu headers
> on the build host. If (for ubuntu) libicu-dev is not installed on the
> system, build fails with:
> 
> In file included from ../../3rdparty/chromium/v8/src/regexp/gen-regexp-special-case.cc:10:
> ../../3rdparty/chromium/v8/src/regexp/special-case.h:12:10: fatal error: unicode/uchar.h: No such file or directory
>    12 | #include "unicode/uchar.h"
>       |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> 
> Otherwise, if (for ubuntu) libicu-dev is installed on the system, build
> fails later at linking stage.
> 
> Using icu bundled with qt solves this problem
> 
> Signed-off-by: Kadir Yilmaz <kadir.c.yilmaz@gmail.com>
> ---
>  package/qt5/qt5webengine/qt5webengine.mk | 1 -
>  1 file changed, 1 deletion(-)

I have applied your patch, with an improved commit log, as part of a
larger set of 13 patches to fix the build of qt5webengine (which now
builds fine for me on ARM64), with all those fixes. See your final
commit at:

 https://gitlab.com/buildroot.org/buildroot/-/commit/ca7cedaa8cab0a0ac0fc48c2f40c4e6a84fb6877

If you are able to test the latest master, and report back if
qt5webengine now works for you, it'd be amazing!

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2024-07-15 10:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-25 21:29 [Buildroot] [PATCH 1/1] package/qt5webengine: don't use system ICU libraries Kadir Yilmaz
2024-06-06  9:52 ` Yann E. MORIN
2024-07-15 10:15 ` Thomas Petazzoni via buildroot [this message]
2024-08-27 15:57   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240715121536.1db28c1e@windsurf \
    --to=buildroot@buildroot.org \
    --cc=corjon.j@ecagroup.com \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=kadir.c.yilmaz@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.