Re: [Buildroot] [PATCH 1/1] package/qt5webengine: don't use system ICU libraries

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Kadir, All,

Thank you for the patch, and again, sorry to come back to it so late...

+James, who bumped to a version that had the hos-icu dependency

On 2023-10-25 23:29 +0200, Kadir Yilmaz spake thusly:
> With the "-webengine-icu" config option qt5webengine uses icu headers
> on the build host. If (for ubuntu) libicu-dev is not installed on the
> system, build fails with:
> 
> In file included from ../../3rdparty/chromium/v8/src/regexp/gen-regexp-special-case.cc:10:
> ../../3rdparty/chromium/v8/src/regexp/special-case.h:12:10: fatal error: unicode/uchar.h: No such file or directory
>    12 | #include "unicode/uchar.h"
>       |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> 
> Otherwise, if (for ubuntu) libicu-dev is installed on the system, build
> fails later at linking stage.
> 
> Using icu bundled with qt solves this problem

This is weird, because qt5webengine already contains a dependency on
host-icu, so ehther the host distro has or does not have icu development
files, the build should use our owns,

> Signed-off-by: Kadir Yilmaz <kadir.c.yilmaz@gmail.com>
> ---
>  package/qt5/qt5webengine/qt5webengine.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/qt5/qt5webengine/qt5webengine.mk b/package/qt5/qt5webengine/qt5webengine.mk
> index 836ba62189..c028246589 100644
> --- a/package/qt5/qt5webengine/qt5webengine.mk
> +++ b/package/qt5/qt5webengine/qt5webengine.mk
> @@ -87,7 +87,6 @@ QT5WEBENGINE_DEPENDENCIES += \
>  QT5WEBENGINE_CONF_OPTS += \
>  	-webengine-embedded-build \
>  	-webengine-ffmpeg \
> -	-webengine-icu \
>  	-webengine-opus \
>  	-webengine-webchannel \
>  	-webengine-webp \
> -- 
> 2.25.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot