From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: make24@iscas.ac.cn, linuxppc-dev@lists.ozlabs.org,
kernel-janitors@vger.kernel.org, stable@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Aleksandr Mishin <amishin@t-argos.ru>,
Andrew Donnellan <ajd@linux.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Frederic Barrat <fbarrat@linux.ibm.com>,
Ian Munsie <imunsie@au1.ibm.com>,
Maxime Ripard <mripard@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Shuah Khan <shuah@kernel.org>, Wei Liu <wei.liu@kernel.org>
Subject: Re: [PATCH v4] cxl: Fix possible null pointer dereference in read_handle()
Date: Mon, 15 Jul 2024 15:32:43 +0200 [thread overview]
Message-ID: <2024071537-schematic-envoy-4272@gregkh> (raw)
In-Reply-To: <6c50de6d-7f35-4427-bd11-5f02f5e90c08@web.de>
On Mon, Jul 15, 2024 at 03:18:56PM +0200, Markus Elfring wrote:
> > In read_handle(), of_get_address() may return NULL if getting address and
> > size of the node failed. When of_read_number() uses prop to handle
> > conversions between different byte orders, it could lead to a null pointer
> > dereference. Add NULL check to fix potential issue.
> >
> > Found by static analysis.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
> > Signed-off-by: Ma Ke <make24@iscas.ac.cn>
>
> How will interests evolve for caring more according to known research
> and development processes?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n398
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/researcher-guidelines.rst?h=v6.10#n5
>
>
> > ---
> > Changes in v4:
> > - modified vulnerability description according to suggestions, making the
> > process of static analysis of vulnerabilities clearer. No active research
> > on developer behavior.
> …
>
> Does such information indicate any communication difficulties?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Maxime Ripard <mripard@kernel.org>, Shuah Khan <shuah@kernel.org>,
Andrew Donnellan <ajd@linux.ibm.com>,
make24@iscas.ac.cn, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Aleksandr Mishin <amishin@t-argos.ru>,
Frederic Barrat <fbarrat@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Ian Munsie <imunsie@au1.ibm.com>
Subject: Re: [PATCH v4] cxl: Fix possible null pointer dereference in read_handle()
Date: Mon, 15 Jul 2024 15:32:43 +0200 [thread overview]
Message-ID: <2024071537-schematic-envoy-4272@gregkh> (raw)
In-Reply-To: <6c50de6d-7f35-4427-bd11-5f02f5e90c08@web.de>
On Mon, Jul 15, 2024 at 03:18:56PM +0200, Markus Elfring wrote:
> > In read_handle(), of_get_address() may return NULL if getting address and
> > size of the node failed. When of_read_number() uses prop to handle
> > conversions between different byte orders, it could lead to a null pointer
> > dereference. Add NULL check to fix potential issue.
> >
> > Found by static analysis.
> >
> > Cc: stable@vger.kernel.org
> > Fixes: 14baf4d9c739 ("cxl: Add guest-specific code")
> > Signed-off-by: Ma Ke <make24@iscas.ac.cn>
>
> How will interests evolve for caring more according to known research
> and development processes?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10#n398
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/researcher-guidelines.rst?h=v6.10#n5
>
>
> > ---
> > Changes in v4:
> > - modified vulnerability description according to suggestions, making the
> > process of static analysis of vulnerabilities clearer. No active research
> > on developer behavior.
> …
>
> Does such information indicate any communication difficulties?
Hi,
This is the semi-friendly patch-bot of Greg Kroah-Hartman.
Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list. I strongly suggest that you not do this anymore. Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.
Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all. The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback. Please feel free to also ignore emails
from them.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2024-07-15 13:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 2:54 [PATCH v4] cxl: Fix possible null pointer dereference in read_handle() Ma Ke
2024-07-15 2:54 ` Ma Ke
2024-07-15 5:12 ` Greg KH
2024-07-15 5:12 ` Greg KH
2024-07-15 6:28 ` Michael Ellerman
2024-07-15 6:28 ` Michael Ellerman
2024-07-15 17:11 ` Dan Carpenter
2024-07-15 17:11 ` Dan Carpenter
2024-07-16 13:27 ` Ma Ke
2024-07-16 13:27 ` Ma Ke
2024-07-19 1:23 ` Michael Ellerman
2024-07-19 1:23 ` Michael Ellerman
2024-07-15 13:18 ` Markus Elfring
2024-07-15 13:18 ` Markus Elfring
2024-07-15 13:32 ` Greg Kroah-Hartman [this message]
2024-07-15 13:32 ` Greg Kroah-Hartman
2024-07-19 1:25 ` Michael Ellerman
2024-07-19 1:25 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024071537-schematic-envoy-4272@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=ajd@linux.ibm.com \
--cc=amishin@t-argos.ru \
--cc=arnd@arndb.de \
--cc=fbarrat@linux.ibm.com \
--cc=imunsie@au1.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=make24@iscas.ac.cn \
--cc=mpe@ellerman.id.au \
--cc=mripard@kernel.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.