* [willy-pagecache:write-end 52/52] drivers/gpu/drm/i915/gem/i915_gem_shmem.c:461:2: error: use of undeclared identifier 'offset'
@ 2024-07-15 23:38 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-07-15 23:38 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: oe-kbuild-all
tree: git://git.infradead.org/users/willy/pagecache write-end
head: a875d4f14434467d21cd6cbe9a5e2366d6405a85
commit: a875d4f14434467d21cd6cbe9a5e2366d6405a85 [52/52] fs: Convert aops->write_begin to take a folio
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240716/202407160720.vDrcl3DM-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240716/202407160720.vDrcl3DM-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407160720.vDrcl3DM-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/gem/i915_gem_shmem.c:461:2: error: use of undeclared identifier 'offset'
461 | offset = arg->offset;
| ^
>> drivers/gpu/drm/i915/gem/i915_gem_shmem.c:485:7: error: use of undeclared identifier 'folio'
485 | &folio, &data);
| ^
drivers/gpu/drm/i915/gem/i915_gem_shmem.c:489:51: error: use of undeclared identifier 'folio'
489 | vaddr = kmap_local_folio(folio, offset_in_folio(folio, pos));
| ^
drivers/gpu/drm/i915/gem/i915_gem_shmem.c:489:28: error: use of undeclared identifier 'folio'
489 | vaddr = kmap_local_folio(folio, offset_in_folio(folio, pos));
| ^
drivers/gpu/drm/i915/gem/i915_gem_shmem.c:496:28: error: use of undeclared identifier 'folio'
496 | len - unwritten, folio, data);
| ^
drivers/gpu/drm/i915/gem/i915_gem_shmem.c:678:18: warning: unused variable 'vaddr' [-Wunused-variable]
678 | void *pgdata, *vaddr;
| ^~~~~
1 warning and 5 errors generated.
vim +/offset +461 drivers/gpu/drm/i915/gem/i915_gem_shmem.c
a85fffe3032d99 Maarten Lankhorst 2021-03-23 419
8475355f7a2645 Chris Wilson 2019-05-28 420 static int
8475355f7a2645 Chris Wilson 2019-05-28 421 shmem_pwrite(struct drm_i915_gem_object *obj,
8475355f7a2645 Chris Wilson 2019-05-28 422 const struct drm_i915_gem_pwrite *arg)
8475355f7a2645 Chris Wilson 2019-05-28 423 {
8475355f7a2645 Chris Wilson 2019-05-28 424 struct address_space *mapping = obj->base.filp->f_mapping;
c5edd542aa548d Matthew Wilcox (Oracle 2022-03-03 425) const struct address_space_operations *aops = mapping->a_ops;
8475355f7a2645 Chris Wilson 2019-05-28 426 char __user *user_data = u64_to_user_ptr(arg->data_ptr);
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 427) u64 remain;
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 428) loff_t pos;
8475355f7a2645 Chris Wilson 2019-05-28 429 unsigned int pg;
8475355f7a2645 Chris Wilson 2019-05-28 430
8475355f7a2645 Chris Wilson 2019-05-28 431 /* Caller already validated user args */
8475355f7a2645 Chris Wilson 2019-05-28 432 GEM_BUG_ON(!access_ok(user_data, arg->size));
8475355f7a2645 Chris Wilson 2019-05-28 433
a61170975718d5 Maarten Lankhorst 2021-03-23 434 if (!i915_gem_object_has_struct_page(obj))
a61170975718d5 Maarten Lankhorst 2021-03-23 435 return i915_gem_object_pwrite_phys(obj, arg);
a61170975718d5 Maarten Lankhorst 2021-03-23 436
8475355f7a2645 Chris Wilson 2019-05-28 437 /*
8475355f7a2645 Chris Wilson 2019-05-28 438 * Before we instantiate/pin the backing store for our use, we
8475355f7a2645 Chris Wilson 2019-05-28 439 * can prepopulate the shmemfs filp efficiently using a write into
8475355f7a2645 Chris Wilson 2019-05-28 440 * the pagecache. We avoid the penalty of instantiating all the
8475355f7a2645 Chris Wilson 2019-05-28 441 * pages, important if the user is just writing to a few and never
8475355f7a2645 Chris Wilson 2019-05-28 442 * uses the object on the GPU, and using a direct write into shmemfs
8475355f7a2645 Chris Wilson 2019-05-28 443 * allows it to avoid the cost of retrieving a page (either swapin
8475355f7a2645 Chris Wilson 2019-05-28 444 * or clearing-before-use) before it is overwritten.
8475355f7a2645 Chris Wilson 2019-05-28 445 */
8475355f7a2645 Chris Wilson 2019-05-28 446 if (i915_gem_object_has_pages(obj))
8475355f7a2645 Chris Wilson 2019-05-28 447 return -ENODEV;
8475355f7a2645 Chris Wilson 2019-05-28 448
8475355f7a2645 Chris Wilson 2019-05-28 449 if (obj->mm.madv != I915_MADV_WILLNEED)
8475355f7a2645 Chris Wilson 2019-05-28 450 return -EFAULT;
8475355f7a2645 Chris Wilson 2019-05-28 451
8475355f7a2645 Chris Wilson 2019-05-28 452 /*
8475355f7a2645 Chris Wilson 2019-05-28 453 * Before the pages are instantiated the object is treated as being
8475355f7a2645 Chris Wilson 2019-05-28 454 * in the CPU domain. The pages will be clflushed as required before
8475355f7a2645 Chris Wilson 2019-05-28 455 * use, and we can freely write into the pages directly. If userspace
8475355f7a2645 Chris Wilson 2019-05-28 456 * races pwrite with any other operation; corruption will ensue -
8475355f7a2645 Chris Wilson 2019-05-28 457 * that is userspace's prerogative!
8475355f7a2645 Chris Wilson 2019-05-28 458 */
8475355f7a2645 Chris Wilson 2019-05-28 459
8475355f7a2645 Chris Wilson 2019-05-28 460 remain = arg->size;
8475355f7a2645 Chris Wilson 2019-05-28 @461 offset = arg->offset;
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 462) pg = offset_in_page(pos);
8475355f7a2645 Chris Wilson 2019-05-28 463
8475355f7a2645 Chris Wilson 2019-05-28 464 do {
8475355f7a2645 Chris Wilson 2019-05-28 465 unsigned int len, unwritten;
8475355f7a2645 Chris Wilson 2019-05-28 466 struct page *page;
8475355f7a2645 Chris Wilson 2019-05-28 467 void *data, *vaddr;
8475355f7a2645 Chris Wilson 2019-05-28 468 int err;
ab438a61e4c367 Jani Nikula 2023-05-26 469 char __maybe_unused c;
8475355f7a2645 Chris Wilson 2019-05-28 470
8475355f7a2645 Chris Wilson 2019-05-28 471 len = PAGE_SIZE - pg;
8475355f7a2645 Chris Wilson 2019-05-28 472 if (len > remain)
8475355f7a2645 Chris Wilson 2019-05-28 473 len = remain;
8475355f7a2645 Chris Wilson 2019-05-28 474
8475355f7a2645 Chris Wilson 2019-05-28 475 /* Prefault the user page to reduce potential recursion */
8475355f7a2645 Chris Wilson 2019-05-28 476 err = __get_user(c, user_data);
8475355f7a2645 Chris Wilson 2019-05-28 477 if (err)
8475355f7a2645 Chris Wilson 2019-05-28 478 return err;
8475355f7a2645 Chris Wilson 2019-05-28 479
8475355f7a2645 Chris Wilson 2019-05-28 480 err = __get_user(c, user_data + len - 1);
8475355f7a2645 Chris Wilson 2019-05-28 481 if (err)
8475355f7a2645 Chris Wilson 2019-05-28 482 return err;
8475355f7a2645 Chris Wilson 2019-05-28 483
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 484) err = aops->write_begin(obj->base.filp, mapping, pos, len,
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 @485) &folio, &data);
8475355f7a2645 Chris Wilson 2019-05-28 486 if (err < 0)
8475355f7a2645 Chris Wilson 2019-05-28 487 return err;
8475355f7a2645 Chris Wilson 2019-05-28 488
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 489) vaddr = kmap_local_folio(folio, offset_in_folio(folio, pos));
756eed0f2602f7 Zhao Liu 2023-12-03 490 pagefault_disable();
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 491) unwritten = __copy_from_user_inatomic(vaddr, user_data, len);
756eed0f2602f7 Zhao Liu 2023-12-03 492 pagefault_enable();
756eed0f2602f7 Zhao Liu 2023-12-03 493 kunmap_local(vaddr);
8475355f7a2645 Chris Wilson 2019-05-28 494
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 495) err = aops->write_end(obj->base.filp, mapping, pos, len,
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 496) len - unwritten, folio, data);
8475355f7a2645 Chris Wilson 2019-05-28 497 if (err < 0)
8475355f7a2645 Chris Wilson 2019-05-28 498 return err;
8475355f7a2645 Chris Wilson 2019-05-28 499
8475355f7a2645 Chris Wilson 2019-05-28 500 /* We don't handle -EFAULT, leave it to the caller to check */
8475355f7a2645 Chris Wilson 2019-05-28 501 if (unwritten)
8475355f7a2645 Chris Wilson 2019-05-28 502 return -ENODEV;
8475355f7a2645 Chris Wilson 2019-05-28 503
8475355f7a2645 Chris Wilson 2019-05-28 504 remain -= len;
8475355f7a2645 Chris Wilson 2019-05-28 505 user_data += len;
a875d4f1443446 Matthew Wilcox (Oracle 2024-07-15 506) pos += len;
8475355f7a2645 Chris Wilson 2019-05-28 507 pg = 0;
8475355f7a2645 Chris Wilson 2019-05-28 508 } while (remain);
8475355f7a2645 Chris Wilson 2019-05-28 509
8475355f7a2645 Chris Wilson 2019-05-28 510 return 0;
8475355f7a2645 Chris Wilson 2019-05-28 511 }
8475355f7a2645 Chris Wilson 2019-05-28 512
:::::: The code at line 461 was first introduced by commit
:::::: 8475355f7a2645a022288301c03555c31fb4de17 drm/i915: Move shmem object setup to its own file
:::::: TO: Chris Wilson <chris@chris-wilson.co.uk>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-07-15 23:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-15 23:38 [willy-pagecache:write-end 52/52] drivers/gpu/drm/i915/gem/i915_gem_shmem.c:461:2: error: use of undeclared identifier 'offset' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.