Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0

From: Conor Dooley <conor@kernel.org>
To: Alexandre Ghiti <alex@ghiti.fr>
Cc: "Alexandre Ghiti" <alexghiti@rivosinc.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Björn Töpel" <bjorn@rivosinc.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Nathan Chancellor" <nathan@kernel.org>,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	"kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0
Date: Wed, 17 Jul 2024 13:43:09 +0100	[thread overview]
Message-ID: <20240717-catsup-corny-def9db822c4e@spud> (raw)
In-Reply-To: <203e8784-54f2-43ea-a442-833d7e4a06c8@ghiti.fr>

[-- Attachment #1.1: Type: text/plain, Size: 2315 bytes --]

On Wed, Jul 17, 2024 at 01:41:23PM +0200, Alexandre Ghiti wrote:

> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@intel.com/
> > > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > If Nathan wrote the patch, you need to set him as the author of the
> > patch :)
> 
> 
> I thought I did, how should I do that then?

$ shazam 20240717-synapse-decade-a0d41bd7afce@spud
Grabbing thread from lore.kernel.org/all/20240717-synapse-decade-a0d41bd7afce@spud/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 4 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH RFC] riscv: Allow to build only with LLVM >= 17.0.0
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ---
  ✓ Signed: DKIM/rivosinc-com.20230601.gappssmtp.com (From: alexghiti@rivosinc.com)
---
Total patches: 1
---
Applying: riscv: Allow to build only with LLVM >= 17.0.0
$ git show
commit f64f8420ca518b5dde35224cfff7ccfd14e5b496 (HEAD)
Author: Alexandre Ghiti <alexghiti@rivosinc.com>
Date:   Wed Jul 17 13:17:16 2024 +0200

    riscv: Allow to build only with LLVM >= 17.0.0

    The following build failure happens when using LLVM < 17.0.0:

    kernel/sched/core.c:11873:7: error: cannot jump from this asm goto statement to one of its possible targets

    This is a known issue [1] so let's upgrade the minimal requirement for
    LLVM to the version 17.0.0, which is the first version to contain the
    fix.

    Link: https://github.com/ClangBuiltLinux/linux/issues/1886#issuecomment-1645979992 [1]
    Reported-by: kernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202407041157.odTZAYZ6-lkp@intel.com/
    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
    Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

When you commited it, you needed to set --author. Just adding his
signoff is not sufficient.

Cheers,
Conor.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv