All of lore.kernel.org
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, imx@lists.linux.dev,
	loongarch@lists.linux.dev
Subject: [PATCH v1 4/4] ARM: dts: socfpga: remove non-existent DAC from CycloneV devkit
Date: Wed, 17 Jul 2024 10:37:56 +0100	[thread overview]
Message-ID: <20240717-partake-antivirus-3347e415fb7d@spud> (raw)
In-Reply-To: <20240717-anvil-ashy-544e80a1317c@spud>

From: Conor Dooley <conor.dooley@microchip.com>

There is no Rohm DAC on the CycloneV devkit according to the online
documentation for it that I could find, and it definitely does not have
a dh2228fv as this device does not actually exist! Remove the DAC node
from the devicetree as it is not acceptable to pretend to have a device
on a board in order to bind the spidev driver in Linux.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
index d37a982e8571..97622febc44e 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
@@ -151,12 +151,6 @@ partition@qspi-rootfs {
 
 &spi0 {
 	status = "okay";
-
-	spidev@0 {
-		compatible = "rohm,dh2228fv";
-		reg = <0>;
-		spi-max-frequency = <1000000>;
-	};
 };
 
 &usb1 {
-- 
2.43.0


WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
	Dinh Nguyen <dinguyen@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Huacai Chen <chenhuacai@kernel.org>,
	WANG Xuerui <kernel@xen0n.name>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, imx@lists.linux.dev,
	loongarch@lists.linux.dev
Subject: [PATCH v1 4/4] ARM: dts: socfpga: remove non-existent DAC from CycloneV devkit
Date: Wed, 17 Jul 2024 10:37:56 +0100	[thread overview]
Message-ID: <20240717-partake-antivirus-3347e415fb7d@spud> (raw)
In-Reply-To: <20240717-anvil-ashy-544e80a1317c@spud>

From: Conor Dooley <conor.dooley@microchip.com>

There is no Rohm DAC on the CycloneV devkit according to the online
documentation for it that I could find, and it definitely does not have
a dh2228fv as this device does not actually exist! Remove the DAC node
from the devicetree as it is not acceptable to pretend to have a device
on a board in order to bind the spidev driver in Linux.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
index d37a982e8571..97622febc44e 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_cyclone5_socdk.dts
@@ -151,12 +151,6 @@ partition@qspi-rootfs {
 
 &spi0 {
 	status = "okay";
-
-	spidev@0 {
-		compatible = "rohm,dh2228fv";
-		reg = <0>;
-		spi-max-frequency = <1000000>;
-	};
 };
 
 &usb1 {
-- 
2.43.0


_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  parent reply	other threads:[~2024-07-17  9:38 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17  9:37 [PATCH v1 0/4] Removal of non-existent DAC nodes Conor Dooley
2024-07-17  9:37 ` Conor Dooley
2024-07-17  9:37 ` [PATCH v1 1/4] arm64: dts: imx8: remove non-existent DACs Conor Dooley
2024-07-17  9:37   ` Conor Dooley
2024-07-17  9:38   ` Krzysztof Kozlowski
2024-07-17  9:38     ` Krzysztof Kozlowski
2024-08-12  9:43   ` Shawn Guo
2024-08-12  9:43     ` Shawn Guo
2024-07-17  9:37 ` [PATCH v1 2/4] ARM: dts: rockchip: remove unlikly-to-exist DAC from elgin-r1 Conor Dooley
2024-07-17  9:37   ` Conor Dooley
2024-07-17  9:39   ` Krzysztof Kozlowski
2024-07-17  9:39     ` Krzysztof Kozlowski
2024-07-17 10:18   ` Heiko Stübner
2024-07-17 10:18     ` Heiko Stübner
     [not found]     ` <CAP9ODKrpKDY91AFDYj7s++kU+=CSLw=F9mXyLZ621Mqq-8S6bw@mail.gmail.com>
2024-07-17 15:34       ` Fabio Estevam
2024-07-17 15:34         ` Fabio Estevam
2024-07-17 16:39         ` Conor Dooley
2024-07-17 16:39           ` Conor Dooley
2024-07-17 16:46   ` Fabio Estevam
2024-07-17 16:46     ` Fabio Estevam
2024-07-18  4:20   ` Dragan Simic
2024-07-18  4:20     ` Dragan Simic
2024-07-18  4:46     ` Dragan Simic
2024-07-18  4:46       ` Dragan Simic
2024-07-17  9:37 ` [PATCH v1 3/4] loongarch: dts: remove non-existent DAC from 2k1000-ref Conor Dooley
2024-07-17  9:37   ` Conor Dooley
2024-07-17  9:39   ` Krzysztof Kozlowski
2024-07-17  9:39     ` Krzysztof Kozlowski
2024-07-17  9:37 ` Conor Dooley [this message]
2024-07-17  9:37   ` [PATCH v1 4/4] ARM: dts: socfpga: remove non-existent DAC from CycloneV devkit Conor Dooley
2024-07-17  9:39   ` Krzysztof Kozlowski
2024-07-17  9:39     ` Krzysztof Kozlowski
2024-12-29 10:09   ` (subset) " Krzysztof Kozlowski
2024-12-29 10:09     ` Krzysztof Kozlowski
2025-02-12 20:49 ` (subset) [PATCH v1 0/4] Removal of non-existent DAC nodes Krzysztof Kozlowski
2025-02-12 20:49   ` Krzysztof Kozlowski
2025-02-13 20:05   ` Conor Dooley
2025-02-13 20:05     ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240717-partake-antivirus-3347e415fb7d@spud \
    --to=conor@kernel.org \
    --cc=chenhuacai@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@kernel.org \
    --cc=festevam@gmail.com \
    --cc=heiko@sntech.de \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=kernel@xen0n.name \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=loongarch@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.