All of lore.kernel.org
 help / color / mirror / Atom feed
* [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5
@ 2024-07-16  1:50 Denys Dmytriyenko
  2024-07-16  1:50 ` [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors Denys Dmytriyenko
  2024-07-16 14:22 ` [meta-arago] [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Ryan Eatmon
  0 siblings, 2 replies; 9+ messages in thread
From: Denys Dmytriyenko @ 2024-07-16  1:50 UTC (permalink / raw)
  To: meta-arago; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@konsulko.com>

As meta-qt5 is not going to fix the issues causing the errors:

https://github.com/meta-qt5/meta-qt5/issues/575

Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 meta-arago-distro/conf/distro/arago.conf | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
index deaa8c02..716068ba 100644
--- a/meta-arago-distro/conf/distro/arago.conf
+++ b/meta-arago-distro/conf/distro/arago.conf
@@ -188,3 +188,7 @@ LICENSE_FLAGS_ACCEPTED = "commercial_gst-ffmpeg commercial_gstreamer1.0-libav co
 
 # Do not package own copy of perl into devkit, rely on host one
 ASSUME_PROVIDED += "nativesdk-perl"
+
+# https://github.com/meta-qt5/meta-qt5/issues/575
+ERROR_QA:remove:layer-qt5-layer = "buildpaths"
+WARN_QA:append:layer-qt5-layer = " buildpaths"
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
  2024-07-16  1:50 [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Denys Dmytriyenko
@ 2024-07-16  1:50 ` Denys Dmytriyenko
  2024-07-17  0:37   ` [meta-arago] " Ryan Eatmon
       [not found]   ` <17E2D909CD64B7EE.6764@lists.yoctoproject.org>
  2024-07-16 14:22 ` [meta-arago] [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Ryan Eatmon
  1 sibling, 2 replies; 9+ messages in thread
From: Denys Dmytriyenko @ 2024-07-16  1:50 UTC (permalink / raw)
  To: meta-arago; +Cc: Denys Dmytriyenko

From: Denys Dmytriyenko <denys@konsulko.com>

Make sure llvm-configs doesn't have absolute build paths.

Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
---
 meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
index 4b990b7f..810c603b 100644
--- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
+++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
@@ -62,6 +62,11 @@ EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \
 
 EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""
 
+# patch out build host paths for reproducibility
+do_compile:prepend() {
+        sed -i -e "s,${WORKDIR},,g" ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
+}
+
 do_compile:class-native() {
   cd ${LLVM_BUILD_DIR}
 
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5
  2024-07-16  1:50 [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Denys Dmytriyenko
  2024-07-16  1:50 ` [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors Denys Dmytriyenko
@ 2024-07-16 14:22 ` Ryan Eatmon
  1 sibling, 0 replies; 9+ messages in thread
From: Ryan Eatmon @ 2024-07-16 14:22 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago; +Cc: Denys Dmytriyenko



On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
> 
> As meta-qt5 is not going to fix the issues causing the errors:
> 
> https://github.com/meta-qt5/meta-qt5/issues/575
> 
> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
>   meta-arago-distro/conf/distro/arago.conf | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/meta-arago-distro/conf/distro/arago.conf b/meta-arago-distro/conf/distro/arago.conf
> index deaa8c02..716068ba 100644
> --- a/meta-arago-distro/conf/distro/arago.conf
> +++ b/meta-arago-distro/conf/distro/arago.conf
> @@ -188,3 +188,7 @@ LICENSE_FLAGS_ACCEPTED = "commercial_gst-ffmpeg commercial_gstreamer1.0-libav co
>   
>   # Do not package own copy of perl into devkit, rely on host one
>   ASSUME_PROVIDED += "nativesdk-perl"
> +
> +# https://github.com/meta-qt5/meta-qt5/issues/575
> +ERROR_QA:remove:layer-qt5-layer = "buildpaths"
> +WARN_QA:append:layer-qt5-layer = " buildpaths"

Yeah, I saw that and thought this should be the answer.  Since 
meta-arago is not seeking compatible status this should be acceptable.


-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
  2024-07-16  1:50 ` [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors Denys Dmytriyenko
@ 2024-07-17  0:37   ` Ryan Eatmon
       [not found]   ` <17E2D909CD64B7EE.6764@lists.yoctoproject.org>
  1 sibling, 0 replies; 9+ messages in thread
From: Ryan Eatmon @ 2024-07-17  0:37 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago; +Cc: Denys Dmytriyenko



On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
> From: Denys Dmytriyenko <denys@konsulko.com>
> 
> Make sure llvm-configs doesn't have absolute build paths.
> 
> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
>   meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> index 4b990b7f..810c603b 100644
> --- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> +++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> @@ -62,6 +62,11 @@ EXTRA_OECONF += " --enable-targets="host,arm,c6000,msp430" \
>   
>   EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" LIBXML2_LIBS="${LIBXML2_LIBS}""
>   
> +# patch out build host paths for reproducibility
> +do_compile:prepend() {
> +        sed -i -e "s,${WORKDIR},,g" ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
> +}
> +
>   do_compile:class-native() {
>     cd ${LLVM_BUILD_DIR}
>   

I'm getting build errors with this.

native:

sed: can't read 
/scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: 
No such file or directory

nativesdk:

sed: can't read 
/scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: 
No such file or directory


-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
       [not found]   ` <17E2D909CD64B7EE.6764@lists.yoctoproject.org>
@ 2024-07-17  1:36     ` Ryan Eatmon
       [not found]     ` <17E2DC4752C1D1A6.6764@lists.yoctoproject.org>
  1 sibling, 0 replies; 9+ messages in thread
From: Ryan Eatmon @ 2024-07-17  1:36 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago; +Cc: Denys Dmytriyenko



On 7/16/2024 7:37 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
>> From: Denys Dmytriyenko <denys@konsulko.com>
>>
>> Make sure llvm-configs doesn't have absolute build paths.
>>
>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
>> ---
>>   meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb 
>> b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>> index 4b990b7f..810c603b 100644
>> --- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>> +++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>> @@ -62,6 +62,11 @@ EXTRA_OECONF += " 
>> --enable-targets="host,arm,c6000,msp430" \
>>   EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" 
>> LIBXML2_LIBS="${LIBXML2_LIBS}""
>> +# patch out build host paths for reproducibility
>> +do_compile:prepend() {
>> +        sed -i -e "s,${WORKDIR},,g" 
>> ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
>> +}
>> +
>>   do_compile:class-native() {
>>     cd ${LLVM_BUILD_DIR}
> 
> I'm getting build errors with this.
> 
> native:
> 
> sed: can't read 
> /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory
> 
> nativesdk:
> 
> sed: can't read 
> /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory
> 

I think that during the build it creates this file, but before the 
builds the files does not exist yet.  Maybe you tested this against a 
built directory where the file existed but from a clean dir it fails?


-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
       [not found]     ` <17E2DC4752C1D1A6.6764@lists.yoctoproject.org>
@ 2024-07-17 13:45       ` Ryan Eatmon
  2024-07-17 16:56         ` Denys Dmytriyenko
  0 siblings, 1 reply; 9+ messages in thread
From: Ryan Eatmon @ 2024-07-17 13:45 UTC (permalink / raw)
  To: Denys Dmytriyenko, meta-arago; +Cc: Denys Dmytriyenko



On 7/16/2024 8:36 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> 
> 
> On 7/16/2024 7:37 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>>
>>
>> On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
>>> From: Denys Dmytriyenko <denys@konsulko.com>
>>>
>>> Make sure llvm-configs doesn't have absolute build paths.
>>>
>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
>>> ---
>>>   meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb 
>>> b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>> index 4b990b7f..810c603b 100644
>>> --- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>> +++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>> @@ -62,6 +62,11 @@ EXTRA_OECONF += " 
>>> --enable-targets="host,arm,c6000,msp430" \
>>>   EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}" 
>>> LIBXML2_LIBS="${LIBXML2_LIBS}""
>>> +# patch out build host paths for reproducibility
>>> +do_compile:prepend() {
>>> +        sed -i -e "s,${WORKDIR},,g" 
>>> ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
>>> +}
>>> +
>>>   do_compile:class-native() {
>>>     cd ${LLVM_BUILD_DIR}
>>
>> I'm getting build errors with this.
>>
>> native:
>>
>> sed: can't read 
>> /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory
>>
>> nativesdk:
>>
>> sed: can't read 
>> /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc: No such file or directory
>>
> 
> I think that during the build it creates this file, but before the 
> builds the files does not exist yet.  Maybe you tested this against a 
> built directory where the file existed but from a clean dir it fails?
> 

Also, it looks the contents of the BuildVariables.inc might be in a 
"bad" state with this change.  But I could be wrong as I don't know how 
all of this package works.

#define LLVM_SRC_ROOT "/git"
#define LLVM_OBJ_ROOT "/llvm-3.6.build"

By just replacing the WORKDIR with "" we are pointing this file to the 
root directory where I doubt these things will be living.  Again, 
without knowing how this package works and uses those two variables I 
can't speak as to the correctness of this.  I agree it fixes the 
buildpaths issue, but does it break the software package at that point?



-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
  2024-07-17 13:45       ` Ryan Eatmon
@ 2024-07-17 16:56         ` Denys Dmytriyenko
  2024-07-17 17:03           ` Ryan Eatmon
  0 siblings, 1 reply; 9+ messages in thread
From: Denys Dmytriyenko @ 2024-07-17 16:56 UTC (permalink / raw)
  To: Ryan Eatmon; +Cc: meta-arago

On Wed, Jul 17, 2024 at 08:45:58AM -0500, Ryan Eatmon wrote:
> 
> 
> On 7/16/2024 8:36 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >
> >
> >On 7/16/2024 7:37 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>
> >>
> >>On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
> >>>From: Denys Dmytriyenko <denys@konsulko.com>
> >>>
> >>>Make sure llvm-configs doesn't have absolute build paths.
> >>>
> >>>Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >>>---
> >>>  meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
> >>>  1 file changed, 5 insertions(+)
> >>>
> >>>diff --git
> >>>a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>index 4b990b7f..810c603b 100644
> >>>--- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>+++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>@@ -62,6 +62,11 @@ EXTRA_OECONF += "
> >>>--enable-targets="host,arm,c6000,msp430" \
> >>>  EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"
> >>>LIBXML2_LIBS="${LIBXML2_LIBS}""
> >>>+# patch out build host paths for reproducibility
> >>>+do_compile:prepend() {
> >>>+        sed -i -e "s,${WORKDIR},,g"
> >>>${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
> >>>+}
> >>>+
> >>>  do_compile:class-native() {
> >>>    cd ${LLVM_BUILD_DIR}
> >>
> >>I'm getting build errors with this.
> >>
> >>native:
> >>
> >>sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
> >>No such file or directory
> >>
> >>nativesdk:
> >>
> >>sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
> >>No such file or directory
> >>
> >
> >I think that during the build it creates this file, but before the
> >builds the files does not exist yet.  Maybe you tested this
> >against a built directory where the file existed but from a clean
> >dir it fails?
> >
> 
> Also, it looks the contents of the BuildVariables.inc might be in a
> "bad" state with this change.  But I could be wrong as I don't know
> how all of this package works.
> 
> #define LLVM_SRC_ROOT "/git"
> #define LLVM_OBJ_ROOT "/llvm-3.6.build"
> 
> By just replacing the WORKDIR with "" we are pointing this file to
> the root directory where I doubt these things will be living.
> Again, without knowing how this package works and uses those two
> variables I can't speak as to the correctness of this.  I agree it
> fixes the buildpaths issue, but does it break the software package
> at that point?

This is exactly what OE-Core does with upstream LLVM.

-- 
Denys


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
  2024-07-17 16:56         ` Denys Dmytriyenko
@ 2024-07-17 17:03           ` Ryan Eatmon
  2024-07-17 17:16             ` Denys Dmytriyenko
  0 siblings, 1 reply; 9+ messages in thread
From: Ryan Eatmon @ 2024-07-17 17:03 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: meta-arago



On 7/17/2024 11:56 AM, Denys Dmytriyenko wrote:
> On Wed, Jul 17, 2024 at 08:45:58AM -0500, Ryan Eatmon wrote:
>>
>>
>> On 7/16/2024 8:36 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>>>
>>>
>>> On 7/16/2024 7:37 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
>>>>
>>>>
>>>> On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
>>>>> From: Denys Dmytriyenko <denys@konsulko.com>
>>>>>
>>>>> Make sure llvm-configs doesn't have absolute build paths.
>>>>>
>>>>> Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
>>>>> ---
>>>>>    meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
>>>>>    1 file changed, 5 insertions(+)
>>>>>
>>>>> diff --git
>>>>> a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>>>> b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>>>> index 4b990b7f..810c603b 100644
>>>>> --- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>>>> +++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
>>>>> @@ -62,6 +62,11 @@ EXTRA_OECONF += "
>>>>> --enable-targets="host,arm,c6000,msp430" \
>>>>>    EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"
>>>>> LIBXML2_LIBS="${LIBXML2_LIBS}""
>>>>> +# patch out build host paths for reproducibility
>>>>> +do_compile:prepend() {
>>>>> +        sed -i -e "s,${WORKDIR},,g"
>>>>> ${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
>>>>> +}
>>>>> +
>>>>>    do_compile:class-native() {
>>>>>      cd ${LLVM_BUILD_DIR}
>>>>
>>>> I'm getting build errors with this.
>>>>
>>>> native:
>>>>
>>>> sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
>>>> No such file or directory
>>>>
>>>> nativesdk:
>>>>
>>>> sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
>>>> No such file or directory
>>>>
>>>
>>> I think that during the build it creates this file, but before the
>>> builds the files does not exist yet.  Maybe you tested this
>>> against a built directory where the file existed but from a clean
>>> dir it fails?
>>>
>>
>> Also, it looks the contents of the BuildVariables.inc might be in a
>> "bad" state with this change.  But I could be wrong as I don't know
>> how all of this package works.
>>
>> #define LLVM_SRC_ROOT "/git"
>> #define LLVM_OBJ_ROOT "/llvm-3.6.build"
>>
>> By just replacing the WORKDIR with "" we are pointing this file to
>> the root directory where I doubt these things will be living.
>> Again, without knowing how this package works and uses those two
>> variables I can't speak as to the correctness of this.  I agree it
>> fixes the buildpaths issue, but does it break the software package
>> at that point?
> 
> This is exactly what OE-Core does with upstream LLVM.
> 

Good enough for me then. =)

-- 
Ryan Eatmon                reatmon@ti.com
-----------------------------------------
Texas Instruments, Inc.  -  LCPD  -  MGTS


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [meta-arago] [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors
  2024-07-17 17:03           ` Ryan Eatmon
@ 2024-07-17 17:16             ` Denys Dmytriyenko
  0 siblings, 0 replies; 9+ messages in thread
From: Denys Dmytriyenko @ 2024-07-17 17:16 UTC (permalink / raw)
  To: Ryan Eatmon; +Cc: meta-arago

On Wed, Jul 17, 2024 at 12:03:57PM -0500, Ryan Eatmon wrote:
> 
> 
> On 7/17/2024 11:56 AM, Denys Dmytriyenko wrote:
> >On Wed, Jul 17, 2024 at 08:45:58AM -0500, Ryan Eatmon wrote:
> >>
> >>
> >>On 7/16/2024 8:36 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>>
> >>>
> >>>On 7/16/2024 7:37 PM, Ryan Eatmon via lists.yoctoproject.org wrote:
> >>>>
> >>>>
> >>>>On 7/15/2024 8:50 PM, Denys Dmytriyenko wrote:
> >>>>>From: Denys Dmytriyenko <denys@konsulko.com>
> >>>>>
> >>>>>Make sure llvm-configs doesn't have absolute build paths.
> >>>>>
> >>>>>Signed-off-by: Denys Dmytriyenko <denys@konsulko.com>
> >>>>>---
> >>>>>   meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb | 5 +++++
> >>>>>   1 file changed, 5 insertions(+)
> >>>>>
> >>>>>diff --git
> >>>>>a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>>>b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>>>index 4b990b7f..810c603b 100644
> >>>>>--- a/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>>>+++ b/meta-arago-extras/recipes-core/llvm/ti-llvm3.6_3.6.bb
> >>>>>@@ -62,6 +62,11 @@ EXTRA_OECONF += "
> >>>>>--enable-targets="host,arm,c6000,msp430" \
> >>>>>   EXTRA_OEMAKE += "LIBXML2_INC="${LIBXML2_INC}"
> >>>>>LIBXML2_LIBS="${LIBXML2_LIBS}""
> >>>>>+# patch out build host paths for reproducibility
> >>>>>+do_compile:prepend() {
> >>>>>+        sed -i -e "s,${WORKDIR},,g"
> >>>>>${LLVM_BUILD_DIR}/tools/llvm-config/Release/BuildVariables.inc
> >>>>>+}
> >>>>>+
> >>>>>   do_compile:class-native() {
> >>>>>     cd ${LLVM_BUILD_DIR}
> >>>>
> >>>>I'm getting build errors with this.
> >>>>
> >>>>native:
> >>>>
> >>>>sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-linux/ti-llvm3.6-native/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
> >>>>No such file or directory
> >>>>
> >>>>nativesdk:
> >>>>
> >>>>sed: can't read /scratch/jenkins_builds/arago-master-wip/build/build/arago-tmp-default-glibc/work/x86_64-nativesdk-arago-linux/nativesdk-ti-llvm3.6/3.6/llvm-3.6.build/tools/llvm-config/Release/BuildVariables.inc:
> >>>>No such file or directory
> >>>>
> >>>
> >>>I think that during the build it creates this file, but before the
> >>>builds the files does not exist yet.  Maybe you tested this
> >>>against a built directory where the file existed but from a clean
> >>>dir it fails?
> >>>
> >>
> >>Also, it looks the contents of the BuildVariables.inc might be in a
> >>"bad" state with this change.  But I could be wrong as I don't know
> >>how all of this package works.
> >>
> >>#define LLVM_SRC_ROOT "/git"
> >>#define LLVM_OBJ_ROOT "/llvm-3.6.build"
> >>
> >>By just replacing the WORKDIR with "" we are pointing this file to
> >>the root directory where I doubt these things will be living.
> >>Again, without knowing how this package works and uses those two
> >>variables I can't speak as to the correctness of this.  I agree it
> >>fixes the buildpaths issue, but does it break the software package
> >>at that point?
> >
> >This is exactly what OE-Core does with upstream LLVM.
> >
> 
> Good enough for me then. =)

https://git.openembedded.org/openembedded-core/commit/?h=master-next&id=55c1cccff5afc1230d3c2287bc0fdaa579bf2743

The only difference is that much newer LLVM 18.1.8 (vs. 3.6 here) apparently 
generates BuildVariables.inc file in do_configure() and not in do_compile()
so it already exists for the sed command...

-- 
Denys


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-07-17 17:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-16  1:50 [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Denys Dmytriyenko
2024-07-16  1:50 ` [master][PATCH] ti-llvm: adopt an LLVM fix for buildpaths errors Denys Dmytriyenko
2024-07-17  0:37   ` [meta-arago] " Ryan Eatmon
     [not found]   ` <17E2D909CD64B7EE.6764@lists.yoctoproject.org>
2024-07-17  1:36     ` Ryan Eatmon
     [not found]     ` <17E2DC4752C1D1A6.6764@lists.yoctoproject.org>
2024-07-17 13:45       ` Ryan Eatmon
2024-07-17 16:56         ` Denys Dmytriyenko
2024-07-17 17:03           ` Ryan Eatmon
2024-07-17 17:16             ` Denys Dmytriyenko
2024-07-16 14:22 ` [meta-arago] [master][PATCH] arago.conf: disable buildpaths QA errors in meta-qt5 Ryan Eatmon

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.