From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bjorn Andersson" <andersson@kernel.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Chester Lin" <chester62515@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Doug Berger" <opendmb@gmail.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Fabio Estevam" <festevam@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ghennadi Procopciuc" <ghennadi.procopciuc@oss.nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jacky Bai" <ping.bai@nxp.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mark Brown" <broonie@kernel.org>,
"Matthias Brugger" <mbrugger@suse.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michael Turquette" <mturquette@baylibre.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Richard Leitner" <richard.leitner@linux.dev>,
"Rob Herring" <robh@kernel.org>,
"Roger Quadros" <rogerq@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Saravana Kannan" <saravanak@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Tony Lindgren" <tony@atomide.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
llvm@lists.linux.dev, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org,
"Andre Przywara" <andre.przywara@arm.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>
Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()
Date: Thu, 18 Jul 2024 08:56:51 +0200 [thread overview]
Message-ID: <20240718085651.63ddfb20@booty> (raw)
In-Reply-To: <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org>
Hello Stephen,
On Wed, 17 Jul 2024 16:33:34 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client,
> > * property silabs,pll-source : <num src>, [<..>]
> > * allow to selectively set pll source
> > */
> > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) {
> > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4);
> > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */
> > + if (sz < 0)
> > + return dev_err_probe(&client->dev, sz, "invalid pll-source");
>
> Needs a newline on the printk message.
Ouch! Fix queued for v3.
Thanks,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Bjorn Andersson" <andersson@kernel.org>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Chester Lin" <chester62515@gmail.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Doug Berger" <opendmb@gmail.com>,
"Emilio López" <emilio@elopez.com.ar>,
"Fabio Estevam" <festevam@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Ghennadi Procopciuc" <ghennadi.procopciuc@oss.nxp.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jacky Bai" <ping.bai@nxp.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Kevin Hilman" <khilman@baylibre.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Lee Jones" <lee@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mark Brown" <broonie@kernel.org>,
"Matthias Brugger" <mbrugger@suse.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Michael Turquette" <mturquette@baylibre.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Richard Leitner" <richard.leitner@linux.dev>,
"Rob Herring" <robh@kernel.org>,
"Roger Quadros" <rogerq@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Saravana Kannan" <saravanak@google.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Tony Lindgren" <tony@atomide.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
llvm@lists.linux.dev, linux-clk@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org,
linux-pwm@vger.kernel.org, linux-serial@vger.kernel.org,
linux-usb@vger.kernel.org, patches@opensource.cirrus.com,
linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-riscv@lists.infradead.org,
"Andre Przywara" <andre.przywara@arm.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>
Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()
Date: Thu, 18 Jul 2024 08:56:51 +0200 [thread overview]
Message-ID: <20240718085651.63ddfb20@booty> (raw)
In-Reply-To: <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org>
Hello Stephen,
On Wed, 17 Jul 2024 16:33:34 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client,
> > * property silabs,pll-source : <num src>, [<..>]
> > * allow to selectively set pll source
> > */
> > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) {
> > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4);
> > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */
> > + if (sz < 0)
> > + return dev_err_probe(&client->dev, sz, "invalid pll-source");
>
> Needs a newline on the printk message.
Ouch! Fix queued for v3.
Thanks,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Stephen Boyd <sboyd@kernel.org>
Cc: linux-riscv@lists.infradead.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Lee Jones" <lee@kernel.org>, "Jacky Bai" <ping.bai@nxp.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Tony Lindgren" <tony@atomide.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
llvm@lists.linux.dev,
"Richard Leitner" <richard.leitner@linux.dev>,
"Jaroslav Kysela" <perex@perex.cz>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org, patches@opensource.cirrus.com,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Ghennadi Procopciuc" <ghennadi.procopciuc@oss.nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Doug Berger" <opendmb@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Emilio López" <emilio@elopez.com.ar>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Chen-Yu Tsai" <wens@csie.org>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
linux-serial@vger.kernel.org,
"Andre Przywara" <andre.przywara@arm.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
linux-usb@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Peng Fan (OSS)" <peng.fan@oss.nxp.com>,
linux-arm-msm@vger.kernel.org,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
linuxppc-dev@lists.ozlabs.org,
"Nicholas Piggin" <npiggin@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
linux-pwm@vger.kernel.org, linux-sound@vger.kernel.org,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Chester Lin" <chester62515@gmail.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Matthias Brugger" <mbrugger@suse.com>,
"Saravana Kannan" <saravanak@google.com>,
linux-gpio@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Samuel Holland" <samuel@sholland.org>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mark Brown" <broonie@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Kevin Hilman" <khilman@baylibre.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Shawn Guo" <shawnguo@kernel.org>,
linux-sunxi@lists.linux.dev,
"Jonathan Cameron" <jic23@kernel.org>
Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()
Date: Thu, 18 Jul 2024 08:56:51 +0200 [thread overview]
Message-ID: <20240718085651.63ddfb20@booty> (raw)
In-Reply-To: <1e36b1ba8af3584128550822a70cb072.sboyd@kernel.org>
Hello Stephen,
On Wed, 17 Jul 2024 16:33:34 -0700
Stephen Boyd <sboyd@kernel.org> wrote:
> > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client,
> > * property silabs,pll-source : <num src>, [<..>]
> > * allow to selectively set pll source
> > */
> > - of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) {
> > + sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4);
> > + sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */
> > + if (sz < 0)
> > + return dev_err_probe(&client->dev, sz, "invalid pll-source");
>
> Needs a newline on the printk message.
Ouch! Fix queued for v3.
Thanks,
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-07-18 6:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 16:16 [PATCH v2] of: remove internal arguments from of_property_for_each_u32() Luca Ceresoli
2024-07-17 16:16 ` Luca Ceresoli
2024-07-17 16:16 ` Luca Ceresoli
2024-07-17 23:33 ` Stephen Boyd
2024-07-17 23:33 ` Stephen Boyd
2024-07-17 23:33 ` Stephen Boyd
2024-07-18 6:56 ` Luca Ceresoli [this message]
2024-07-18 6:56 ` Luca Ceresoli
2024-07-18 6:56 ` Luca Ceresoli
2024-07-24 13:53 ` Rob Herring
2024-07-24 13:53 ` Rob Herring
2024-07-24 13:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718085651.63ddfb20@booty \
--to=luca.ceresoli@bootlin.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=aaro.koskinen@iki.fi \
--cc=aisheng.dong@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=andre.przywara@arm.com \
--cc=andreas@kemnade.info \
--cc=bartosz.golaszewski@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=chester62515@gmail.com \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.beznea@tuxon.dev \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=emilio@elopez.com.ar \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=mbrugger@suse.com \
--cc=mpe@ellerman.id.au \
--cc=mturquette@baylibre.com \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=nicolas.ferre@microchip.com \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=opendmb@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=peng.fan@oss.nxp.com \
--cc=perex@perex.cz \
--cc=ping.bai@nxp.com \
--cc=rf@opensource.cirrus.com \
--cc=richard.leitner@linux.dev \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=samuel@sholland.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=ukleinek@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.