All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
	Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture()
Date: Fri, 19 Jul 2024 09:33:40 +0900	[thread overview]
Message-ID: <20240719003340.GA381736@workstation.local> (raw)
In-Reply-To: <87zfqel1g7.wl-kuninori.morimoto.gx@renesas.com>

Hi,

On Thu, Jul 18, 2024 at 11:34:01PM +0000, Kuninori Morimoto wrote:
> Current many drivers are using below code to know its direction.
> 
> 	if (direction == SNDRV_PCM_STREAM_PLAYBACK)
> 
> I think it should be handled by function. But is it acceptable idea ?
> Because it will be too many patch-set, I want to know it was acceptable
> idea or not before posting patch-bomb.
> 
> I will post main patch, and sample driver patches.

It is better to rename these inline functions introduced in this
patchset so that they belong to PCM category, since in Linux sound
subsystem there is another type of substream in rawmidi category.

The concept of 'substream' corresponds to 'subdevice' in some operations
to PCM/RawMidi cdev, thus should be handled with enough care as much as
possible, in my opinion.


Regards

Takashi Sakamoto

  parent reply	other threads:[~2024-07-19  0:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 23:34 [RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture() Kuninori Morimoto
2024-07-18 23:34 ` [RFC 01/xx] ALSA: add snd_stream_is_playback/capture() macro Kuninori Morimoto
2024-07-19  7:17   ` Amadeusz Sławiński
2024-07-22  0:02     ` Kuninori Morimoto
2024-07-22  5:58       ` Kuninori Morimoto
2024-07-22  8:16         ` Takashi Iwai
2024-07-22  8:47           ` Pierre-Louis Bossart
2024-07-22  9:27             ` Amadeusz Sławiński
2024-07-23  0:43               ` Kuninori Morimoto
2024-07-22  9:23         ` Amadeusz Sławiński
2024-07-23  0:20           ` Kuninori Morimoto
2024-07-18 23:34 ` [RFC 02/xx] soundwire: intel: use snd_[sub]stream_is_playback/capture() Kuninori Morimoto
2024-07-18 23:35 ` [RFC 03/xx] ALSA: virtio: " Kuninori Morimoto
2024-07-18 23:35 ` [RFC 04/xx] ASoC: tegra: " Kuninori Morimoto
2024-07-19  0:33 ` Takashi Sakamoto [this message]
2024-07-19  1:02   ` [RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture() Kuninori Morimoto
2024-07-19  7:48 ` Takashi Iwai
2024-07-22  0:02   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240719003340.GA381736@workstation.local \
    --to=o-takashi@sakamocchi.jp \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.