From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [RFC 01/xx] ALSA: add snd_stream_is_playback/capture() macro
Date: Mon, 22 Jul 2024 11:27:20 +0200 [thread overview]
Message-ID: <df2f2cc2-6d5b-4f4b-9edc-84ba1fde4d3f@linux.intel.com> (raw)
In-Reply-To: <85450b77-d68f-45e2-bef1-6082bc56fa59@linux.intel.com>
On 7/22/2024 10:47 AM, Pierre-Louis Bossart wrote:
> The main issue I have with this patch is the continued confusion in
> variable naming between 'stream' and 'direction'. It's problematic on
> multiple platforms where a stream is typically identified by a DMA
> channel or ID of some sort. There's also the SoundWire 'stream' which
> has nothing to do with PCM devices. In the end people end-up drowning in
> too many 'streams', no one knows if the code refers to the data flow or
> the data direction.
Oh yes, so I'm not the only one :D, I also would very much prefer if
there was 'direction' instead of 'stream'.
next prev parent reply other threads:[~2024-07-22 9:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 23:34 [RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture() Kuninori Morimoto
2024-07-18 23:34 ` [RFC 01/xx] ALSA: add snd_stream_is_playback/capture() macro Kuninori Morimoto
2024-07-19 7:17 ` Amadeusz Sławiński
2024-07-22 0:02 ` Kuninori Morimoto
2024-07-22 5:58 ` Kuninori Morimoto
2024-07-22 8:16 ` Takashi Iwai
2024-07-22 8:47 ` Pierre-Louis Bossart
2024-07-22 9:27 ` Amadeusz Sławiński [this message]
2024-07-23 0:43 ` Kuninori Morimoto
2024-07-22 9:23 ` Amadeusz Sławiński
2024-07-23 0:20 ` Kuninori Morimoto
2024-07-18 23:34 ` [RFC 02/xx] soundwire: intel: use snd_[sub]stream_is_playback/capture() Kuninori Morimoto
2024-07-18 23:35 ` [RFC 03/xx] ALSA: virtio: " Kuninori Morimoto
2024-07-18 23:35 ` [RFC 04/xx] ASoC: tegra: " Kuninori Morimoto
2024-07-19 0:33 ` [RFC 00/xx] ALSA: ALSA: add snd_stream_is_playback/capture() Takashi Sakamoto
2024-07-19 1:02 ` Kuninori Morimoto
2024-07-19 7:48 ` Takashi Iwai
2024-07-22 0:02 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df2f2cc2-6d5b-4f4b-9edc-84ba1fde4d3f@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.