* + um-mm-remove-redundant-assignment-of-max_low_pfn.patch added to mm-unstable branch
@ 2024-07-23 23:47 Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2024-07-23 23:47 UTC (permalink / raw)
To: mm-commits, rppt, jdike, david, blaisorblade, agk,
richard.weiyang, akpm
The patch titled
Subject: um/mm: remove redundant assignment of max_low_pfn
has been added to the -mm mm-unstable branch. Its filename is
um-mm-remove-redundant-assignment-of-max_low_pfn.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/um-mm-remove-redundant-assignment-of-max_low_pfn.patch
This patch will later appear in the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via the mm-everything
branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there every 2-3 working days
------------------------------------------------------
From: Wei Yang <richard.weiyang@gmail.com>
Subject: um/mm: remove redundant assignment of max_low_pfn
Date: Sat, 15 Jun 2024 03:41:50 +0000
Current calculation of max_low_pfn is introduced in commit af84eab20891
("[PATCH] uml: fix LVM crash"). It is intended to set max_low_pfn to the
same value as max_pfn.
But I am not sure why the max_pfn is set to totalram_pages, which
represents the number of usable pages in system instead of an absolute
page frame number. (The change history stops there.)
While we have already calculate it in setup_physmem(), so not necessary to
do it again.
Also this would help changing totalram_pages accounting, since we plan to
move the accounting into __free_pages_core(). With this change,
totalram_pages may not represent the total usable pages at this point,
since some pages would be deferred initialized.
Link: https://lkml.kernel.org/r/20240615034150.2958-1-richard.weiyang@gmail.com
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Acked-by: Mike Rapoport (IBM) <rppt@kernel.org>
Cc: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Alasdair G Kergon <agk@redhat.com>
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/um/kernel/mem.c | 1 -
1 file changed, 1 deletion(-)
--- a/arch/um/kernel/mem.c~um-mm-remove-redundant-assignment-of-max_low_pfn
+++ a/arch/um/kernel/mem.c
@@ -73,7 +73,6 @@ void __init mem_init(void)
/* this will put all low memory onto the freelists */
memblock_free_all();
- max_low_pfn = totalram_pages();
max_pfn = max_low_pfn;
kmalloc_ok = 1;
}
_
Patches currently in -mm which might be from richard.weiyang@gmail.com are
um-mm-remove-redundant-assignment-of-max_low_pfn.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-07-23 23:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-23 23:47 + um-mm-remove-redundant-assignment-of-max_low_pfn.patch added to mm-unstable branch Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.