[Buildroot] [PATCH 1/1] package/elfutils: fix build on microblaze

[Buildroot] [PATCH 1/1] package/elfutils: fix build on microblaze

[Dario Binacchi]

Fix the following build failure on microblaze:

dwelf_elf_begin.c:62:1: error: symver is only supported on ELF platforms
   62 | OLD_VERSION (dwelf_elf_begin, ELFUTILS_0.175)
      | ^~~~~~~~~~~
dwelf_elf_begin.c:62:1: error: symver is only supported on ELF platforms

Fixes:
 - http://autobuild.buildroot.org/results/5ca2aa5c76415690ad4a85837ba47e7bcfbdbcbc

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---
 package/elfutils/elfutils.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/elfutils/elfutils.mk b/package/elfutils/elfutils.mk
index 4d8cc43342e8..a648432ed38f 100644
--- a/package/elfutils/elfutils.mk
+++ b/package/elfutils/elfutils.mk
@@ -45,6 +45,10 @@ ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 ELFUTILS_CONF_OPTS += --disable-symbol-versioning
 endif
 
+ifeq ($(BR2_microblazebe),y)
+ELFUTILS_CONF_OPTS += --disable-symbol-versioning
+endif
+
 # disable for now, needs "distro" support
 ELFUTILS_CONF_OPTS += --disable-libdebuginfod --disable-debuginfod
 HOST_ELFUTILS_CONF_OPTS += --disable-libdebuginfod --disable-debuginfod
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/elfutils: fix build on microblaze

[Thomas Petazzoni via buildroot]

On Thu, 25 Jul 2024 10:06:41 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> +ifeq ($(BR2_microblazebe),y)

I've changed to:

ifeq ($(BR2_microblaze),y)

as the issue applies to both LE and BE Microblaze, and applied.

Although we do have a proposal for a more general solution to this
problem: add symber attribute support for Microblaze, in patch:

  https://patchwork.ozlabs.org/project/buildroot/patch/20240228165300.4158751-1-vfazio@gmail.com/

Problem is that the patch proposed by Vincent is apparently not going
to be accepted by upstream gcc, so we would carry it forever, so I'm
not sure which decision to take about it.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/elfutils: fix build on microblaze

[Vincent Fazio]

All,

On Fri, Jul 26, 2024 at 2:40 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Thu, 25 Jul 2024 10:06:41 +0200
> Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:
>
> > +ifeq ($(BR2_microblazebe),y)
>
> I've changed to:
>
> ifeq ($(BR2_microblaze),y)
>
> as the issue applies to both LE and BE Microblaze, and applied.
>
> Although we do have a proposal for a more general solution to this
> problem: add symber attribute support for Microblaze, in patch:
>
>   https://patchwork.ozlabs.org/project/buildroot/patch/20240228165300.4158751-1-vfazio@gmail.com/
>
> Problem is that the patch proposed by Vincent is apparently not going
> to be accepted by upstream gcc, so we would carry it forever, so I'm
> not sure which decision to take about it.

I'm not sure it _won't_ be accepted, I just know one user was vocal
about a migration to elfos.h.

The migration is non-trivial (for me), hence the patch to port semver.
I could submit this upstream
but I haven't had time to look into performing regression builds/tests
for the change.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/elfutils: fix build on microblaze

[Peter Korsgaard]

>>>>> "Dario" == Dario Binacchi <dario.binacchi@amarulasolutions.com> writes:

 > Fix the following build failure on microblaze:
 > dwelf_elf_begin.c:62:1: error: symver is only supported on ELF platforms
 >    62 | OLD_VERSION (dwelf_elf_begin, ELFUTILS_0.175)
 >       | ^~~~~~~~~~~
 > dwelf_elf_begin.c:62:1: error: symver is only supported on ELF platforms

 > Fixes:
 >  - http://autobuild.buildroot.org/results/5ca2aa5c76415690ad4a85837ba47e7bcfbdbcbc

 > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

Committed to 2024.02.x and 2024.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot