From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Anand Moon <linux.amoon@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/3] arm64: dts: rockchip: Add missing pinctrl for PCIe20x1 node
Date: Fri, 26 Jul 2024 16:30:46 +0530 [thread overview]
Message-ID: <20240726110050.3664-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20240726110050.3664-1-linux.amoon@gmail.com>
Add missing pinctrl settings for PCIe 2.0 x1 clock request and wake
signals. Each component of PCIe communication have the following control
signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate
high-speed signals and communicate with other PCIe devices.
Used by root complex to endpoint depending on the power state.
PERST is referred to as a fundamental reset. PERST should be held low
until all the power rails in the system and the reference clock are stable.
A transition from low to high in this signal usually indicates the
beginning of link initialization.
WAKE signal is an active-low signal that is used to return the PCIe
interface to an active state when in a low-power state.
CLKREQ signal is also an active-low signal and is used to request the
reference clock.
Rename node from 'pcie2' to 'pcie20x1' to align with schematic
nomenclature.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v4: rebase on master, used RK_FUNC_GPIO GPIO function instead of PIN
number.
V3: New patch.
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index eeae14842b71..813a28b8916e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -326,7 +326,7 @@ &pcie2x1l0 {
&pcie2x1l2 {
pinctrl-names = "default";
- pinctrl-0 = <&pcie2_2_rst>;
+ pinctrl-0 = <&pcie20x12_pins>;
reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>;
vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
status = "okay";
@@ -363,9 +363,15 @@ hp_detect: hp-detect {
};
};
- pcie2 {
- pcie2_2_rst: pcie2-2-rst {
- rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+ pcie20x1 {
+ pcie20x12_pins: pcie20x12-pins {
+ rockchip,pins =
+ /* PCIE20_1_2_CLKREQn_M1_L */
+ <3 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>,
+ /* PCIE_PERST_L */
+ <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>,
+ /* PCIE20_1_2_WAKEn_M1_L */
+ <3 RK_PD0 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
--
2.44.0
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Anand Moon <linux.amoon@gmail.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: Anand Moon <linux.amoon@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/3] arm64: dts: rockchip: Add missing pinctrl for PCIe20x1 node
Date: Fri, 26 Jul 2024 16:30:46 +0530 [thread overview]
Message-ID: <20240726110050.3664-3-linux.amoon@gmail.com> (raw)
In-Reply-To: <20240726110050.3664-1-linux.amoon@gmail.com>
Add missing pinctrl settings for PCIe 2.0 x1 clock request and wake
signals. Each component of PCIe communication have the following control
signals: PERST, WAKE, CLKREQ, and REFCLK. These signals work to generate
high-speed signals and communicate with other PCIe devices.
Used by root complex to endpoint depending on the power state.
PERST is referred to as a fundamental reset. PERST should be held low
until all the power rails in the system and the reference clock are stable.
A transition from low to high in this signal usually indicates the
beginning of link initialization.
WAKE signal is an active-low signal that is used to return the PCIe
interface to an active state when in a low-power state.
CLKREQ signal is also an active-low signal and is used to request the
reference clock.
Rename node from 'pcie2' to 'pcie20x1' to align with schematic
nomenclature.
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
v4: rebase on master, used RK_FUNC_GPIO GPIO function instead of PIN
number.
V3: New patch.
---
arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index eeae14842b71..813a28b8916e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -326,7 +326,7 @@ &pcie2x1l0 {
&pcie2x1l2 {
pinctrl-names = "default";
- pinctrl-0 = <&pcie2_2_rst>;
+ pinctrl-0 = <&pcie20x12_pins>;
reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>;
vpcie3v3-supply = <&vcc3v3_pcie2x1l2>;
status = "okay";
@@ -363,9 +363,15 @@ hp_detect: hp-detect {
};
};
- pcie2 {
- pcie2_2_rst: pcie2-2-rst {
- rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+ pcie20x1 {
+ pcie20x12_pins: pcie20x12-pins {
+ rockchip,pins =
+ /* PCIE20_1_2_CLKREQn_M1_L */
+ <3 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>,
+ /* PCIE_PERST_L */
+ <3 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>,
+ /* PCIE20_1_2_WAKEn_M1_L */
+ <3 RK_PD0 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
--
2.44.0
next prev parent reply other threads:[~2024-07-26 17:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 11:00 [PATCH v4 1/3] arm64: dts: rockchip: Add missing pinctrl for PCIe30x4 node Anand Moon
2024-07-26 11:00 ` Anand Moon
2024-07-26 11:00 ` [PATCH v4 2/3] arm64: dts: rockchip: Add missing pinctrl for PCIe30x1 node Anand Moon
2024-07-26 11:00 ` Anand Moon
2024-07-26 11:00 ` Anand Moon [this message]
2024-07-26 11:00 ` [PATCH v4 3/3] arm64: dts: rockchip: Add missing pinctrl for PCIe20x1 node Anand Moon
2024-07-26 20:07 ` [PATCH v4 1/3] arm64: dts: rockchip: Add missing pinctrl for PCIe30x4 node Jonas Karlman
2024-07-26 20:07 ` Jonas Karlman
2024-07-28 6:04 ` Anand Moon
2024-07-28 6:04 ` Anand Moon
2024-07-27 15:52 ` Dragan Simic
2024-07-27 15:52 ` Dragan Simic
2024-07-28 6:04 ` Anand Moon
2024-07-28 6:04 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726110050.3664-3-linux.amoon@gmail.com \
--to=linux.amoon@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.