Re: [PATCH v8 RESEND 1/3] dt-bindings: dmaengine: Add dma multiplexer for CV18XX/SG200X series SoC

From: Rob Herring <robh@kernel.org>
To: Inochi Amaoto <inochiama@outlook.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Albert Ou <aou@eecs.berkeley.edu>,
	devicetree@vger.kernel.org, Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	dmaengine@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
	Liu Gui <kenneth.liu@sophgo.com>,
	linux-riscv@lists.infradead.org,
	Chen Wang <unicorn_wang@outlook.com>,
	Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v8 RESEND 1/3] dt-bindings: dmaengine: Add dma multiplexer for CV18XX/SG200X series SoC
Date: Mon, 29 Jul 2024 10:02:01 -0500	[thread overview]
Message-ID: <20240729150201.GA334758-robh@kernel.org> (raw)
In-Reply-To: <IA1PR20MB4953343445D88F046E1D28EFBBB72@IA1PR20MB4953.namprd20.prod.outlook.com>

On Mon, Jul 29, 2024 at 08:28:09PM +0800, Inochi Amaoto wrote:
> On Mon, Jul 29, 2024 at 11:30:20AM GMT, Krzysztof Kozlowski wrote:
> > On 29/07/2024 09:00, Inochi Amaoto wrote:
> > >> yamllint warnings/errors:
> > >>
> > >> dtschema/dtc warnings/errors:
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/sophgo,cv1800-dmamux.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/sophgo,cv1800-dmamux.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/dma-router.yaml#
> > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/dma/sophgo,cv1800-dmamux.example.dtb: dma-router@154: dma-masters: 4294967295 is not of type 'array'
> > >> 	from schema $id: http://devicetree.org/schemas/dma/dma-router.yaml#
> > >>
> > > 
> > > Hi Rob,
> > > 
> > > Could you share some suggestions? I can not reproduce this error with
> > > latest dtschema. I think this is more like a misreporting.
> > 
> > You would need dtschema from the master branch, so newer than 2024.05.
> > 
> > Best regards,
> > Krzysztof
> > 
> 
> Is it a must for the type array to have more than 1 element?
> I have tested the value "<&dmac 0>" and "<&dmac>, <&dmac>".
> Both pass the check (These value are just for test, not the
> real hardware).
> 
> Setting dma-masters to type "phandle" also has no change. 
> It do not accept the value "<&dmac>", Is there any suggestion
> for this? Thanks in advance.

The issue is 'dma-masters' is also defined as a uint32 in the Spear 
binding. Types aren't local to a binding, so when there's a 4 byte 
value, is that a phandle or plain uint32? I'm working on a fix in 
dtschema for this. It should be committed shortly.

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Rob