* [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace()
@ 2024-07-18 5:01 Nicolin Chen
2024-07-18 5:13 ` Tian, Kevin
2024-07-29 18:16 ` Jason Gunthorpe
0 siblings, 2 replies; 5+ messages in thread
From: Nicolin Chen @ 2024-07-18 5:01 UTC (permalink / raw)
To: jgg, kevin.tian; +Cc: yi.l.liu, iommu, linux-kernel
The rewind routine should remove the reserved iovas added to the new hwpt.
Fixes: 89db31635c87 ("iommufd: Derive iommufd_hwpt_paging from iommufd_hw_pagetable")
Cc: stable@vger.kernel.org
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
---
drivers/iommu/iommufd/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/iommufd/device.c b/drivers/iommu/iommufd/device.c
index 9a7ec5997c61c..3214a4c17c6b3 100644
--- a/drivers/iommu/iommufd/device.c
+++ b/drivers/iommu/iommufd/device.c
@@ -526,7 +526,7 @@ iommufd_device_do_replace(struct iommufd_device *idev,
err_unresv:
if (hwpt_is_paging(hwpt))
iommufd_group_remove_reserved_iova(igroup,
- to_hwpt_paging(old_hwpt));
+ to_hwpt_paging(hwpt));
err_unlock:
mutex_unlock(&idev->igroup->lock);
return ERR_PTR(rc);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* RE: [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace()
2024-07-18 5:01 [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace() Nicolin Chen
@ 2024-07-18 5:13 ` Tian, Kevin
2024-07-28 23:36 ` Nicolin Chen
2024-07-29 18:16 ` Jason Gunthorpe
1 sibling, 1 reply; 5+ messages in thread
From: Tian, Kevin @ 2024-07-18 5:13 UTC (permalink / raw)
To: Nicolin Chen, jgg@nvidia.com
Cc: Liu, Yi L, iommu@lists.linux.dev, linux-kernel@vger.kernel.org
> From: Nicolin Chen <nicolinc@nvidia.com>
> Sent: Thursday, July 18, 2024 1:02 PM
>
> The rewind routine should remove the reserved iovas added to the new
> hwpt.
>
> Fixes: 89db31635c87 ("iommufd: Derive iommufd_hwpt_paging from
> iommufd_hw_pagetable")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace()
2024-07-18 5:13 ` Tian, Kevin
@ 2024-07-28 23:36 ` Nicolin Chen
2024-07-29 12:35 ` Jason Gunthorpe
0 siblings, 1 reply; 5+ messages in thread
From: Nicolin Chen @ 2024-07-28 23:36 UTC (permalink / raw)
To: jgg@nvidia.com
Cc: Liu, Yi L, Tian, Kevin, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
On Thu, Jul 18, 2024 at 05:13:38AM +0000, Tian, Kevin wrote:
> > From: Nicolin Chen <nicolinc@nvidia.com>
> > Sent: Thursday, July 18, 2024 1:02 PM
> >
> > The rewind routine should remove the reserved iovas added to the new
> > hwpt.
> >
> > Fixes: 89db31635c87 ("iommufd: Derive iommufd_hwpt_paging from
> > iommufd_hw_pagetable")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
>
> Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Jason, it seems that we haven't merged this patch, right?
It still applies against v6.11-rc1. So no need of respin.
Thanks
Nicolin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace()
2024-07-28 23:36 ` Nicolin Chen
@ 2024-07-29 12:35 ` Jason Gunthorpe
0 siblings, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2024-07-29 12:35 UTC (permalink / raw)
To: Nicolin Chen
Cc: Liu, Yi L, Tian, Kevin, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
On Sun, Jul 28, 2024 at 04:36:00PM -0700, Nicolin Chen wrote:
> On Thu, Jul 18, 2024 at 05:13:38AM +0000, Tian, Kevin wrote:
>
> > > From: Nicolin Chen <nicolinc@nvidia.com>
> > > Sent: Thursday, July 18, 2024 1:02 PM
> > >
> > > The rewind routine should remove the reserved iovas added to the new
> > > hwpt.
> > >
> > > Fixes: 89db31635c87 ("iommufd: Derive iommufd_hwpt_paging from
> > > iommufd_hw_pagetable")
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> >
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
>
> Jason, it seems that we haven't merged this patch, right?
>
> It still applies against v6.11-rc1. So no need of respin.
Yes, I will pick it for the rc1 cycle
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace()
2024-07-18 5:01 [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace() Nicolin Chen
2024-07-18 5:13 ` Tian, Kevin
@ 2024-07-29 18:16 ` Jason Gunthorpe
1 sibling, 0 replies; 5+ messages in thread
From: Jason Gunthorpe @ 2024-07-29 18:16 UTC (permalink / raw)
To: Nicolin Chen; +Cc: kevin.tian, yi.l.liu, iommu, linux-kernel
On Wed, Jul 17, 2024 at 10:01:30PM -0700, Nicolin Chen wrote:
> The rewind routine should remove the reserved iovas added to the new hwpt.
>
> Fixes: 89db31635c87 ("iommufd: Derive iommufd_hwpt_paging from iommufd_hw_pagetable")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> drivers/iommu/iommufd/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc thanks
Jason
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-29 18:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18 5:01 [PATCH] iommufd/device: Fix hwpt at err_unresv in iommufd_device_do_replace() Nicolin Chen
2024-07-18 5:13 ` Tian, Kevin
2024-07-28 23:36 ` Nicolin Chen
2024-07-29 12:35 ` Jason Gunthorpe
2024-07-29 18:16 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.