From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, Breno Leitao <leitao@debian.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
leit@meta.com, Chris Mason <clm@fb.com>,
"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging
Date: Tue, 30 Jul 2024 07:10:33 -0700 [thread overview]
Message-ID: <20240730071033.24c9127c@kernel.org> (raw)
In-Reply-To: <c61c4921-0ddc-42cf-881d-4302ff599053@redhat.com>
On Tue, 30 Jul 2024 13:15:57 +0200 Paolo Abeni wrote:
> > If thats the case why does it exist at all?
+1
> > I was under impression that entire reason for CONFIG_DEBUG_NET was
> > to enable more checks for fuzzers and the like, i.e. NOT for production
> > kernels.
>
> I feel like I already had this discussion and I forgot the outcome, if
> so I'm sorry. To me the "but is safe to select." part in the knob
> description means this could be enabled in production, and AFAICS the
> CONFIG_DEBUG_NET-enabled code so far respects that assumption.
I believe the previous discussion was page pool specific and there
wasn't as much of a conclusion as an acquiescence (read: we had more
important things on our minds than that argument ;)).
Should we set a bar for how much perf impact is okay?
FTR I suspect there will be no measurable perf impact here.
next prev parent reply other threads:[~2024-07-30 14:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 10:47 [PATCH net-next] net: skbuff: Skip early return in skb_unref when debugging Breno Leitao
2024-07-30 9:38 ` Paolo Abeni
2024-07-30 10:24 ` Breno Leitao
2024-07-30 10:50 ` Florian Westphal
2024-07-30 11:15 ` Paolo Abeni
2024-07-30 14:10 ` Jakub Kicinski [this message]
2024-07-30 14:21 ` Eric Dumazet
2024-07-30 14:37 ` Paolo Abeni
2024-07-30 14:48 ` Jakub Kicinski
2024-07-31 11:24 ` Breno Leitao
2024-07-31 11:53 ` Jason Xing
2024-08-01 9:07 ` Paolo Abeni
2024-08-01 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730071033.24c9127c@kernel.org \
--to=kuba@kernel.org \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.