From: Simon Horman <horms@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org,
Rafal Romanowski <rafal.romanowski@intel.com>,
hkelam@marvell.com, Marcin Szycik <marcin.szycik@linux.intel.com>,
anthony.l.nguyen@intel.com,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
intel-wired-lan@lists.osuosl.org, przemyslaw.kitszel@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v5 12/13] iavf: refactor add/del FDIR filters
Date: Tue, 30 Jul 2024 11:28:49 +0100 [thread overview]
Message-ID: <20240730102849.GY97837@kernel.org> (raw)
In-Reply-To: <20240725220810.12748-13-ahmed.zaki@intel.com>
On Thu, Jul 25, 2024 at 04:08:08PM -0600, Ahmed Zaki wrote:
> In preparation for a second type of FDIR filters that can be added by
> tc-u32, move the add/del of the FDIR logic to be entirely contained in
> iavf_fdir.c.
>
> The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr()
> to be more agnostic to the filter ID parameter (for now @loc, which is
> relevant only to current FDIR filters added via ethtool).
>
> The FDIR filter deletion is moved from iavf_del_fdir_ethtool() in
> ethtool.c to iavf_fdir_del_fltr(). While at it, fix a minor bug where
> the "fltr" is accessed out of the fdir_fltr_lock spinlock protection.
>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
hkelam@marvell.com,
Sridhar Samudrala <sridhar.samudrala@intel.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Rafal Romanowski <rafal.romanowski@intel.com>
Subject: Re: [PATCH iwl-next v5 12/13] iavf: refactor add/del FDIR filters
Date: Tue, 30 Jul 2024 11:28:49 +0100 [thread overview]
Message-ID: <20240730102849.GY97837@kernel.org> (raw)
In-Reply-To: <20240725220810.12748-13-ahmed.zaki@intel.com>
On Thu, Jul 25, 2024 at 04:08:08PM -0600, Ahmed Zaki wrote:
> In preparation for a second type of FDIR filters that can be added by
> tc-u32, move the add/del of the FDIR logic to be entirely contained in
> iavf_fdir.c.
>
> The iavf_find_fdir_fltr_by_loc() is renamed to iavf_find_fdir_fltr()
> to be more agnostic to the filter ID parameter (for now @loc, which is
> relevant only to current FDIR filters added via ethtool).
>
> The FDIR filter deletion is moved from iavf_del_fdir_ethtool() in
> ethtool.c to iavf_fdir_del_fltr(). While at it, fix a minor bug where
> the "fltr" is accessed out of the fdir_fltr_lock spinlock protection.
>
> Reviewed-by: Sridhar Samudrala <sridhar.samudrala@intel.com>
> Reviewed-by: Marcin Szycik <marcin.szycik@linux.intel.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
> Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-07-30 10:28 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 22:07 [Intel-wired-lan] [PATCH iwl-next v5 00/13] ice: iavf: add support for TC U32 filters on VFs Ahmed Zaki
2024-07-25 22:07 ` Ahmed Zaki
2024-07-25 22:07 ` [Intel-wired-lan] [PATCH iwl-next v5 01/13] ice: add parser create and destroy skeleton Ahmed Zaki
2024-07-25 22:07 ` Ahmed Zaki
2024-07-25 22:07 ` [Intel-wired-lan] [PATCH iwl-next v5 02/13] ice: parse and init various DDP parser sections Ahmed Zaki
2024-07-25 22:07 ` Ahmed Zaki
2024-07-30 10:22 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:22 ` Simon Horman
2024-07-25 22:07 ` [Intel-wired-lan] [PATCH iwl-next v5 03/13] ice: add debugging functions for the " Ahmed Zaki
2024-07-25 22:07 ` Ahmed Zaki
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 04/13] ice: add parser internal helper functions Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 05/13] ice: add parser execution main loop Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:22 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:22 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 06/13] ice: support turning on/off the parser's double vlan mode Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:23 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:23 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 07/13] ice: add UDP tunnels support to the parser Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 08/13] ice: add API for parser profile initialization Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:23 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:23 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 09/13] virtchnl: support raw packet in protocol header Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 10/13] ice: add method to disable FDIR SWAP option Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:23 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:23 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 11/13] ice: enable FDIR filters from raw binary patterns for VFs Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:28 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:28 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 12/13] iavf: refactor add/del FDIR filters Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:28 ` Simon Horman [this message]
2024-07-30 10:28 ` Simon Horman
2024-07-25 22:08 ` [Intel-wired-lan] [PATCH iwl-next v5 13/13] iavf: add support for offloading tc U32 cls filters Ahmed Zaki
2024-07-25 22:08 ` Ahmed Zaki
2024-07-30 10:29 ` [Intel-wired-lan] " Simon Horman
2024-07-30 10:29 ` Simon Horman
2024-07-25 22:26 ` [Intel-wired-lan] [PATCH iwl-next v5 00/13] ice: iavf: add support for TC U32 filters on VFs Jakub Kicinski
2024-07-25 22:26 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730102849.GY97837@kernel.org \
--to=horms@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=hkelam@marvell.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=marcin.szycik@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=rafal.romanowski@intel.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.