From: Jakub Kicinski <kuba@kernel.org>
To: "Song, Yoong Siang" <yoong.siang.song@intel.com>
Cc: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
"Alexei Starovoitov" <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
Shinas Rasheed <srasheed@marvell.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Brett Creeley <brett.creeley@amd.com>,
"Blanco Alcaine, Hector" <hector.blanco.alcaine@intel.com>,
"Hay, Joshua A" <joshua.a.hay@intel.com>,
"Neftin, Sasha" <sasha.neftin@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH iwl-next,v1 0/3] Add Default Rx Queue Setting for igc driver
Date: Wed, 31 Jul 2024 07:43:51 -0700 [thread overview]
Message-ID: <20240731074351.13676228@kernel.org> (raw)
In-Reply-To: <PH0PR11MB5830E21A96A862B194D4A4A5D8B12@PH0PR11MB5830.namprd11.prod.outlook.com>
On Wed, 31 Jul 2024 07:40:11 +0000 Song, Yoong Siang wrote:
> Regarding your suggestion of implementing a "wildcard rule,"
> are you suggesting the use of an ethtool command similar to the following?
>
> ethtool -U <iface name> flow-type ether action <default queue>
>
> I have a concern that users might be not aware that this nfc rule is having lowest priority,
> as the default queue would only take effect when no other filtering rules match.
I believe that ethtool n-tuple rules are expected to be executed in
order. User can use the 'loc' argument to place the rule at the end
of the table.
> Do you see this as a potential issue? If not, I am willing to proceed with
> exploring the ethtool options you've mentioned.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: "Song, Yoong Siang" <yoong.siang.song@intel.com>
Cc: "Neftin, Sasha" <sasha.neftin@intel.com>,
Brett Creeley <brett.creeley@amd.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Blanco Alcaine, Hector" <hector.blanco.alcaine@intel.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jonathan Corbet <corbet@lwn.net>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
John Fastabend <john.fastabend@gmail.com>,
Shinas Rasheed <srasheed@marvell.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
Paolo Abeni <pabeni@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Hay, Joshua A" <joshua.a.hay@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v1 0/3] Add Default Rx Queue Setting for igc driver
Date: Wed, 31 Jul 2024 07:43:51 -0700 [thread overview]
Message-ID: <20240731074351.13676228@kernel.org> (raw)
In-Reply-To: <PH0PR11MB5830E21A96A862B194D4A4A5D8B12@PH0PR11MB5830.namprd11.prod.outlook.com>
On Wed, 31 Jul 2024 07:40:11 +0000 Song, Yoong Siang wrote:
> Regarding your suggestion of implementing a "wildcard rule,"
> are you suggesting the use of an ethtool command similar to the following?
>
> ethtool -U <iface name> flow-type ether action <default queue>
>
> I have a concern that users might be not aware that this nfc rule is having lowest priority,
> as the default queue would only take effect when no other filtering rules match.
I believe that ethtool n-tuple rules are expected to be executed in
order. User can use the 'loc' argument to place the rule at the end
of the table.
> Do you see this as a potential issue? If not, I am willing to proceed with
> exploring the ethtool options you've mentioned.
next prev parent reply other threads:[~2024-07-31 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 1:22 [PATCH iwl-next,v1 0/3] Add Default Rx Queue Setting for igc driver Song Yoong Siang
2024-07-30 1:22 ` [Intel-wired-lan] [PATCH iwl-next, v1 " Song Yoong Siang
2024-07-30 14:55 ` [PATCH iwl-next,v1 " Jakub Kicinski
2024-07-30 14:55 ` [Intel-wired-lan] [PATCH iwl-next, v1 " Jakub Kicinski
2024-07-31 7:40 ` [PATCH iwl-next,v1 " Song, Yoong Siang
2024-07-31 7:40 ` [Intel-wired-lan] [PATCH iwl-next, v1 " Song, Yoong Siang
2024-07-31 14:43 ` Jakub Kicinski [this message]
2024-07-31 14:43 ` Jakub Kicinski
2024-07-31 16:41 ` Jacob Keller
2024-07-31 23:52 ` Jakub Kicinski
2024-07-31 23:52 ` Jakub Kicinski
2024-08-01 7:09 ` Song, Yoong Siang
2024-08-01 7:09 ` Song, Yoong Siang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731074351.13676228@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brett.creeley@amd.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hector.blanco.alcaine@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=joshua.a.hay@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
--cc=srasheed@marvell.com \
--cc=vinicius.gomes@intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.