All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] VMCI: fix reference to ioctl-number.rst
@ 2024-07-31 11:13 Alyssa Ross
  2024-07-31 11:32 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Alyssa Ross @ 2024-07-31 11:13 UTC (permalink / raw)
  To: Bryan Tan, Vishnu Dasa
  Cc: Broadcom internal kernel review list, Greg Kroah-Hartman,
	linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

Fixes: 20259849bb1a ("VMCI: Some header and config files.")
Signed-off-by: Alyssa Ross <hi@alyssa.is>
---
You may notice that ioctl-number.rst does not actually mention code 7 — 
I've had a separate patch accepted to do that:

https://lore.kernel.org/all/20240725171120.12226-2-hi@alyssa.is/

 include/linux/vmw_vmci_defs.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/include/linux/vmw_vmci_defs.h b/include/linux/vmw_vmci_defs.h
index 6fb663b36f72..244c5ff412e1 100644
--- a/include/linux/vmw_vmci_defs.h
+++ b/include/linux/vmw_vmci_defs.h
@@ -431,11 +431,11 @@ enum {
 	((((_p)[0] & 0xFF) << 24) | (((_p)[1] & 0xFF) << 16) | ((_p)[2]))
 
 /*
- * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.h, and
- * we start at sequence 9f.  This gives us the same values that our shipping
- * products use, starting at 1951, provided we leave out the direction and
- * structure size.  Note that VMMon occupies the block following us, starting
- * at 2001.
+ * The VMCI IOCTLs.  We use identity code 7, as noted in ioctl-number.rst,
+ * and we start at sequence 9f.  This gives us the same values that our
+ * shipping products use, starting at 1951, provided we leave out the
+ * direction and structure size.  Note that VMMon occupies the block
+ * following us, starting at 2001.
  */
 #define IOCTL_VMCI_VERSION			_IO(7, 0x9f)	/* 1951 */
 #define IOCTL_VMCI_INIT_CONTEXT			_IO(7, 0xa0)

base-commit: e4fc196f5ba36eb7b9758cf2c73df49a44199895
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] VMCI: fix reference to ioctl-number.rst
  2024-07-31 11:13 [PATCH] VMCI: fix reference to ioctl-number.rst Alyssa Ross
@ 2024-07-31 11:32 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2024-07-31 11:32 UTC (permalink / raw)
  To: Alyssa Ross
  Cc: Bryan Tan, Vishnu Dasa, Broadcom internal kernel review list,
	linux-kernel

On Wed, Jul 31, 2024 at 01:13:03PM +0200, Alyssa Ross wrote:
> Fixes: 20259849bb1a ("VMCI: Some header and config files.")
> Signed-off-by: Alyssa Ross <hi@alyssa.is>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-31 11:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-31 11:13 [PATCH] VMCI: fix reference to ioctl-number.rst Alyssa Ross
2024-07-31 11:32 ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.