From: Nishanth Menon <nm@ti.com>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Vibhore Vardhan <vibhore@ti.com>,
Kevin Hilman <khilman@baylibre.com>,
"Dhruva Gole" <d-gole@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Georgi Vlaev <g-vlaev@ti.com>
Subject: Re: [PATCH v8 2/3] firmware: ti_sci: Add support for querying the firmware caps
Date: Tue, 6 Aug 2024 10:42:01 -0500 [thread overview]
Message-ID: <20240806154201.tfqq27csd6zvtbrw@browsing> (raw)
In-Reply-To: <20240801195422.2296347-3-msp@baylibre.com>
On 21:54-20240801, Markus Schneider-Pargmann wrote:
[...]
> static int ti_sci_cmd_core_reboot(const struct ti_sci_handle *handle)
> {
> struct ti_sci_info *info;
> @@ -3113,6 +3172,12 @@ static void ti_sci_setup_ops(struct ti_sci_info *info)
>
> pmops->lpm_wake_reason = ti_sci_msg_cmd_lpm_wake_reason;
>
> + if (info->fw_caps & MSG_FLAG_CAPS_LPM_DM_MANAGED) {
> + pr_debug("detected DM managed LPM in fw_caps\n");
> + ops->pm_ops.set_device_constraint = ti_sci_cmd_set_device_constraint;
> + ops->pm_ops.set_latency_constraint = ti_sci_cmd_set_latency_constraint;
pmops-> ?
Also lpm_wake_reason makes sense only if the flag is set, so
this should probably be the first patch in your series?
> + }
Side-note: please drop bouncing emails from your patch CC list.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2024-08-06 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 19:54 [PATCH v8 0/3] firmware: ti_sci: Introduce system suspend support Markus Schneider-Pargmann
2024-08-01 19:54 ` [PATCH v8 1/3] firmware: ti_sci: Introduce Power Management Ops Markus Schneider-Pargmann
2024-08-03 6:31 ` kernel test robot
2024-08-06 15:39 ` Nishanth Menon
2024-08-06 18:47 ` Markus Schneider-Pargmann
2024-08-01 19:54 ` [PATCH v8 2/3] firmware: ti_sci: Add support for querying the firmware caps Markus Schneider-Pargmann
2024-08-06 15:42 ` Nishanth Menon [this message]
2024-08-01 19:54 ` [PATCH v8 3/3] firmware: ti_sci: Add system suspend and resume call Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806154201.tfqq27csd6zvtbrw@browsing \
--to=nm@ti.com \
--cc=d-gole@ti.com \
--cc=g-vlaev@ti.com \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=ssantosh@kernel.org \
--cc=vibhore@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.