[Buildroot] [PATCH] package/python-pygments: support host package

[Buildroot] [PATCH] package/python-pygments: support host package

[Takumi Takahashi]

---
 package/python-pygments/python-pygments.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
index f151f0061b..e6d5ba25f5 100644
--- a/package/python-pygments/python-pygments.mk
+++ b/package/python-pygments/python-pygments.mk
@@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
 PYTHON_PYGMENTS_SETUP_TYPE = setuptools
 
 $(eval $(python-package))
+$(eval $(host-python-package))
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-pygments: support host package

[Thomas Petazzoni via buildroot]

Hello Takumi,

On Sun,  1 Oct 2023 04:06:10 +0900
Takumi Takahashi <takumiiinn@gmail.com> wrote:

> ---
>  package/python-pygments/python-pygments.mk | 1 +
>  1 file changed, 1 insertion(+)

Thanks for your patch.

However, could you clarify on why you need a host variant of this
package, and how it gets used?

Also, we require all patches to have a Signed-off-by line from their
author. Without this, we cannot apply patches that are contributed.
Could you send a new version that (1) has an explanation of why you
need a host package and what uses it and (2) has your Signed-off-by
line?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/python-pygments: support host package

[Takumi Takahashi]

Hello Thomas.

Thank you for your review.

> However, could you clarify on why you need a host variant of this
> package, and how it gets used?
>
> Also, we require all patches to have a Signed-off-by line from their
> author. Without this, we cannot apply patches that are contributed.
> Could you send a new version that (1) has an explanation of why you
> need a host package and what uses it and (2) has your Signed-off-by
> line?

(1)

The reason this patch is needed is because gtk-doc requires pygments.
The final goal is to submit a patch for lightdm, but since gtk-doc is
required to build lightdm, pygments will also be required.

Should I include the above reason in the commit log?
I would appreciate any additional advice.

(2)

Sorry, I forgot to include `Signed-off-by`.
Next version will include `Signed-off-by`.

Thank you.

Takumi

2023年10月1日(日) 4:41 Thomas Petazzoni <thomas.petazzoni@bootlin.com>:
>
> Hello Takumi,
>
> On Sun,  1 Oct 2023 04:06:10 +0900
> Takumi Takahashi <takumiiinn@gmail.com> wrote:
>
> > ---
> >  package/python-pygments/python-pygments.mk | 1 +
> >  1 file changed, 1 insertion(+)
>
> Thanks for your patch.
>
> However, could you clarify on why you need a host variant of this
> package, and how it gets used?
>
> Also, we require all patches to have a Signed-off-by line from their
> author. Without this, we cannot apply patches that are contributed.
> Could you send a new version that (1) has an explanation of why you
> need a host package and what uses it and (2) has your Signed-off-by
> line?
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2] package/python-pygments: support host package

[Takumi Takahashi]

The reason this patch is needed is because gtk-doc requires pygments.
The final goal is to submit a patch for lightdm, but since gtk-doc is
required to build lightdm, pygments will also be required.

Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
---
 package/python-pygments/python-pygments.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-pygments/python-pygments.mk b/package/python-pygments/python-pygments.mk
index f151f0061b..e6d5ba25f5 100644
--- a/package/python-pygments/python-pygments.mk
+++ b/package/python-pygments/python-pygments.mk
@@ -14,3 +14,4 @@ PYTHON_PYGMENTS_CPE_ID_PRODUCT = pygments
 PYTHON_PYGMENTS_SETUP_TYPE = setuptools
 
 $(eval $(python-package))
+$(eval $(host-python-package))
-- 
2.42.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2] package/python-pygments: support host package

[Thomas Petazzoni via buildroot]

Hello Takumi,

On Sun,  1 Oct 2023 12:42:46 +0900
Takumi Takahashi <takumiiinn@gmail.com> wrote:

> The reason this patch is needed is because gtk-doc requires pygments.
> The final goal is to submit a patch for lightdm, but since gtk-doc is
> required to build lightdm, pygments will also be required.
> 
> Signed-off-by: Takumi Takahashi <takumiiinn@gmail.com>
> ---
>  package/python-pygments/python-pygments.mk | 1 +
>  1 file changed, 1 insertion(+)

Thanks for your patch, and sorry for the long delay with which we are
getting back to you. However, this patch, as well as the patching
adding itstool need to go together, in a patch series that also adds
the lightdm package. Indeed we want to see the big picture, and not
have those two "orphan" host packages without the actual package using
them.

That being said, I think the approach should rather to make sure that
lightdm doesn't require gtk-doc. In the context of Buildroot, we are
not interested in building the documentation. Are you sure that lightdm
absolutely requires gtk-doc? I see it's using the GTK_DOC_CHECK m4
macro, so it supports --disable-gtk-doc, and that should do the trick.
If not, it should be fixed to do the trick :)

If you're still interested into this, could you send the full series of
patches including lightdm?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot