All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] package/libjcat: fix linking, add missing intl library
@ 2024-08-07 12:48 Waldemar Brodkorb
  2024-08-07 19:41 ` Thomas Petazzoni via buildroot
  0 siblings, 1 reply; 2+ messages in thread
From: Waldemar Brodkorb @ 2024-08-07 12:48 UTC (permalink / raw)
  To: buildroot

For musl/uClibc-ng toolchains we need to explicitely link
libintl. The problem exist since the addition of the package
in commit e52605c092d8eaa926da8720ae498a38eddb5205.

Fixes:
 - http://autobuild.buildroot.net/results/58c/58c7ecbcfab96ebbc7a20291d4712cf64094b9f7/
 - http://autobuild.buildroot.net/results/5d7/5d7c5dea0213f5a24489c397c5703c0601b2f12d/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
v1->v2:
 - use $(TARGET_NLS_LIBS) / $(TARGET_NLS_DEPENDENCIES) for more
   correctness (suggested by Thomas P.)

I only tested a minimal musl toolchain this time, but I think it
should work for uClibc-ng, too. 
---
 package/libjcat/libjcat.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/libjcat/libjcat.mk b/package/libjcat/libjcat.mk
index e13e5dbfb7..c365c1914b 100644
--- a/package/libjcat/libjcat.mk
+++ b/package/libjcat/libjcat.mk
@@ -10,7 +10,9 @@ LIBJCAT_SOURCE = libjcat-$(LIBJCAT_VERSION).tar.xz
 LIBJCAT_LICENSE = LGPL-2.1+
 LIBJCAT_LICENSE_FILES = LICENSE
 LIBJCAT_INSTALL_STAGING = YES
-LIBJCAT_DEPENDENCIES = host-pkgconf json-glib libglib2
+LIBJCAT_DEPENDENCIES = host-pkgconf json-glib libglib2 $(TARGET_NLS_DEPENDENCIES)
+
+LIBJCAT_LDFLAGS = $(TARGET_NLS_LIBS)
 
 LIBJCAT_CONF_OPTS = \
 	-Dgtkdoc=false \
-- 
2.39.2

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-07 19:41 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 12:48 [Buildroot] [PATCH v2] package/libjcat: fix linking, add missing intl library Waldemar Brodkorb
2024-08-07 19:41 ` Thomas Petazzoni via buildroot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.