* [PATCH] net/bnxt: fix issue reading sff8436 sfp eeproms
@ 2024-08-09 10:21 Peter Morrow
0 siblings, 0 replies; only message in thread
From: Peter Morrow @ 2024-08-09 10:21 UTC (permalink / raw)
To: dev; +Cc: Peter Morrow, Peter Morrow, Ajit Khaparde, Somnath Kotur
From: Peter Morrow <peter@graphiant.com>
If a SFP which supports SFF-8436 is present then
currently the DDM information present in the eeprom
is not read. Furthermore bnxt_get_module_eeprom()
will return -EINVAL for these eeproms since the
length of these eeproms is 512 bytes but we are
only ever selecting 2 pages (256 bytes) to read.
Signed-off-by: Peter Morrow <pdmorrow@gmail.com>
---
drivers/net/bnxt/bnxt_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e63febe782..8c4608a1b9 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4130,7 +4130,6 @@ static int bnxt_get_module_eeprom(struct rte_eth_dev *dev,
switch (module_info[0]) {
case SFF_MODULE_ID_SFP:
- module_info[SFF_DIAG_SUPPORT_OFFSET] = 0;
if (module_info[SFF_DIAG_SUPPORT_OFFSET]) {
pg_addr[2] = I2C_DEV_ADDR_A2;
pg_addr[3] = I2C_DEV_ADDR_A2;
--
2.39.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-08-09 11:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-09 10:21 [PATCH] net/bnxt: fix issue reading sff8436 sfp eeproms Peter Morrow
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.