From: cel@kernel.org
To: <stable@vger.kernel.org>
Cc: <linux-nfs@vger.kernel.org>,
pvorel@suse.cz, sherry.yang@oracle.com, calum.mackay@oracle.com,
kernel-team@fb.com, ltp@lists.linux.it,
Josef Bacik <josef@toxicpanda.com>,
Jeff Layton <jlayton@kernel.org>
Subject: [PATCH 6.1.y 11/18] sunrpc: pass in the sv_stats struct through svc_create_pooled
Date: Sat, 10 Aug 2024 16:00:02 -0400 [thread overview]
Message-ID: <20240810200009.9882-12-cel@kernel.org> (raw)
In-Reply-To: <20240810200009.9882-1-cel@kernel.org>
From: Josef Bacik <josef@toxicpanda.com>
[ Upstream commit f094323867668d50124886ad884b665de7319537 ]
Since only one service actually reports the rpc stats there's not much
of a reason to have a pointer to it in the svc_program struct. Adjust
the svc_create_pooled function to take the sv_stats as an argument and
pass the struct through there as desired instead of getting it from the
svc_program->pg_stats.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
[ cel: adjusted to apply to v6.1.y ]
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfssvc.c | 3 ++-
include/linux/sunrpc/svc.h | 4 +++-
net/sunrpc/svc.c | 12 +++++++-----
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index e1a07cfdab23..34d5906b844b 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -657,7 +657,8 @@ int nfsd_create_serv(struct net *net)
if (nfsd_max_blksize == 0)
nfsd_max_blksize = nfsd_get_default_max_blksize();
nfsd_reset_versions(nn);
- serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize, nfsd);
+ serv = svc_create_pooled(&nfsd_program, &nfsd_svcstats,
+ nfsd_max_blksize, nfsd);
if (serv == NULL)
return -ENOMEM;
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 88de45491376..3290b805f749 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -493,7 +493,9 @@ void svc_rqst_replace_page(struct svc_rqst *rqstp,
struct page *page);
void svc_rqst_free(struct svc_rqst *);
void svc_exit_thread(struct svc_rqst *);
-struct svc_serv * svc_create_pooled(struct svc_program *, unsigned int,
+struct svc_serv * svc_create_pooled(struct svc_program *prog,
+ struct svc_stat *stats,
+ unsigned int bufsize,
int (*threadfn)(void *data));
int svc_set_num_threads(struct svc_serv *, struct svc_pool *, int);
int svc_pool_stats_open(struct svc_serv *serv, struct file *file);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 35c0651cc002..9ae85347ab39 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -453,8 +453,8 @@ __svc_init_bc(struct svc_serv *serv)
* Create an RPC service
*/
static struct svc_serv *
-__svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
- int (*threadfn)(void *data))
+__svc_create(struct svc_program *prog, struct svc_stat *stats,
+ unsigned int bufsize, int npools, int (*threadfn)(void *data))
{
struct svc_serv *serv;
unsigned int vers;
@@ -466,7 +466,7 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
serv->sv_name = prog->pg_name;
serv->sv_program = prog;
kref_init(&serv->sv_refcnt);
- serv->sv_stats = prog->pg_stats;
+ serv->sv_stats = stats;
if (bufsize > RPCSVC_MAXPAYLOAD)
bufsize = RPCSVC_MAXPAYLOAD;
serv->sv_max_payload = bufsize? bufsize : 4096;
@@ -528,26 +528,28 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
struct svc_serv *svc_create(struct svc_program *prog, unsigned int bufsize,
int (*threadfn)(void *data))
{
- return __svc_create(prog, bufsize, 1, threadfn);
+ return __svc_create(prog, NULL, bufsize, 1, threadfn);
}
EXPORT_SYMBOL_GPL(svc_create);
/**
* svc_create_pooled - Create an RPC service with pooled threads
* @prog: the RPC program the new service will handle
+ * @stats: the stats struct if desired
* @bufsize: maximum message size for @prog
* @threadfn: a function to service RPC requests for @prog
*
* Returns an instantiated struct svc_serv object or NULL.
*/
struct svc_serv *svc_create_pooled(struct svc_program *prog,
+ struct svc_stat *stats,
unsigned int bufsize,
int (*threadfn)(void *data))
{
struct svc_serv *serv;
unsigned int npools = svc_pool_map_get();
- serv = __svc_create(prog, bufsize, npools, threadfn);
+ serv = __svc_create(prog, stats, bufsize, npools, threadfn);
if (!serv)
goto out_err;
return serv;
--
2.45.1
WARNING: multiple messages have this Message-ID (diff)
From: cel@kernel.org
To: <stable@vger.kernel.org>
Cc: linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
sherry.yang@oracle.com, Josef Bacik <josef@toxicpanda.com>,
calum.mackay@oracle.com, kernel-team@fb.com, ltp@lists.linux.it
Subject: [LTP] [PATCH 6.1.y 11/18] sunrpc: pass in the sv_stats struct through svc_create_pooled
Date: Sat, 10 Aug 2024 16:00:02 -0400 [thread overview]
Message-ID: <20240810200009.9882-12-cel@kernel.org> (raw)
In-Reply-To: <20240810200009.9882-1-cel@kernel.org>
From: Josef Bacik <josef@toxicpanda.com>
[ Upstream commit f094323867668d50124886ad884b665de7319537 ]
Since only one service actually reports the rpc stats there's not much
of a reason to have a pointer to it in the svc_program struct. Adjust
the svc_create_pooled function to take the sv_stats as an argument and
pass the struct through there as desired instead of getting it from the
svc_program->pg_stats.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
[ cel: adjusted to apply to v6.1.y ]
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfssvc.c | 3 ++-
include/linux/sunrpc/svc.h | 4 +++-
net/sunrpc/svc.c | 12 +++++++-----
3 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index e1a07cfdab23..34d5906b844b 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -657,7 +657,8 @@ int nfsd_create_serv(struct net *net)
if (nfsd_max_blksize == 0)
nfsd_max_blksize = nfsd_get_default_max_blksize();
nfsd_reset_versions(nn);
- serv = svc_create_pooled(&nfsd_program, nfsd_max_blksize, nfsd);
+ serv = svc_create_pooled(&nfsd_program, &nfsd_svcstats,
+ nfsd_max_blksize, nfsd);
if (serv == NULL)
return -ENOMEM;
diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
index 88de45491376..3290b805f749 100644
--- a/include/linux/sunrpc/svc.h
+++ b/include/linux/sunrpc/svc.h
@@ -493,7 +493,9 @@ void svc_rqst_replace_page(struct svc_rqst *rqstp,
struct page *page);
void svc_rqst_free(struct svc_rqst *);
void svc_exit_thread(struct svc_rqst *);
-struct svc_serv * svc_create_pooled(struct svc_program *, unsigned int,
+struct svc_serv * svc_create_pooled(struct svc_program *prog,
+ struct svc_stat *stats,
+ unsigned int bufsize,
int (*threadfn)(void *data));
int svc_set_num_threads(struct svc_serv *, struct svc_pool *, int);
int svc_pool_stats_open(struct svc_serv *serv, struct file *file);
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index 35c0651cc002..9ae85347ab39 100644
--- a/net/sunrpc/svc.c
+++ b/net/sunrpc/svc.c
@@ -453,8 +453,8 @@ __svc_init_bc(struct svc_serv *serv)
* Create an RPC service
*/
static struct svc_serv *
-__svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
- int (*threadfn)(void *data))
+__svc_create(struct svc_program *prog, struct svc_stat *stats,
+ unsigned int bufsize, int npools, int (*threadfn)(void *data))
{
struct svc_serv *serv;
unsigned int vers;
@@ -466,7 +466,7 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
serv->sv_name = prog->pg_name;
serv->sv_program = prog;
kref_init(&serv->sv_refcnt);
- serv->sv_stats = prog->pg_stats;
+ serv->sv_stats = stats;
if (bufsize > RPCSVC_MAXPAYLOAD)
bufsize = RPCSVC_MAXPAYLOAD;
serv->sv_max_payload = bufsize? bufsize : 4096;
@@ -528,26 +528,28 @@ __svc_create(struct svc_program *prog, unsigned int bufsize, int npools,
struct svc_serv *svc_create(struct svc_program *prog, unsigned int bufsize,
int (*threadfn)(void *data))
{
- return __svc_create(prog, bufsize, 1, threadfn);
+ return __svc_create(prog, NULL, bufsize, 1, threadfn);
}
EXPORT_SYMBOL_GPL(svc_create);
/**
* svc_create_pooled - Create an RPC service with pooled threads
* @prog: the RPC program the new service will handle
+ * @stats: the stats struct if desired
* @bufsize: maximum message size for @prog
* @threadfn: a function to service RPC requests for @prog
*
* Returns an instantiated struct svc_serv object or NULL.
*/
struct svc_serv *svc_create_pooled(struct svc_program *prog,
+ struct svc_stat *stats,
unsigned int bufsize,
int (*threadfn)(void *data))
{
struct svc_serv *serv;
unsigned int npools = svc_pool_map_get();
- serv = __svc_create(prog, bufsize, npools, threadfn);
+ serv = __svc_create(prog, stats, bufsize, npools, threadfn);
if (!serv)
goto out_err;
return serv;
--
2.45.1
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2024-08-10 20:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 19:59 [PATCH 6.1.y 00/18] Backport "make svc_stat per-net instead of global" cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-10 19:59 ` [PATCH 6.1.y 01/18] nfsd: move reply cache initialization into nfsd startup cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: move reply cache initialization into nfsd startup" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 02/18] nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_net cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: move init of percpu reply_cache_stats counters back to nfsd_init_net" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 03/18] NFSD: Refactor nfsd_reply_cache_free_locked() cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "NFSD: Refactor nfsd_reply_cache_free_locked()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 04/18] NFSD: Rename nfsd_reply_cache_alloc() cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "NFSD: Rename nfsd_reply_cache_alloc()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 05/18] NFSD: Replace nfsd_prune_bucket() cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "NFSD: Replace nfsd_prune_bucket()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 06/18] NFSD: Refactor the duplicate reply cache shrinker cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "NFSD: Refactor the duplicate reply cache shrinker" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 07/18] NFSD: Rewrite synopsis of nfsd_percpu_counters_init() cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:40 ` [LTP] Patch "NFSD: Rewrite synopsis of nfsd_percpu_counters_init()" has been added to the 6.1-stable tree gregkh
2024-08-10 19:59 ` [PATCH 6.1.y 08/18] NFSD: Fix frame size warning in svc_export_parse() cel
2024-08-10 19:59 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "NFSD: Fix frame size warning in svc_export_parse()" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 09/18] sunrpc: don't change ->sv_stats if it doesn't exist cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:40 ` [LTP] Patch "sunrpc: don't change ->sv_stats if it doesn't exist" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 10/18] nfsd: stop setting ->pg_stats for unused stats cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:40 ` [LTP] Patch "nfsd: stop setting ->pg_stats for unused stats" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` cel [this message]
2024-08-10 20:00 ` [LTP] [PATCH 6.1.y 11/18] sunrpc: pass in the sv_stats struct through svc_create_pooled cel
2024-08-15 8:40 ` [LTP] Patch "sunrpc: pass in the sv_stats struct through svc_create_pooled" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 12/18] sunrpc: remove ->pg_stats from svc_program cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:40 ` [LTP] Patch "sunrpc: remove ->pg_stats from svc_program" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 13/18] sunrpc: use the struct net as the svc proc private cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:40 ` [LTP] Patch "sunrpc: use the struct net as the svc proc private" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 14/18] nfsd: rename NFSD_NET_* to NFSD_STATS_* cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: rename NFSD_NET_* to NFSD_STATS_*" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 15/18] nfsd: expose /proc/net/sunrpc/nfsd in net namespaces cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: expose /proc/net/sunrpc/nfsd in net namespaces" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 16/18] nfsd: make all of the nfsd stats per-network namespace cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: make all of the nfsd stats per-network namespace" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 17/18] nfsd: remove nfsd_stats, make th_cnt a global counter cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: remove nfsd_stats, make th_cnt a global counter" has been added to the 6.1-stable tree gregkh
2024-08-10 20:00 ` [PATCH 6.1.y 18/18] nfsd: make svc_stat per-network namespace instead of global cel
2024-08-10 20:00 ` [LTP] " cel
2024-08-15 8:39 ` [LTP] Patch "nfsd: make svc_stat per-network namespace instead of global" has been added to the 6.1-stable tree gregkh
2024-08-12 11:34 ` [PATCH 6.1.y 00/18] Backport "make svc_stat per-net instead of global" Sasha Levin
2024-08-12 11:34 ` [LTP] " Sasha Levin
2024-08-12 13:52 ` Chuck Lever III
2024-08-12 13:52 ` [LTP] " Chuck Lever III via ltp
2024-08-12 14:02 ` Greg KH
2024-08-12 14:02 ` [LTP] " Greg KH
2024-08-15 8:27 ` Greg KH
2024-08-15 8:27 ` [LTP] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240810200009.9882-12-cel@kernel.org \
--to=cel@kernel.org \
--cc=calum.mackay@oracle.com \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=sherry.yang@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.