* [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system
@ 2024-08-11 0:00 Max Filippov
2024-08-11 0:00 ` [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture" Max Filippov
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Max Filippov @ 2024-08-11 0:00 UTC (permalink / raw)
To: buildroot; +Cc: Woodrow Douglass, Thomas Petazzoni
Hello,
this series reverts xtensa-specific patch applied to the chicken package
and instead passes TARGET_CFLAGS to the chicken build system.
Max Filippov (2):
Revert "package/chicken: move literals into text section for xtensa
architecture"
package/chicken: pass TARGET_CFLAGS to the build system
.../0001-xtensa-text-section-literals.patch | 30 -------------------
package/chicken/chicken.mk | 15 ++--------
2 files changed, 3 insertions(+), 42 deletions(-)
delete mode 100644 package/chicken/0001-xtensa-text-section-literals.patch
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture"
2024-08-11 0:00 [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
@ 2024-08-11 0:00 ` Max Filippov
2024-08-12 12:39 ` Woody Douglass via buildroot
2024-08-11 0:00 ` [Buildroot] [PATCH 2/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
2024-08-12 20:23 ` [Buildroot] [PATCH 0/2] " Thomas Petazzoni via buildroot
2 siblings, 1 reply; 7+ messages in thread
From: Max Filippov @ 2024-08-11 0:00 UTC (permalink / raw)
To: buildroot; +Cc: Woodrow Douglass, Thomas Petazzoni
This reverts commit 86e51fd5fe2810bbf833b48c4914dcd2de01bdbe.
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
.../0001-xtensa-text-section-literals.patch | 30 -------------------
package/chicken/chicken.mk | 14 ++-------
2 files changed, 2 insertions(+), 42 deletions(-)
delete mode 100644 package/chicken/0001-xtensa-text-section-literals.patch
diff --git a/package/chicken/0001-xtensa-text-section-literals.patch b/package/chicken/0001-xtensa-text-section-literals.patch
deleted file mode 100644
index b93aaf9e218d..000000000000
--- a/package/chicken/0001-xtensa-text-section-literals.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From e8d177f4d4e1c6bc41787ea1621e323ff4ad493e Mon Sep 17 00:00:00 2001
-From: Woodrow Douglass <wdouglass@carnegierobotics.com>
-Date: Mon, 22 Jul 2024 08:50:37 -0400
-Subject: [PATCH] Move literals into text section for xtensa architecture
-
-Upstream: https://bugs.call-cc.org/ticket/1840
-Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
----
- Makefile.linux | 5 +++++
- 1 file changed, 5 insertions(+)
-
-diff --git a/Makefile.linux b/Makefile.linux
-index b628cda4..e97c2b94 100644
---- a/Makefile.linux
-+++ b/Makefile.linux
-@@ -52,6 +52,11 @@ USES_SONAME = yes
-
- # architectures
-
-+ifeq ($(ARCH),xtensa)
-+C_COMPILER_OPTIONS += -mtext-section-literals
-+LINKER_OPTIONS += -mtext-section-literals
-+endif
-+
- ifeq ($(ARCH),x32)
- C_COMPILER_OPTIONS += -mx32
- LINKER_OPTIONS += -mx32
---
-2.39.2
-
diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
index 0520280134ab..2667f7823d8a 100644
--- a/package/chicken/chicken.mk
+++ b/package/chicken/chicken.mk
@@ -11,19 +11,9 @@ CHICKEN_LICENSE_FILES = LICENSE
CHICKEN_CPE_ID_VENDOR = call-cc
CHICKEN_INSTALL_STAGING = YES
-# Chicken only uses the "arch" variable for some special-case compile
-# arguments If it's empty, it tries to detect the arch host Filter out
-# values that have an effect, or pass "unused" here
-ifeq ($(NORMALIZED_ARCH),x86_64)
-CHICKEN_ARCH = x86-64
-else ifeq ($(NORMALIZED_ARCH),xtensa)
-CHICKEN_ARCH = xtensa
-else
-CHICKEN_ARCH = unused
-endif
-
+# If ARCH is not set, it attempts to autodiscover. But it is anyway not used.
CHICKEN_MAKE_OPTS = \
- ARCH="$(CHICKEN_ARCH)" \
+ ARCH=unused \
C_COMPILER="$(TARGET_CC)" \
CXX_COMPILER="$(TARGET_CXX)" \
PREFIX=/usr \
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/chicken: pass TARGET_CFLAGS to the build system
2024-08-11 0:00 [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
2024-08-11 0:00 ` [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture" Max Filippov
@ 2024-08-11 0:00 ` Max Filippov
2024-08-12 20:23 ` [Buildroot] [PATCH 0/2] " Thomas Petazzoni via buildroot
2 siblings, 0 replies; 7+ messages in thread
From: Max Filippov @ 2024-08-11 0:00 UTC (permalink / raw)
To: buildroot; +Cc: Woodrow Douglass, Thomas Petazzoni
chicken build system expects non-standard environment variables with
compiler names and compiler options. Pass buildroot TARGET_CFLAGS in
chicken C_COMPILER_OPTIMIZATION_OPTIONS.
Fixes: http://autobuild.buildroot.net/results/ce36170d67c4702f34bee025d8a46e5269c4573e/
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
package/chicken/chicken.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
index 2667f7823d8a..0000fc635ed5 100644
--- a/package/chicken/chicken.mk
+++ b/package/chicken/chicken.mk
@@ -16,6 +16,7 @@ CHICKEN_MAKE_OPTS = \
ARCH=unused \
C_COMPILER="$(TARGET_CC)" \
CXX_COMPILER="$(TARGET_CXX)" \
+ C_COMPILER_OPTIMIZATION_OPTIONS="$(TARGET_CFLAGS)" \
PREFIX=/usr \
PLATFORM=linux \
LIBRARIAN="$(TARGET_AR)"
--
2.39.2
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture"
2024-08-11 0:00 ` [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture" Max Filippov
@ 2024-08-12 12:39 ` Woody Douglass via buildroot
2024-08-12 18:29 ` Max Filippov
0 siblings, 1 reply; 7+ messages in thread
From: Woody Douglass via buildroot @ 2024-08-12 12:39 UTC (permalink / raw)
To: Max Filippov, buildroot@buildroot.org; +Cc: Thomas Petazzoni
On 8/10/24 20:00, Max Filippov wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
>
>
> This reverts commit 86e51fd5fe2810bbf833b48c4914dcd2de01bdbe.
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> .../0001-xtensa-text-section-literals.patch | 30 -------------------
> package/chicken/chicken.mk | 14 ++-------
> 2 files changed, 2 insertions(+), 42 deletions(-)
> delete mode 100644 package/chicken/0001-xtensa-text-section-literals.patch
>
> diff --git a/package/chicken/0001-xtensa-text-section-literals.patch b/package/chicken/0001-xtensa-text-section-literals.patch
> deleted file mode 100644
> index b93aaf9e218d..000000000000
> --- a/package/chicken/0001-xtensa-text-section-literals.patch
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -From e8d177f4d4e1c6bc41787ea1621e323ff4ad493e Mon Sep 17 00:00:00 2001
> -From: Woodrow Douglass <wdouglass@carnegierobotics.com>
> -Date: Mon, 22 Jul 2024 08:50:37 -0400
> -Subject: [PATCH] Move literals into text section for xtensa architecture
> -
> -Upstream: https://bugs.call-cc.org/ticket/1840
> -Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> ----
> - Makefile.linux | 5 +++++
> - 1 file changed, 5 insertions(+)
> -
> -diff --git a/Makefile.linux b/Makefile.linux
> -index b628cda4..e97c2b94 100644
> ---- a/Makefile.linux
> -+++ b/Makefile.linux
> -@@ -52,6 +52,11 @@ USES_SONAME = yes
> -
> - # architectures
> -
> -+ifeq ($(ARCH),xtensa)
> -+C_COMPILER_OPTIONS += -mtext-section-literals
> -+LINKER_OPTIONS += -mtext-section-literals
> -+endif
> -+
> - ifeq ($(ARCH),x32)
> - C_COMPILER_OPTIONS += -mx32
> - LINKER_OPTIONS += -mx32
> ---
> -2.39.2
> -
> diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
> index 0520280134ab..2667f7823d8a 100644
> --- a/package/chicken/chicken.mk
> +++ b/package/chicken/chicken.mk
> @@ -11,19 +11,9 @@ CHICKEN_LICENSE_FILES = LICENSE
> CHICKEN_CPE_ID_VENDOR = call-cc
> CHICKEN_INSTALL_STAGING = YES
>
> -# Chicken only uses the "arch" variable for some special-case compile
> -# arguments If it's empty, it tries to detect the arch host Filter out
> -# values that have an effect, or pass "unused" here
> -ifeq ($(NORMALIZED_ARCH),x86_64)
> -CHICKEN_ARCH = x86-64
changing the spelling to `x86-64` here is a good idea i think, because
chicken does add some flags. Other then that, i agree that the
C_COMPILER_OPTIMIZATION_OPTIONS approach is better here
> -else ifeq ($(NORMALIZED_ARCH),xtensa)
> -CHICKEN_ARCH = xtensa
> -else
> -CHICKEN_ARCH = unused
> -endif
> -
> +# If ARCH is not set, it attempts to autodiscover. But it is anyway not used.
> CHICKEN_MAKE_OPTS = \
> - ARCH="$(CHICKEN_ARCH)" \
> + ARCH=unused \
> C_COMPILER="$(TARGET_CC)" \
> CXX_COMPILER="$(TARGET_CXX)" \
> PREFIX=/usr \
> --
> 2.39.2
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture"
2024-08-12 12:39 ` Woody Douglass via buildroot
@ 2024-08-12 18:29 ` Max Filippov
2024-08-12 18:53 ` Woody Douglass via buildroot
0 siblings, 1 reply; 7+ messages in thread
From: Max Filippov @ 2024-08-12 18:29 UTC (permalink / raw)
To: Woody Douglass; +Cc: Thomas Petazzoni, buildroot@buildroot.org
On Mon, Aug 12, 2024 at 5:39 AM Woody Douglass
<wdouglass@carnegierobotics.com> wrote:
> On 8/10/24 20:00, Max Filippov wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
> >
> >
> > This reverts commit 86e51fd5fe2810bbf833b48c4914dcd2de01bdbe.
> > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> > ---
> > .../0001-xtensa-text-section-literals.patch | 30 -------------------
> > package/chicken/chicken.mk | 14 ++-------
> > 2 files changed, 2 insertions(+), 42 deletions(-)
> > delete mode 100644 package/chicken/0001-xtensa-text-section-literals.patch
> >
> > diff --git a/package/chicken/0001-xtensa-text-section-literals.patch b/package/chicken/0001-xtensa-text-section-literals.patch
> > deleted file mode 100644
> > index b93aaf9e218d..000000000000
> > --- a/package/chicken/0001-xtensa-text-section-literals.patch
> > +++ /dev/null
> > @@ -1,30 +0,0 @@
> > -From e8d177f4d4e1c6bc41787ea1621e323ff4ad493e Mon Sep 17 00:00:00 2001
> > -From: Woodrow Douglass <wdouglass@carnegierobotics.com>
> > -Date: Mon, 22 Jul 2024 08:50:37 -0400
> > -Subject: [PATCH] Move literals into text section for xtensa architecture
> > -
> > -Upstream: https://bugs.call-cc.org/ticket/1840
> > -Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> > ----
> > - Makefile.linux | 5 +++++
> > - 1 file changed, 5 insertions(+)
> > -
> > -diff --git a/Makefile.linux b/Makefile.linux
> > -index b628cda4..e97c2b94 100644
> > ---- a/Makefile.linux
> > -+++ b/Makefile.linux
> > -@@ -52,6 +52,11 @@ USES_SONAME = yes
> > -
> > - # architectures
> > -
> > -+ifeq ($(ARCH),xtensa)
> > -+C_COMPILER_OPTIONS += -mtext-section-literals
> > -+LINKER_OPTIONS += -mtext-section-literals
> > -+endif
> > -+
> > - ifeq ($(ARCH),x32)
> > - C_COMPILER_OPTIONS += -mx32
> > - LINKER_OPTIONS += -mx32
> > ---
> > -2.39.2
> > -
> > diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
> > index 0520280134ab..2667f7823d8a 100644
> > --- a/package/chicken/chicken.mk
> > +++ b/package/chicken/chicken.mk
> > @@ -11,19 +11,9 @@ CHICKEN_LICENSE_FILES = LICENSE
> > CHICKEN_CPE_ID_VENDOR = call-cc
> > CHICKEN_INSTALL_STAGING = YES
> >
> > -# Chicken only uses the "arch" variable for some special-case compile
> > -# arguments If it's empty, it tries to detect the arch host Filter out
> > -# values that have an effect, or pass "unused" here
> > -ifeq ($(NORMALIZED_ARCH),x86_64)
> > -CHICKEN_ARCH = x86-64
>
> changing the spelling to `x86-64` here is a good idea i think, because
> chicken does add some flags. Other then that, i agree that the
> C_COMPILER_OPTIMIZATION_OPTIONS approach is better here
I believe that it should be done in a separate change as it has
nothing to do with the topic of 'move literals into text section for
xtensa architecture'.
--
Thanks.
-- Max
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture"
2024-08-12 18:29 ` Max Filippov
@ 2024-08-12 18:53 ` Woody Douglass via buildroot
0 siblings, 0 replies; 7+ messages in thread
From: Woody Douglass via buildroot @ 2024-08-12 18:53 UTC (permalink / raw)
To: Max Filippov; +Cc: Thomas Petazzoni, buildroot@buildroot.org
On 8/12/24 14:29, Max Filippov wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
>
>
> On Mon, Aug 12, 2024 at 5:39 AM Woody Douglass
> <wdouglass@carnegierobotics.com> wrote:
>> On 8/10/24 20:00, Max Filippov wrote:
>>> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.
>>>
>>>
>>> This reverts commit 86e51fd5fe2810bbf833b48c4914dcd2de01bdbe.
>>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>>> ---
>>> .../0001-xtensa-text-section-literals.patch | 30 -------------------
>>> package/chicken/chicken.mk | 14 ++-------
>>> 2 files changed, 2 insertions(+), 42 deletions(-)
>>> delete mode 100644 package/chicken/0001-xtensa-text-section-literals.patch
>>>
>>> diff --git a/package/chicken/0001-xtensa-text-section-literals.patch b/package/chicken/0001-xtensa-text-section-literals.patch
>>> deleted file mode 100644
>>> index b93aaf9e218d..000000000000
>>> --- a/package/chicken/0001-xtensa-text-section-literals.patch
>>> +++ /dev/null
>>> @@ -1,30 +0,0 @@
>>> -From e8d177f4d4e1c6bc41787ea1621e323ff4ad493e Mon Sep 17 00:00:00 2001
>>> -From: Woodrow Douglass <wdouglass@carnegierobotics.com>
>>> -Date: Mon, 22 Jul 2024 08:50:37 -0400
>>> -Subject: [PATCH] Move literals into text section for xtensa architecture
>>> -
>>> -Upstream: https://bugs.call-cc.org/ticket/1840
>>> -Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
>>> ----
>>> - Makefile.linux | 5 +++++
>>> - 1 file changed, 5 insertions(+)
>>> -
>>> -diff --git a/Makefile.linux b/Makefile.linux
>>> -index b628cda4..e97c2b94 100644
>>> ---- a/Makefile.linux
>>> -+++ b/Makefile.linux
>>> -@@ -52,6 +52,11 @@ USES_SONAME = yes
>>> -
>>> - # architectures
>>> -
>>> -+ifeq ($(ARCH),xtensa)
>>> -+C_COMPILER_OPTIONS += -mtext-section-literals
>>> -+LINKER_OPTIONS += -mtext-section-literals
>>> -+endif
>>> -+
>>> - ifeq ($(ARCH),x32)
>>> - C_COMPILER_OPTIONS += -mx32
>>> - LINKER_OPTIONS += -mx32
>>> ---
>>> -2.39.2
>>> -
>>> diff --git a/package/chicken/chicken.mk b/package/chicken/chicken.mk
>>> index 0520280134ab..2667f7823d8a 100644
>>> --- a/package/chicken/chicken.mk
>>> +++ b/package/chicken/chicken.mk
>>> @@ -11,19 +11,9 @@ CHICKEN_LICENSE_FILES = LICENSE
>>> CHICKEN_CPE_ID_VENDOR = call-cc
>>> CHICKEN_INSTALL_STAGING = YES
>>>
>>> -# Chicken only uses the "arch" variable for some special-case compile
>>> -# arguments If it's empty, it tries to detect the arch host Filter out
>>> -# values that have an effect, or pass "unused" here
>>> -ifeq ($(NORMALIZED_ARCH),x86_64)
>>> -CHICKEN_ARCH = x86-64
>> changing the spelling to `x86-64` here is a good idea i think, because
>> chicken does add some flags. Other then that, i agree that the
>> C_COMPILER_OPTIMIZATION_OPTIONS approach is better here
> I believe that it should be done in a separate change as it has
> nothing to do with the topic of 'move literals into text section for
> xtensa architecture'.
>
> --
> Thanks.
> -- Max
Sorry, this email was sent by mistake -- the `git send-email` workflow
is very new for me.
-Woody Douglass
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system
2024-08-11 0:00 [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
2024-08-11 0:00 ` [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture" Max Filippov
2024-08-11 0:00 ` [Buildroot] [PATCH 2/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
@ 2024-08-12 20:23 ` Thomas Petazzoni via buildroot
2 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni via buildroot @ 2024-08-12 20:23 UTC (permalink / raw)
To: Max Filippov; +Cc: Woodrow Douglass, buildroot
On Sat, 10 Aug 2024 17:00:27 -0700
Max Filippov <jcmvbkbc@gmail.com> wrote:
> Max Filippov (2):
> Revert "package/chicken: move literals into text section for xtensa
> architecture"
> package/chicken: pass TARGET_CFLAGS to the build system
Thanks, both applied to master!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-08-12 20:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-11 0:00 [Buildroot] [PATCH 0/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
2024-08-11 0:00 ` [Buildroot] [PATCH 1/2] Revert "package/chicken: move literals into text section for xtensa architecture" Max Filippov
2024-08-12 12:39 ` Woody Douglass via buildroot
2024-08-12 18:29 ` Max Filippov
2024-08-12 18:53 ` Woody Douglass via buildroot
2024-08-11 0:00 ` [Buildroot] [PATCH 2/2] package/chicken: pass TARGET_CFLAGS to the build system Max Filippov
2024-08-12 20:23 ` [Buildroot] [PATCH 0/2] " Thomas Petazzoni via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.