Re: [PATCH v8 1/4] rpmb: add Replay Protected Memory Block (RPMB) subsystem

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Aug 13, 2024 at 12:04:03PM +0000, Winkler, Tomas wrote:
> > 
> > On Tue, Aug 13, 2024 at 01:26:18PM +0200, Jens Wiklander wrote:
> > > On Tue, Aug 13, 2024 at 11:29 AM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Mon, Aug 12, 2024 at 03:31:24PM +0200, Jens Wiklander wrote:
> > > > > --- /dev/null
> > > > > +++ b/drivers/misc/rpmb-core.c
> > > > > @@ -0,0 +1,233 @@
> > > > > +// SPDX-License-Identifier: GPL-2.0
> > > >
> > > > Fine, but:
> > > >
> > > > > --- /dev/null
> > > > > +++ b/include/linux/rpmb.h
> > > > > @@ -0,0 +1,136 @@
> > > > > +/* SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0 */
> > > >
> > > > Really?
> > > >
> > > > Why?  I need lots of documentation and a lawyer sign off for why
> > > > this is a dual license for a file that is obviously only for
> > > > internal Linux kernel stuff.
> 
> This was legal approved.

This internal Linux kernel header file for an internal-only Linux kernel
api?  Wonderful, please get the Intel lawyer who agreed with that to
sign off on the commit next time around explaining why it needs to be
this way.

thanks,

greg k-h