From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Eric Dumazet <edumazet@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Ziwei Xiao <ziweixiao@google.com>,
Jeroen de Borst <jeroendb@google.com>,
Leon Romanovsky <leon@kernel.org>,
"open list:MELLANOX MLX4 core VPI driver"
<linux-rdma@vger.kernel.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
Paolo Abeni <pabeni@redhat.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Jiri Pirko <jiri@resnulli.us>,
Shailend Chand <shailend@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Willem de Bruijn <willemb@google.com>,
Yishai Hadas <yishaih@nvidia.com>,
Daniel Borkmann <daniel@iogearbox.net>,
netdev@vger.kernel.org, open list <linux-kernel@vger.kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Shay Drori <shayd@nvidia.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers
Date: Wed, 14 Aug 2024 17:20:46 -0700 [thread overview]
Message-ID: <20240814172046.7753a62c@kernel.org> (raw)
In-Reply-To: <ZrzxBAWwA7EuRB24@LQ3V64L9R2>
On Wed, 14 Aug 2024 19:01:40 +0100 Joe Damato wrote:
> If it is, then the only option is to have the drivers pass in their
> IRQ affinity masks, as Stanislav suggested, to avoid adding that
> call to the hot path.
>
> If not, then the IRQ from napi_struct can be used and the affinity
> mask can be generated on every napi poll. i40e/gve/iavf would need
> calls to netif_napi_set_irq to set the IRQ mapping, which seems to
> be straightforward.
It's a bit sad to have the generic solution blocked.
cpu_rmap_update() is exported. Maybe we can call it from our notifier?
rmap lives in struct net_device
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Joe Damato <jdamato@fastly.com>
Cc: Shay Drori <shayd@nvidia.com>,
netdev@vger.kernel.org, Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
Jeroen de Borst <jeroendb@google.com>,
Jiri Pirko <jiri@resnulli.us>, Leon Romanovsky <leon@kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:MELLANOX MLX4 core VPI driver"
<linux-rdma@vger.kernel.org>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Shailend Chand <shailend@google.com>,
Tariq Toukan <tariqt@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Willem de Bruijn <willemb@google.com>,
Yishai Hadas <yishaih@nvidia.com>,
Ziwei Xiao <ziweixiao@google.com>
Subject: Re: [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers
Date: Wed, 14 Aug 2024 17:20:46 -0700 [thread overview]
Message-ID: <20240814172046.7753a62c@kernel.org> (raw)
In-Reply-To: <ZrzxBAWwA7EuRB24@LQ3V64L9R2>
On Wed, 14 Aug 2024 19:01:40 +0100 Joe Damato wrote:
> If it is, then the only option is to have the drivers pass in their
> IRQ affinity masks, as Stanislav suggested, to avoid adding that
> call to the hot path.
>
> If not, then the IRQ from napi_struct can be used and the affinity
> mask can be generated on every napi poll. i40e/gve/iavf would need
> calls to netif_napi_set_irq to set the IRQ mapping, which seems to
> be straightforward.
It's a bit sad to have the generic solution blocked.
cpu_rmap_update() is exported. Maybe we can call it from our notifier?
rmap lives in struct net_device
next prev parent reply other threads:[~2024-08-15 0:20 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:56 [Intel-wired-lan] [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers Joe Damato
2024-08-12 14:56 ` Joe Damato
2024-08-12 14:56 ` [RFC net-next 1/6] netdevice: Add napi_affinity_no_change Joe Damato
2024-08-12 20:23 ` Stanislav Fomichev
2024-08-12 21:08 ` Joe Damato
2024-08-12 22:36 ` Stanislav Fomichev
2024-08-13 9:11 ` Joe Damato
2024-08-13 10:03 ` Joe Damato
2024-08-13 13:05 ` Simon Horman
2024-08-12 14:56 ` [RFC net-next 2/6] mlx5: Use napi_affinity_no_change Joe Damato
2024-08-12 14:56 ` [RFC net-next 3/6] gve: " Joe Damato
2024-08-13 18:55 ` Shailend Chand
2024-08-13 21:44 ` Joe Damato
2024-08-13 21:50 ` Shailend Chand
2024-08-12 14:56 ` [Intel-wired-lan] [RFC net-next 4/6] i40e: " Joe Damato
2024-08-12 14:56 ` Joe Damato
2024-08-12 14:56 ` [Intel-wired-lan] [RFC net-next 5/6] iavf: " Joe Damato
2024-08-12 14:56 ` Joe Damato
2024-08-12 14:56 ` [RFC net-next 6/6] mlx4: " Joe Damato
2024-08-14 0:17 ` [Intel-wired-lan] [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers Jakub Kicinski
2024-08-14 0:17 ` Jakub Kicinski
2024-08-14 7:14 ` [Intel-wired-lan] " Joe Damato
2024-08-14 7:14 ` Joe Damato
2024-08-14 12:12 ` [Intel-wired-lan] " Joe Damato
2024-08-14 12:12 ` Joe Damato
2024-08-14 15:09 ` [Intel-wired-lan] " Jakub Kicinski
2024-08-14 15:09 ` Jakub Kicinski
2024-08-14 15:19 ` [Intel-wired-lan] " Joe Damato
2024-08-14 15:19 ` Joe Damato
2024-08-14 16:03 ` [Intel-wired-lan] " Shay Drori
2024-08-14 16:03 ` Shay Drori
2024-08-14 18:01 ` [Intel-wired-lan] " Joe Damato
2024-08-14 18:01 ` Joe Damato
2024-08-15 0:20 ` Jakub Kicinski [this message]
2024-08-15 0:20 ` Jakub Kicinski
2024-08-15 10:22 ` [Intel-wired-lan] " Joe Damato
2024-08-15 10:22 ` Joe Damato
2024-08-20 6:40 ` [Intel-wired-lan] " Shay Drori
2024-08-20 6:40 ` Shay Drori
2024-08-20 8:33 ` [Intel-wired-lan] " Joe Damato
2024-08-20 8:33 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814172046.7753a62c@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=jeroendb@google.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedm@nvidia.com \
--cc=shailend@google.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=willemb@google.com \
--cc=yishaih@nvidia.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.