From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.g.garry@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
axboe@kernel.dk, martin.petersen@oracle.com
Subject: Re: [bug report] raid0 array mkfs.xfs hang
Date: Thu, 15 Aug 2024 08:21:12 +0200 [thread overview]
Message-ID: <20240815062112.GA14067@lst.de> (raw)
In-Reply-To: <b7f5db41-5995-4221-b2c4-4faa48fd1fd8@oracle.com>
On Thu, Aug 15, 2024 at 07:19:50AM +0100, John Garry wrote:
> static inline unsigned int bdev_write_zeroes_sectors(struct block_device
> *bdev)
> {
> struct request_queue *q = bdev_get_queue(bdev);
>
> if (q)
> return q->limits.max_write_zeroes_sectors;
>
> return 0;
> }
>
> According to the comment in bdev_get_queue(), it never is never NULL.
Probably because no one got around to remove it. There never was a
need to check the return value, but lots of places did check it.
I removed most of them as did a few others when touchign the code,
but apparently we never got to this one.
prev parent reply other threads:[~2024-08-15 6:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 17:12 [bug report] raid0 array mkfs.xfs hang John Garry
2024-08-12 14:50 ` John Garry
2024-08-14 14:00 ` John Garry
2024-08-14 14:46 ` Keith Busch
2024-08-14 14:52 ` Martin K. Petersen
2024-08-14 17:25 ` John Garry
2024-08-15 5:42 ` Christoph Hellwig
2024-08-15 5:52 ` Christoph Hellwig
2024-08-15 6:19 ` John Garry
2024-08-15 6:21 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815062112.GA14067@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=john.g.garry@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.