All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: John Garry <john.g.garry@oracle.com>
Cc: linux-xfs@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-block@vger.kernel.org, linux-raid@vger.kernel.org,
	hch@lst.de, axboe@kernel.dk, martin.petersen@oracle.com
Subject: Re: [bug report] raid0 array mkfs.xfs hang
Date: Wed, 14 Aug 2024 08:46:23 -0600	[thread overview]
Message-ID: <ZrzDP5c7bRyh7UnE@kbusch-mbp> (raw)
In-Reply-To: <ea82050f-f5a4-457d-8603-2f279237c8be@oracle.com>

On Wed, Aug 14, 2024 at 03:00:06PM +0100, John Garry wrote:
> 
> The value max write zeroes value is changing in raid0_map_submit_bio() ->
> mddev_check_write_zeroes()

Your change looks fine, though it sounds odd that md raid is changing
queue_limit values outside the limits_lock. The stacking limits should
have set the md device to 0 if one of the member drives doesn't support
write_zeroes, right?

  reply	other threads:[~2024-08-14 14:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-08 17:12 [bug report] raid0 array mkfs.xfs hang John Garry
2024-08-12 14:50 ` John Garry
2024-08-14 14:00   ` John Garry
2024-08-14 14:46     ` Keith Busch [this message]
2024-08-14 14:52       ` Martin K. Petersen
2024-08-14 17:25         ` John Garry
2024-08-15  5:42           ` Christoph Hellwig
2024-08-15  5:52     ` Christoph Hellwig
2024-08-15  6:19       ` John Garry
2024-08-15  6:21         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZrzDP5c7bRyh7UnE@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.