Re: [Buildroot] [PATCH 1/2] boot/uboot: avoid setting PMUFW_INIT_FILE when not used

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Mon, 19 Aug 2024 10:32:26 +0200
Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:

> I think there are two potential reasons for applying this patch:
> 
>  1. setting an empty string lets the build finish apparently
>     successfully, but the output binaries are not working
> 
>  2. allowing users to set CONFIG_PMUFW_INIT_FILE in their U-Boot config
>     and have Buildroot let it pass through
> 
> For point 1, as I wrote earlier today I think this won't happen, based
> on the U-Boot code.
> 
> For point 2, which is the motivation you present in this patch, I don't
> see a valid use case. Without a use case, I'd rather not add code to
> uboot.mk, no matter if it is only a few lines. With a use case, I'd be
> totally OK.

My initial point was that I found it odd that:

	$(call KCONFIG_SET_OPT,CONFIG_PMUFW_INIT_FILE,"$(UBOOT_ZYNQMP_PMUFW_PATH_FINAL)")

was done unconditionally. But in fact, it's done under the condition:

ifeq ($(BR2_TARGET_UBOOT_ZYNQMP),y)

so I think the code is indeed fine as it is.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot