From: Simon Horman <horms@kernel.org>
To: Krzysztof Galazka <krzysztof.galazka@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] selftests/net: Fix csum test for short packets
Date: Wed, 21 Aug 2024 18:43:33 +0100 [thread overview]
Message-ID: <20240821174333.GE2164@kernel.org> (raw)
In-Reply-To: <20240821142409.958668-1-krzysztof.galazka@intel.com>
On Wed, Aug 21, 2024 at 04:24:09PM +0200, Krzysztof Galazka wrote:
> For IPv4 and IPv6 packets shorter than minimum Ethernet
> frame payload, recvmsg returns lenght including padding.
> Use length from header for checksum verification to avoid
> csum test failing on correct packets.
>
> Fixes: 1d0dc857b5d8 (selftests: drv-net: add checksum tests)
nit: I think the correct format for the tag is
Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
...
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@kernel.org>
To: Krzysztof Galazka <krzysztof.galazka@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH iwl-net] selftests/net: Fix csum test for short packets
Date: Wed, 21 Aug 2024 18:43:33 +0100 [thread overview]
Message-ID: <20240821174333.GE2164@kernel.org> (raw)
In-Reply-To: <20240821142409.958668-1-krzysztof.galazka@intel.com>
On Wed, Aug 21, 2024 at 04:24:09PM +0200, Krzysztof Galazka wrote:
> For IPv4 and IPv6 packets shorter than minimum Ethernet
> frame payload, recvmsg returns lenght including padding.
> Use length from header for checksum verification to avoid
> csum test failing on correct packets.
>
> Fixes: 1d0dc857b5d8 (selftests: drv-net: add checksum tests)
nit: I think the correct format for the tag is
Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
...
next prev parent reply other threads:[~2024-08-21 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 14:24 [Intel-wired-lan] [PATCH iwl-net] selftests/net: Fix csum test for short packets Krzysztof Galazka
2024-08-21 14:24 ` Krzysztof Galazka
2024-08-21 14:32 ` [Intel-wired-lan] " Willem de Bruijn
2024-08-21 14:32 ` Willem de Bruijn
2024-08-27 17:54 ` [Intel-wired-lan] " Galazka, Krzysztof
2024-08-27 17:54 ` Galazka, Krzysztof
2024-08-21 17:43 ` Simon Horman [this message]
2024-08-21 17:43 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821174333.GE2164@kernel.org \
--to=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=krzysztof.galazka@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.