From: alison.schofield@intel.com
To: Vishal Verma <vishal.l.verma@intel.com>, nvdimm@lists.linux.dev
Cc: Jerry James <loganjerry@gmail.com>
Subject: [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora
Date: Wed, 21 Aug 2024 14:45:24 -0700 [thread overview]
Message-ID: <20240821214529.96966-1-alison.schofield@intel.com> (raw)
From: Jerry James <loganjerry@gmail.com>
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the
conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
than 9. The result is that ndctl builds for Fedora lack support for
libtraceevent and libtracefs. Correct the expression.
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/266/
Signed-off-by: Jerry James <loganjerry@gmail.com>
---
ndctl.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ndctl.spec.in b/ndctl.spec.in
index cb9cb6fe0b86..ea9fadc266d8 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-%{release}
Requires: DAX_LNAME%{?_isa} = %{version}-%{release}
Requires: CXL_LNAME%{?_isa} = %{version}-%{release}
BuildRequires: autoconf
-%if 0%{?rhel} < 9
+%if 0%{?rhel} && 0%{?rhel} < 9
BuildRequires: asciidoc
%define asciidoctor -Dasciidoctor=disabled
%define libtracefs -Dlibtracefs=disabled
--
2.37.3
next reply other threads:[~2024-08-21 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 21:45 alison.schofield [this message]
2024-08-21 21:50 ` [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora Verma, Vishal L
2024-08-21 21:58 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821214529.96966-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=loganjerry@gmail.com \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.