* [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora
@ 2024-08-21 21:45 alison.schofield
2024-08-21 21:50 ` Verma, Vishal L
2024-08-21 21:58 ` Dave Jiang
0 siblings, 2 replies; 3+ messages in thread
From: alison.schofield @ 2024-08-21 21:45 UTC (permalink / raw)
To: Vishal Verma, nvdimm; +Cc: Jerry James
From: Jerry James <loganjerry@gmail.com>
As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
the expression "0%{?rhel}" evaluates to zero on Fedora, so the
conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
than 9. The result is that ndctl builds for Fedora lack support for
libtraceevent and libtracefs. Correct the expression.
Reposted here from github pull request:
https://github.com/pmem/ndctl/pull/266/
Signed-off-by: Jerry James <loganjerry@gmail.com>
---
ndctl.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ndctl.spec.in b/ndctl.spec.in
index cb9cb6fe0b86..ea9fadc266d8 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-%{release}
Requires: DAX_LNAME%{?_isa} = %{version}-%{release}
Requires: CXL_LNAME%{?_isa} = %{version}-%{release}
BuildRequires: autoconf
-%if 0%{?rhel} < 9
+%if 0%{?rhel} && 0%{?rhel} < 9
BuildRequires: asciidoc
%define asciidoctor -Dasciidoctor=disabled
%define libtracefs -Dlibtracefs=disabled
--
2.37.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora
2024-08-21 21:45 [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora alison.schofield
@ 2024-08-21 21:50 ` Verma, Vishal L
2024-08-21 21:58 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Verma, Vishal L @ 2024-08-21 21:50 UTC (permalink / raw)
To: Schofield, Alison, nvdimm@lists.linux.dev; +Cc: loganjerry@gmail.com
On Wed, 2024-08-21 at 14:45 -0700, alison.schofield@intel.com wrote:
> From: Jerry James <loganjerry@gmail.com>
>
> As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
> the expression "0%{?rhel}" evaluates to zero on Fedora, so the
> conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
> than 9. The result is that ndctl builds for Fedora lack support for
> libtraceevent and libtracefs. Correct the expression.
>
> Reposted here from github pull request:
> https://github.com/pmem/ndctl/pull/266/
>
> Signed-off-by: Jerry James <loganjerry@gmail.com>
Looks good,
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
> ---
> ndctl.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ndctl.spec.in b/ndctl.spec.in
> index cb9cb6fe0b86..ea9fadc266d8 100644
> --- a/ndctl.spec.in
> +++ b/ndctl.spec.in
> @@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-
> %{release}
> Requires: DAX_LNAME%{?_isa} = %{version}-%{release}
> Requires: CXL_LNAME%{?_isa} = %{version}-%{release}
> BuildRequires: autoconf
> -%if 0%{?rhel} < 9
> +%if 0%{?rhel} && 0%{?rhel} < 9
> BuildRequires: asciidoc
> %define asciidoctor -Dasciidoctor=disabled
> %define libtracefs -Dlibtracefs=disabled
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora
2024-08-21 21:45 [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora alison.schofield
2024-08-21 21:50 ` Verma, Vishal L
@ 2024-08-21 21:58 ` Dave Jiang
1 sibling, 0 replies; 3+ messages in thread
From: Dave Jiang @ 2024-08-21 21:58 UTC (permalink / raw)
To: alison.schofield, Vishal Verma, nvdimm; +Cc: Jerry James
On 8/21/24 2:45 PM, alison.schofield@intel.com wrote:
> From: Jerry James <loganjerry@gmail.com>
>
> As noted in https://src.fedoraproject.org/rpms/ndctl/pull-request/2,
> the expression "0%{?rhel}" evaluates to zero on Fedora, so the
> conditional "%if 0%{?rhel} < 9" evaluates to true, since 0 is less
> than 9. The result is that ndctl builds for Fedora lack support for
> libtraceevent and libtracefs. Correct the expression.
>
> Reposted here from github pull request:
> https://github.com/pmem/ndctl/pull/266/
>
> Signed-off-by: Jerry James <loganjerry@gmail.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> ndctl.spec.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ndctl.spec.in b/ndctl.spec.in
> index cb9cb6fe0b86..ea9fadc266d8 100644
> --- a/ndctl.spec.in
> +++ b/ndctl.spec.in
> @@ -10,7 +10,7 @@ Requires: LNAME%{?_isa} = %{version}-%{release}
> Requires: DAX_LNAME%{?_isa} = %{version}-%{release}
> Requires: CXL_LNAME%{?_isa} = %{version}-%{release}
> BuildRequires: autoconf
> -%if 0%{?rhel} < 9
> +%if 0%{?rhel} && 0%{?rhel} < 9
> BuildRequires: asciidoc
> %define asciidoctor -Dasciidoctor=disabled
> %define libtracefs -Dlibtracefs=disabled
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-21 21:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-21 21:45 [ndctl PATCH] ndctl.spec.in: enable libtrace{event|fs} support for Fedora alison.schofield
2024-08-21 21:50 ` Verma, Vishal L
2024-08-21 21:58 ` Dave Jiang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.