All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next 4/8] nvmet: Make nvmet_debugfs static
@ 2024-08-19 12:00 Jinjie Ruan
  2024-08-22  6:57 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2024-08-19 12:00 UTC (permalink / raw)
  To: hch, sagi, kch, linux-nvme, linux-kernel; +Cc: ruanjinjie

The sparse tool complains as follows:

drivers/nvme/target/debugfs.c:16:15: warning:
	symbol 'nvmet_debugfs' was not declared. Should it be static?

This symbol is not used outside debugfs.c, so marks it static.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/nvme/target/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/target/debugfs.c b/drivers/nvme/target/debugfs.c
index cb2befc8619e..220c7391fc19 100644
--- a/drivers/nvme/target/debugfs.c
+++ b/drivers/nvme/target/debugfs.c
@@ -13,7 +13,7 @@
 #include "nvmet.h"
 #include "debugfs.h"
 
-struct dentry *nvmet_debugfs;
+static struct dentry *nvmet_debugfs;
 
 #define NVMET_DEBUGFS_ATTR(field) \
 	static int field##_open(struct inode *inode, struct file *file) \
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-22  6:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-19 12:00 [PATCH -next 4/8] nvmet: Make nvmet_debugfs static Jinjie Ruan
2024-08-22  6:57 ` Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.