All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
Cc: "Bernd Kuhls" <bernd@kuhls.net>,
	"Yann Morin" <yann.morin@orange.com>,
	"J. Neuschäfer" <j.neuschaefer@gmx.net>,
	"David du Colombier" <0intro@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/x264: disable assembly code on x86 + musl + PIC/PIE
Date: Sun, 25 Aug 2024 15:06:52 +0200	[thread overview]
Message-ID: <20240825150652.09dcab72@windsurf> (raw)
In-Reply-To: <20240824-x264-textrel-v1-1-fbfcedc7179d@gmx.net>

On Sat, 24 Aug 2024 22:11:02 +0200
J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:

> The x264 package uses large amounts of non-PIC assembly code
> (e.g. common/x86/dct-a.asm), which results in textrels, which aren't
> supported by musl-libc's dynamic linker.
> 
> Disable x264's assembly code when compiling for x86 with PIC/PIE and
> musl-libc to avoid this particular incompatibility.
> 
> Reported-by: Yann Morin <yann.morin@orange.com>
> Fixes: https://lore.kernel.org/buildroot/ZrsirnrvgsEIpAJI@tl-lnx-nyma7486-2/
> Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> ---
>  package/x264/x264.mk | 6 ++++++
>  1 file changed, 6 insertions(+)

I've applied to master, but to be honest, I'm not really thrilled. Has
this been taken up to the musl's maintainers? It's rather annoying than
on a major architecture like x86 we can't get the assembly optimized
x264 code.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-08-25 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-24 20:11 [Buildroot] [PATCH] package/x264: disable assembly code on x86 + musl + PIC/PIE J. Neuschäfer via buildroot
2024-08-25 13:06 ` Thomas Petazzoni via buildroot [this message]
2024-08-25 18:41   ` J. Neuschäfer via buildroot
     [not found] ` <20240825150652.09dcab72__4297.44312293536$1724591243$gmane$org@windsurf>
2024-08-25 13:33   ` Bernd Kuhls
2024-09-18 17:05 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240825150652.09dcab72@windsurf \
    --to=buildroot@buildroot.org \
    --cc=0intro@gmail.com \
    --cc=bernd@kuhls.net \
    --cc=j.neuschaefer@gmx.net \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin@orange.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.