Re: [Buildroot] [PATCH] package/x264: disable assembly code on x86 + musl + PIC/PIE

From: "J. Neuschäfer via buildroot" <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: "Bernd Kuhls" <bernd@kuhls.net>,
	"Yann Morin" <yann.morin@orange.com>,
	"J. Neuschäfer" <j.neuschaefer@gmx.net>,
	"David du Colombier" <0intro@gmail.com>,
	"J. Neuschäfer via buildroot" <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/x264: disable assembly code on x86 + musl + PIC/PIE
Date: Sun, 25 Aug 2024 20:41:14 +0200	[thread overview]
Message-ID: <Zst6yjnaF8LVxGv0@probook> (raw)
In-Reply-To: <20240825150652.09dcab72@windsurf>

On Sun, Aug 25, 2024 at 03:06:52PM +0200, Thomas Petazzoni wrote:
> On Sat, 24 Aug 2024 22:11:02 +0200
> J. Neuschäfer via buildroot <buildroot@buildroot.org> wrote:
>
> > The x264 package uses large amounts of non-PIC assembly code
> > (e.g. common/x86/dct-a.asm), which results in textrels, which aren't
> > supported by musl-libc's dynamic linker.
> >
> > Disable x264's assembly code when compiling for x86 with PIC/PIE and
> > musl-libc to avoid this particular incompatibility.
> >
> > Reported-by: Yann Morin <yann.morin@orange.com>
> > Fixes: https://lore.kernel.org/buildroot/ZrsirnrvgsEIpAJI@tl-lnx-nyma7486-2/
> > Signed-off-by: J. Neuschäfer <j.neuschaefer@gmx.net>
> > ---
> >  package/x264/x264.mk | 6 ++++++
> >  1 file changed, 6 insertions(+)
>
> I've applied to master, but to be honest, I'm not really thrilled. Has
> this been taken up to the musl's maintainers? It's rather annoying than
> on a major architecture like x86 we can't get the assembly optimized
> x264 code.

I've raised this topic in the musl IRC channel and the consensus was
that x264 should be fixed not to use textrels.

-- jn
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot