From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan@lists.osuosl.org,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
Date: Mon, 26 Aug 2024 12:17:10 +0200 [thread overview]
Message-ID: <20240826121710.7fcd856e@samweis> (raw)
In-Reply-To: <ZsxNv6jN5hld7jYl@nanopsycho.orion>
On Mon, 26 Aug 2024 11:41:19 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoerfer@suse.de wrote:
> >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
> >allocated. So before accessing pf->lag a NULL pointer check is needed.
> >
> >Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> You need to add a "fixes" tag blaming the commit that introduced the
> bug.
of course...
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
bonded interface")
Should I resend the patch ?
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG
Date: Mon, 26 Aug 2024 12:17:10 +0200 [thread overview]
Message-ID: <20240826121710.7fcd856e@samweis> (raw)
In-Reply-To: <ZsxNv6jN5hld7jYl@nanopsycho.orion>
On Mon, 26 Aug 2024 11:41:19 +0200
Jiri Pirko <jiri@resnulli.us> wrote:
> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoerfer@suse.de wrote:
> >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct
> >allocated. So before accessing pf->lag a NULL pointer check is needed.
> >
> >Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> You need to add a "fixes" tag blaming the commit that introduced the
> bug.
of course...
Fixes: 1e0f9881ef79 ("ice: Flesh out implementation of support for SRIOV on
bonded interface")
Should I resend the patch ?
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 36809 (AG Nürnberg)
Geschäftsführer: Ivo Totev, Andrew McDonald, Werner Knoblich
next prev parent reply other threads:[~2024-08-26 15:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:58 [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG Thomas Bogendoerfer
2024-08-26 8:58 ` Thomas Bogendoerfer
2024-08-26 9:41 ` [Intel-wired-lan] " Jiri Pirko
2024-08-26 9:41 ` Jiri Pirko
2024-08-26 10:17 ` Thomas Bogendoerfer [this message]
2024-08-26 10:17 ` Thomas Bogendoerfer
2024-08-26 11:17 ` [Intel-wired-lan] " Jiri Pirko
2024-08-26 11:17 ` Jiri Pirko
2024-08-27 7:16 ` [Intel-wired-lan] " Przemek Kitszel
2024-08-27 7:16 ` Przemek Kitszel
2024-08-27 19:12 ` [Intel-wired-lan] " Thomas Bogendoerfer
2024-08-27 19:12 ` Thomas Bogendoerfer
2024-08-28 8:14 ` [Intel-wired-lan] " Przemek Kitszel
2024-08-28 8:14 ` Przemek Kitszel
2024-08-30 17:12 ` [Intel-wired-lan] " Ertman, David M
2024-08-30 17:12 ` Ertman, David M
2024-09-03 21:43 ` [Intel-wired-lan] " Thomas Bogendoerfer
2024-09-03 21:43 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240826121710.7fcd856e@samweis \
--to=tbogendoerfer@suse.de \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.