All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak Gupta <debug@rivosinc.com>
To: qemu-riscv@nongnu.org, qemu-devel@nongnu.org
Cc: palmer@dabbelt.com, Alistair.Francis@wdc.com, bmeng.cn@gmail.com,
	liwei1518@gmail.com, dbarboza@ventanamicro.com,
	zhiwei_liu@linux.alibaba.com, jim.shu@sifive.com,
	andy.chiu@sifive.com, richard.henderson@linaro.org,
	kito.cheng@sifive.com, Deepak Gupta <debug@rivosinc.com>
Subject: [PATCH v9 10/17] target/riscv: tb flag for shadow stack instructions
Date: Mon, 26 Aug 2024 08:29:42 -0700	[thread overview]
Message-ID: <20240826152949.294506-11-debug@rivosinc.com> (raw)
In-Reply-To: <20240826152949.294506-1-debug@rivosinc.com>

Shadow stack instructions can be decoded as zimop / zcmop or shadow stack
instructions depending on whether shadow stack are enabled at current
privilege. This requires a TB flag so that correct TB generation and correct
TB lookup happens. `DisasContext` gets a field indicating whether bcfi is
enabled or not.

Signed-off-by: Deepak Gupta <debug@rivosinc.com>
Co-developed-by: Jim Shu <jim.shu@sifive.com>
Co-developed-by: Andy Chiu <andy.chiu@sifive.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/riscv/cpu.h        | 2 ++
 target/riscv/cpu_helper.c | 4 ++++
 target/riscv/translate.c  | 4 ++++
 3 files changed, 10 insertions(+)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 5a57099d59..dcc3bc9d93 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -613,6 +613,8 @@ FIELD(TB_FLAGS, AXL, 26, 2)
 /* zicfilp needs a TB flag to track indirect branches */
 FIELD(TB_FLAGS, FCFI_ENABLED, 28, 1)
 FIELD(TB_FLAGS, FCFI_LP_EXPECTED, 29, 1)
+/* zicfiss needs a TB flag so that correct TB is located based on tb flags */
+FIELD(TB_FLAGS, BCFI_ENABLED, 30, 1)
 
 #ifdef TARGET_RISCV32
 #define riscv_cpu_mxl(env)  ((void)(env), MXL_RV32)
diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c
index c9165b1d86..ca6d8f1f39 100644
--- a/target/riscv/cpu_helper.c
+++ b/target/riscv/cpu_helper.c
@@ -168,6 +168,10 @@ void cpu_get_tb_cpu_state(CPURISCVState *env, vaddr *pc,
         flags = FIELD_DP32(flags, TB_FLAGS, FCFI_ENABLED, 1);
     }
 
+    if (cpu_get_bcfien(env)) {
+        flags = FIELD_DP32(flags, TB_FLAGS, BCFI_ENABLED, 1);
+    }
+
 #ifdef CONFIG_USER_ONLY
     fs = EXT_STATUS_DIRTY;
     vs = EXT_STATUS_DIRTY;
diff --git a/target/riscv/translate.c b/target/riscv/translate.c
index b5c0511b4b..b1d251e893 100644
--- a/target/riscv/translate.c
+++ b/target/riscv/translate.c
@@ -119,6 +119,8 @@ typedef struct DisasContext {
     /* zicfilp extension. fcfi_enabled, lp expected or not */
     bool fcfi_enabled;
     bool fcfi_lp_expected;
+    /* zicfiss extension, if shadow stack was enabled during TB gen */
+    bool bcfi_enabled;
 } DisasContext;
 
 static inline bool has_ext(DisasContext *ctx, uint32_t ext)
@@ -1241,6 +1243,8 @@ static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs)
     ctx->pm_base_enabled = FIELD_EX32(tb_flags, TB_FLAGS, PM_BASE_ENABLED);
     ctx->ztso = cpu->cfg.ext_ztso;
     ctx->itrigger = FIELD_EX32(tb_flags, TB_FLAGS, ITRIGGER);
+    ctx->bcfi_enabled = cpu_get_bcfien(env) &&
+                        FIELD_EX32(tb_flags, TB_FLAGS, BCFI_ENABLED);
     ctx->fcfi_lp_expected = FIELD_EX32(tb_flags, TB_FLAGS, FCFI_LP_EXPECTED);
     ctx->fcfi_enabled = FIELD_EX32(tb_flags, TB_FLAGS, FCFI_ENABLED);
     ctx->zero = tcg_constant_tl(0);
-- 
2.44.0



  parent reply	other threads:[~2024-08-26 15:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 15:29 [PATCH v9 00/17] riscv support for control flow integrity extensions Deepak Gupta
2024-08-26 15:29 ` [PATCH v9 01/17] target/riscv: Add zicfilp extension Deepak Gupta
2024-08-27  2:16   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 02/17] target/riscv: Introduce elp state and enabling controls for zicfilp Deepak Gupta
2024-08-27  2:58   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 03/17] target/riscv: save and restore elp state on priv transitions Deepak Gupta
2024-08-27  0:33   ` Richard Henderson
2024-08-27  0:52     ` Deepak Gupta
2024-08-27  1:34       ` Richard Henderson
2024-08-27  3:53         ` Alistair Francis
2024-08-27  3:58           ` Richard Henderson
2024-08-27  4:03             ` Alistair Francis
2024-08-27  4:29               ` Richard Henderson
2024-08-27  5:47                 ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 04/17] target/riscv: additional code information for sw check Deepak Gupta
2024-08-27  3:55   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 05/17] target/riscv: tracking indirect branches (fcfi) for zicfilp Deepak Gupta
2024-08-27  3:58   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 06/17] target/riscv: zicfilp `lpad` impl and branch tracking Deepak Gupta
2024-08-27  4:14   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 07/17] disas/riscv: enable `lpad` disassembly Deepak Gupta
2024-08-27  4:15   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 08/17] target/riscv: Add zicfiss extension Deepak Gupta
2024-08-27  4:20   ` Alistair Francis
2024-08-26 15:29 ` [PATCH v9 09/17] target/riscv: introduce ssp and enabling controls for zicfiss Deepak Gupta
2024-08-26 15:29 ` Deepak Gupta [this message]
2024-08-27  5:51   ` [PATCH v9 10/17] target/riscv: tb flag for shadow stack instructions Alistair Francis
2024-08-26 15:29 ` [PATCH v9 11/17] target/riscv: mmu changes for zicfiss shadow stack protection Deepak Gupta
2024-08-27  5:59   ` Alistair Francis
2024-08-27 23:06     ` Deepak Gupta
2024-08-26 15:29 ` [PATCH v9 12/17] target/riscv: AMO operations always raise store/AMO fault Deepak Gupta
2024-08-27  0:34   ` Richard Henderson
2024-08-26 15:29 ` [PATCH v9 13/17] target/riscv: update `decode_save_opc` to store extra word2 Deepak Gupta
2024-08-27  0:35   ` Richard Henderson
2024-08-26 15:29 ` [PATCH v9 14/17] target/riscv: implement zicfiss instructions Deepak Gupta
2024-08-26 15:29 ` [PATCH v9 15/17] target/riscv: compressed encodings for sspush and sspopchk Deepak Gupta
2024-08-27  0:37   ` Richard Henderson
2024-08-26 15:29 ` [PATCH v9 16/17] disas/riscv: enable disassembly for zicfiss instructions Deepak Gupta
2024-08-26 15:29 ` [PATCH v9 17/17] disas/riscv: enable disassembly for compressed sspush/sspopchk Deepak Gupta
2024-08-27  2:44 ` [PATCH v9 00/17] riscv support for control flow integrity extensions Alistair Francis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240826152949.294506-11-debug@rivosinc.com \
    --to=debug@rivosinc.com \
    --cc=Alistair.Francis@wdc.com \
    --cc=andy.chiu@sifive.com \
    --cc=bmeng.cn@gmail.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=jim.shu@sifive.com \
    --cc=kito.cheng@sifive.com \
    --cc=liwei1518@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.