From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: ajay.opensrc <ajay.opensrc@micron.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"john@jagalactic.com" <john@jagalactic.com>,
Eishan Mirakhur <emirakhur@micron.com>,
Ajay Joshi <ajayjoshi@micron.com>,
"Srinivasulu Thanneeru" <sthanneeru@micron.com>,
Ravis OpenSrc <Ravis.OpenSrc@micron.com>,
Aravind Ramesh <arramesh@micron.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [EXT] Re: [PATCH] hw/cxl: Fix background completion percentage calculation
Date: Tue, 27 Aug 2024 17:38:13 +0100 [thread overview]
Message-ID: <20240827173813.00001cab@Huawei.com> (raw)
In-Reply-To: <ad56f019ee6e43f4b209a814f5494af0@micron.com>
On Tue, 27 Aug 2024 16:01:54 +0000
ajay.opensrc <ajay.opensrc@micron.com> wrote:
> > From: Davidlohr Bueso <dave@stgolabs.net>
> >
> > On Mon, 29 Jul 2024, ajay.opensrc@micron.com wrote:\n
> > >From: Ajay Joshi <ajayjoshi@micron.com>
> > >
> > >The current completion percentage calculation does not account for the
> > >relative time since the start of the background activity, this leads to
> > >showing incorrect start percentage vs what has actually been completed.
> > >
> > >This patch calculates the percentage based on the actual elapsed time
> > >since the start of the operation.
> > >
> > >Fixes: 221d2cfbdb ("hw/cxl/mbox: Add support for background
> > >operations")
> > >
> > >Signed-off-by: Ajay Joshi <ajay.opensrc@micron.com>
> >
> > Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
>
> Ping.
> Jonathan, this patch was reviewed by Dave already.
> Do you have any comments on this patch?
Sorry bit behind. Seems fine to me. I'll queue it up, but not sure
when I'll get a fixes series out (hopefully soon!)
+CC Michael in meantime.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
in case Michael wants to pick it up directly.
Thanks,
Jonathan
>
> Ajay
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron via <qemu-devel@nongnu.org>
To: ajay.opensrc <ajay.opensrc@micron.com>
Cc: "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"john@jagalactic.com" <john@jagalactic.com>,
Eishan Mirakhur <emirakhur@micron.com>,
Ajay Joshi <ajayjoshi@micron.com>,
"Srinivasulu Thanneeru" <sthanneeru@micron.com>,
Ravis OpenSrc <Ravis.OpenSrc@micron.com>,
Aravind Ramesh <arramesh@micron.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [EXT] Re: [PATCH] hw/cxl: Fix background completion percentage calculation
Date: Tue, 27 Aug 2024 17:38:13 +0100 [thread overview]
Message-ID: <20240827173813.00001cab@Huawei.com> (raw)
In-Reply-To: <ad56f019ee6e43f4b209a814f5494af0@micron.com>
On Tue, 27 Aug 2024 16:01:54 +0000
ajay.opensrc <ajay.opensrc@micron.com> wrote:
> > From: Davidlohr Bueso <dave@stgolabs.net>
> >
> > On Mon, 29 Jul 2024, ajay.opensrc@micron.com wrote:\n
> > >From: Ajay Joshi <ajayjoshi@micron.com>
> > >
> > >The current completion percentage calculation does not account for the
> > >relative time since the start of the background activity, this leads to
> > >showing incorrect start percentage vs what has actually been completed.
> > >
> > >This patch calculates the percentage based on the actual elapsed time
> > >since the start of the operation.
> > >
> > >Fixes: 221d2cfbdb ("hw/cxl/mbox: Add support for background
> > >operations")
> > >
> > >Signed-off-by: Ajay Joshi <ajay.opensrc@micron.com>
> >
> > Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
>
> Ping.
> Jonathan, this patch was reviewed by Dave already.
> Do you have any comments on this patch?
Sorry bit behind. Seems fine to me. I'll queue it up, but not sure
when I'll get a fixes series out (hopefully soon!)
+CC Michael in meantime.
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
in case Michael wants to pick it up directly.
Thanks,
Jonathan
>
> Ajay
next prev parent reply other threads:[~2024-08-27 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 10:23 [PATCH] hw/cxl: Fix background completion percentage calculation ajay.opensrc
2024-07-30 5:24 ` Davidlohr Bueso
2024-08-27 16:01 ` [EXT] " ajay.opensrc
2024-08-27 16:38 ` Jonathan Cameron [this message]
2024-08-27 16:38 ` Jonathan Cameron via
2024-09-10 17:07 ` Michael S. Tsirkin
2024-09-14 11:29 ` [EXT] " ajay.opensrc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827173813.00001cab@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Ravis.OpenSrc@micron.com \
--cc=ajay.opensrc@micron.com \
--cc=ajayjoshi@micron.com \
--cc=arramesh@micron.com \
--cc=dave@stgolabs.net \
--cc=emirakhur@micron.com \
--cc=john@jagalactic.com \
--cc=linux-cxl@vger.kernel.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sthanneeru@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.