All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	ncardwell@google.com, shuah@kernel.org,
	linux-kselftest@vger.kernel.org, fw@strlen.de,
	Willem de Bruijn <willemb@google.com>,
	"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
	martineau@kernel.org
Subject: Re: [PATCH net-next RFC] selftests/net: integrate packetdrill with ksft
Date: Fri, 30 Aug 2024 10:33:43 -0700	[thread overview]
Message-ID: <20240830103343.0dd20018@kernel.org> (raw)
In-Reply-To: <66d1e32558532_3c08a22949e@willemb.c.googlers.com.notmuch>

On Fri, 30 Aug 2024 11:20:05 -0400 Willem de Bruijn wrote:
> Kselftest install does not preserve directories.
> 
> So all .pkt files are copied into net/packetdrill root. This is messy.
> More fundamentally it breaks the includes in the files (e..g, `source
> ../common/defaults.sh`).

Can you show an example of exact commands and what happens?

We have directories in net/lib, and it's a target, and it works, no?

  reply	other threads:[~2024-08-30 17:33 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 19:32 [PATCH net-next RFC] selftests/net: integrate packetdrill with ksft Willem de Bruijn
2024-08-28  0:39 ` Jakub Kicinski
2024-08-28 13:58   ` Willem de Bruijn
2024-08-28  8:20 ` Paolo Abeni
2024-08-28 14:03   ` Willem de Bruijn
2024-08-28 16:01     ` Jakub Kicinski
2024-08-28 19:33       ` Willem de Bruijn
2024-08-28 21:00         ` Jakub Kicinski
2024-08-30 15:20           ` Willem de Bruijn
2024-08-30 17:33             ` Jakub Kicinski [this message]
2024-08-30 18:47               ` Willem de Bruijn
2024-08-30 21:44                 ` Jakub Kicinski
2024-08-30 21:52                   ` Willem de Bruijn
2024-09-01 21:15                     ` Willem de Bruijn
2024-09-02 16:46                       ` Jakub Kicinski
2024-09-02 16:56                         ` Jakub Kicinski
2024-09-02 20:50                           ` Willem de Bruijn
2024-09-05  3:27                   ` Willem de Bruijn
2024-08-30 21:46                 ` Willem de Bruijn
2024-08-28 16:26     ` Matthieu Baerts
2024-08-28 15:01 ` Stanislav Fomichev
2024-08-28 15:36   ` Jakub Kicinski
2024-08-28 15:43   ` Willem de Bruijn
2024-08-28 17:20     ` Stanislav Fomichev
2024-08-28 18:23       ` Jakub Kicinski
2024-08-28 18:36         ` Stanislav Fomichev
2024-08-28 18:26 ` Mina Almasry
2024-08-28 18:39   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830103343.0dd20018@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.