From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
jason.andryuk@amd.com, christopher.w.clark@gmail.com,
"Jan Beulich" <jbeulich@suse.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v4 27/44] x86/boot: relocate kextra into boot info
Date: Fri, 30 Aug 2024 17:47:12 -0400 [thread overview]
Message-ID: <20240830214730.1621-28-dpsmith@apertussolutions.com> (raw)
In-Reply-To: <20240830214730.1621-1-dpsmith@apertussolutions.com>
Move kextra into struct boot_info, thus no longer needed to be passed as a
parameter to create_dom0.
Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
xen/arch/x86/include/asm/bootinfo.h | 2 ++
xen/arch/x86/setup.c | 12 ++++++------
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h
index 1a325f66b3ba..06b3ecaf7bec 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -41,6 +41,8 @@ struct boot_info {
const char *boot_loader_name;
const char *cmdline;
+ const char *kextra;
+
paddr_t mmap_addr;
uint32_t mmap_length;
};
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f58eb21d00d7..76f25e9d620c 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -946,8 +946,7 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li
return n;
}
-static struct domain *__init create_dom0(const struct boot_info *bi,
- const char *kextra)
+static struct domain *__init create_dom0(const struct boot_info *bi)
{
static char __initdata cmdline[MAX_GUEST_CMDLINE];
@@ -1001,15 +1000,15 @@ static struct domain *__init create_dom0(const struct boot_info *bi,
panic("Error creating d%uv0\n", domid);
/* Grab the DOM0 command line. */
- if ( image->early_mod->string || kextra )
+ if ( image->early_mod->string || bi->kextra )
{
if ( image->early_mod->string )
safe_strcpy(cmdline, cmdline_cook(__va(image->early_mod->string),
bi->boot_loader_name));
- if ( kextra )
+ if ( bi->kextra )
/* kextra always includes exactly one leading space. */
- safe_strcat(cmdline, kextra);
+ safe_strcat(cmdline, bi->kextra);
/* Append any extra parameters. */
if ( skip_ioapic_setup && !strstr(cmdline, "noapic") )
@@ -1119,6 +1118,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
*kextra = '\0';
kextra += 3;
while ( kextra[1] == ' ' ) kextra++;
+ boot_info->kextra = kextra;
}
cmdline_parse(boot_info->cmdline);
@@ -2131,7 +2131,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
* We're going to setup domain0 using the module(s) that we stashed safely
* above our heap. The second module, if present, is an initrd ramdisk.
*/
- dom0 = create_dom0(boot_info, kextra);
+ dom0 = create_dom0(boot_info);
if ( !dom0 )
panic("Could not set up DOM0 guest OS\n");
--
2.30.2
next prev parent reply other threads:[~2024-08-30 21:56 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-30 21:46 [PATCH v4 00/44] Boot modules for Hyperlaunch Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 01/44] x86/boot: move x86 boot module counting into a new boot_info struct Daniel P. Smith
2024-09-02 13:47 ` Alejandro Vallejo
2024-09-04 6:23 ` Jan Beulich
2024-09-26 14:21 ` Daniel P. Smith
2024-09-03 22:24 ` Andrew Cooper
2024-09-26 14:31 ` Daniel P. Smith
2024-09-03 22:35 ` Andrew Cooper
2024-09-26 14:51 ` Daniel P. Smith
2024-09-04 6:31 ` Jan Beulich
2024-09-26 14:53 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 02/44] x86/boot: move boot loader name to boot info Daniel P. Smith
2024-09-03 22:41 ` Andrew Cooper
2024-09-26 15:02 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 03/44] x86/boot: move cmdline " Daniel P. Smith
2024-09-03 23:04 ` Andrew Cooper
2024-09-26 15:41 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 04/44] x86/boot: move mmap info " Daniel P. Smith
2024-09-03 23:18 ` Andrew Cooper
2024-09-26 15:48 ` Daniel P. Smith
2024-09-04 6:26 ` Jan Beulich
2024-09-26 15:54 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 05/44] x86/boot: introduce struct boot_module Daniel P. Smith
2024-09-03 23:29 ` Andrew Cooper
2024-09-26 16:03 ` Daniel P. Smith
2024-09-04 6:33 ` Jan Beulich
2024-09-26 16:04 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 06/44] x86/boot: convert consider_modules to " Daniel P. Smith
2024-09-04 6:40 ` Jan Beulich
2024-09-04 10:41 ` Andrew Cooper
2024-09-26 16:15 ` Daniel P. Smith
2024-09-26 16:10 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 07/44] x86/boot: move headroom to boot modules Daniel P. Smith
2024-09-03 23:40 ` Andrew Cooper
2024-09-26 16:21 ` Daniel P. Smith
2024-09-04 6:45 ` Jan Beulich
2024-09-26 16:26 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 08/44] x86/boot: convert setup.c mod refs to early_mod Daniel P. Smith
2024-09-03 23:50 ` Andrew Cooper
2024-09-26 16:28 ` Daniel P. Smith
2024-09-04 6:47 ` Jan Beulich
2024-09-26 16:55 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 09/44] x86/boot: split bootstrap_map_addr() out of bootstrap_map() Daniel P. Smith
2024-09-04 6:49 ` Jan Beulich
2024-09-04 10:47 ` Andrew Cooper
2024-09-26 17:06 ` Daniel P. Smith
2024-09-26 17:04 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 10/44] x86/boot: introduce boot module types Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 11/44] x86/boot: introduce boot module flags Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 12/44] x86/boot: add start and size fields to struct boot_module Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 13/44] x86/boot: update struct boot_module on module relocation Daniel P. Smith
2024-09-03 23:48 ` Andrew Cooper
2024-09-26 17:08 ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 14/44] x86/boot: transition relocation calculations to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 15/44] x86/boot: introduce boot module interator Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 16/44] x86/boot: introduce consumed flag for struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 17/44] x86/boot: convert microcode loading to consume struct boot_info Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 18/44] x86/boot: convert late microcode loading to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 19/44] x86/boot: use consumed boot module flag for microcode Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 20/44] x86/boot: convert xsm policy loading to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 21/44] x86/boot: convert ramdisk locating " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 22/44] x86/boot: remove module_map usage from microcode loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 23/44] x86/boot: remove module_map usage from xsm policy loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 24/44] x86/boot: remove module_map usage by ramdisk loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 25/44] x86/boot: convert create_dom0 to use boot info Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 26/44] x86/boot: convert construct_dom0 to use struct boot_module Daniel P. Smith
2024-08-30 21:47 ` Daniel P. Smith [this message]
2024-08-30 21:47 ` [PATCH v4 28/44] x86/boot: add cmdline to " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 29/44] x86/boot: convert dom0_construct_pv image param " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 30/44] x86/boot: convert dom0_construct_pv initrd " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 31/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 32/44] x86/boot: convert pvh_load_kernel " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 33/44] x86/boot: convert initial_images " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 34/44] x86/boot: drop the use of initial_images unit global Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 35/44] x86/boot: remove usage of mod_end by discard_initial_images Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 36/44] x86/boot: remove remaining early_mod references Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 37/44] x86/boot: remove early_mod from struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 38/44] x86/boot: introduce boot domain Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 39/44] x86/boot: introduce domid field to struct boot_domain Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 40/44] x86/boot: add cmdline " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 41/44] x86/boot: add struct domain " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 42/44] x86/boot: convert construct_dom0 " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 43/44] x86/boot: convert dom0_construct_pv " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 44/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-09-02 11:12 ` [PATCH v4 00/44] Boot modules for Hyperlaunch Daniel P. Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830214730.1621-28-dpsmith@apertussolutions.com \
--to=dpsmith@apertussolutions.com \
--cc=andrew.cooper3@citrix.com \
--cc=christopher.w.clark@gmail.com \
--cc=jason.andryuk@amd.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.