All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Smith" <dpsmith@apertussolutions.com>
To: xen-devel@lists.xenproject.org
Cc: "Daniel P. Smith" <dpsmith@apertussolutions.com>,
	jason.andryuk@amd.com, christopher.w.clark@gmail.com,
	"Jan Beulich" <jbeulich@suse.com>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Roger Pau Monné" <roger.pau@citrix.com>
Subject: [PATCH v4 38/44] x86/boot: introduce boot domain
Date: Fri, 30 Aug 2024 17:47:23 -0400	[thread overview]
Message-ID: <20240830214730.1621-39-dpsmith@apertussolutions.com> (raw)
In-Reply-To: <20240830214730.1621-1-dpsmith@apertussolutions.com>

To begin moving toward allowing the hypervisor to construct more than one
domain at boot, a container is needed for a domain's build information.

Introduce a new header, <xen/asm/bootdomain.h>, that contains the initial
struct boot_domain that encapsulate the build information for a domain.

No functional change intended.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
---
 xen/arch/x86/include/asm/bootdomain.h | 28 +++++++++++++++++++++++++++
 xen/arch/x86/include/asm/bootinfo.h   |  7 +++++++
 xen/arch/x86/setup.c                  | 27 +++++++++++---------------
 3 files changed, 46 insertions(+), 16 deletions(-)
 create mode 100644 xen/arch/x86/include/asm/bootdomain.h

diff --git a/xen/arch/x86/include/asm/bootdomain.h b/xen/arch/x86/include/asm/bootdomain.h
new file mode 100644
index 000000000000..4285223ac5ab
--- /dev/null
+++ b/xen/arch/x86/include/asm/bootdomain.h
@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (c) 2024 Apertus Solutions, LLC
+ * Author: Daniel P. Smith <dpsmith@apertussolutions.com>
+ * Copyright (c) 2024 Christopher Clark <christopher.w.clark@gmail.com>
+ */
+
+#ifndef __XEN_X86_BOOTDOMAIN_H__
+#define __XEN_X86_BOOTDOMAIN_H__
+
+struct boot_module;
+
+struct boot_domain {
+    struct boot_module *kernel;
+    struct boot_module *ramdisk;
+};
+
+#endif
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * tab-width: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h
index 59755ef42e53..b135aaebd25e 100644
--- a/xen/arch/x86/include/asm/bootinfo.h
+++ b/xen/arch/x86/include/asm/bootinfo.h
@@ -10,6 +10,11 @@
 
 #include <xen/types.h>
 
+#include <asm/bootdomain.h>
+
+/* Max number of boot domains that Xen can construct */
+#define MAX_NR_BOOTDOMS 1
+
 /* Boot module binary type / purpose */
 enum bootmod_type {
     BOOTMOD_UNKNOWN,
@@ -45,6 +50,8 @@ struct boot_info {
 
     paddr_t mmap_addr;
     uint32_t mmap_length;
+
+    struct boot_domain *domains;
 };
 
 static inline int __init next_boot_module_index(
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index a6fbaecee9ed..77abed637ff2 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -287,6 +287,7 @@ static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods)
 {
     static struct boot_info __initdata info;
     static struct boot_module __initdata boot_mods[MAX_NR_BOOTMODS + 1];
+    static struct boot_domain __initdata boot_doms[MAX_NR_BOOTDOMS];
     unsigned int i;
 
     info.nr_mods = mbi->mods_count;
@@ -321,6 +322,8 @@ static void __init multiboot_to_bootinfo(multiboot_info_t *mbi, module_t *mods)
     boot_mods[info.nr_mods].type = BOOTMOD_XEN;
     boot_mods[info.nr_mods].flags |= BOOTMOD_FLAG_X86_CONSUMED;
 
+    info.domains = boot_doms;
+
     boot_info = &info;
 }
 
@@ -958,20 +961,10 @@ static struct domain *__init create_dom0(const struct boot_info *bi)
             .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0,
         },
     };
-    int mod_idx = first_boot_module_index(bi, BOOTMOD_RAMDISK);
-    struct boot_module *image, *initrd;
+    struct boot_domain *bd = &bi->domains[0];
     struct domain *d;
     domid_t domid;
 
-    /* Map boot_module to mb1 module for dom0 */
-    image = &bi->mods[0];
-
-    /* Map boot_module to mb1 module for initrd */
-    if ( mod_idx < 0 )
-        initrd = NULL;
-    else
-        initrd = &bi->mods[mod_idx];
-
     if ( opt_dom0_pvh )
     {
         dom0_cfg.flags |= (XEN_DOMCTL_CDF_hvm |
@@ -997,11 +990,11 @@ static struct domain *__init create_dom0(const struct boot_info *bi)
         panic("Error creating d%uv0\n", domid);
 
     /* Grab the DOM0 command line. */
-    if ( image->cmdline || bi->kextra )
+    if ( bd->kernel->cmdline || bi->kextra )
     {
-        if ( image->cmdline )
-            safe_strcpy(cmdline,
-                        cmdline_cook(__va((unsigned long)image->cmdline),
+        if ( bd->kernel->cmdline )
+            safe_strcpy(cmdline, cmdline_cook(
+                        __va((unsigned long)bd->kernel->cmdline),
                         bi->boot_loader_name));
 
         if ( bi->kextra )
@@ -1036,7 +1029,7 @@ static struct domain *__init create_dom0(const struct boot_info *bi)
         write_cr4(read_cr4() & ~X86_CR4_SMAP);
     }
 
-    if ( construct_dom0(d, image, initrd, cmdline) != 0 )
+    if ( construct_dom0(d, bd->kernel, bd->ramdisk, cmdline) != 0 )
         panic("Could not construct domain 0\n");
 
     if ( cpu_has_smap )
@@ -1221,6 +1214,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
     /* Dom0 kernel is always first */
     boot_info->mods[0].type = BOOTMOD_KERNEL;
     boot_info->mods[0].flags |= BOOTMOD_FLAG_X86_CONSUMED;
+    boot_info->domains[0].kernel = &boot_info->mods[0];
 
     if ( pvh_boot )
     {
@@ -2112,6 +2106,7 @@ void asmlinkage __init noreturn __start_xen(unsigned long mbi_p)
     {
         boot_info->mods[initrdidx].type = BOOTMOD_RAMDISK;
         boot_info->mods[initrdidx].flags |= BOOTMOD_FLAG_X86_CONSUMED;
+        boot_info->domains[0].ramdisk = &boot_info->mods[initrdidx];
         if ( first_boot_module_index(boot_info, BOOTMOD_UNKNOWN) >= 0 )
             printk(XENLOG_WARNING
                    "Multiple initrd candidates, picking module #%u\n",
-- 
2.30.2



  parent reply	other threads:[~2024-08-30 21:56 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30 21:46 [PATCH v4 00/44] Boot modules for Hyperlaunch Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 01/44] x86/boot: move x86 boot module counting into a new boot_info struct Daniel P. Smith
2024-09-02 13:47   ` Alejandro Vallejo
2024-09-04  6:23     ` Jan Beulich
2024-09-26 14:21     ` Daniel P. Smith
2024-09-03 22:24   ` Andrew Cooper
2024-09-26 14:31     ` Daniel P. Smith
2024-09-03 22:35   ` Andrew Cooper
2024-09-26 14:51     ` Daniel P. Smith
2024-09-04  6:31   ` Jan Beulich
2024-09-26 14:53     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 02/44] x86/boot: move boot loader name to boot info Daniel P. Smith
2024-09-03 22:41   ` Andrew Cooper
2024-09-26 15:02     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 03/44] x86/boot: move cmdline " Daniel P. Smith
2024-09-03 23:04   ` Andrew Cooper
2024-09-26 15:41     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 04/44] x86/boot: move mmap info " Daniel P. Smith
2024-09-03 23:18   ` Andrew Cooper
2024-09-26 15:48     ` Daniel P. Smith
2024-09-04  6:26   ` Jan Beulich
2024-09-26 15:54     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 05/44] x86/boot: introduce struct boot_module Daniel P. Smith
2024-09-03 23:29   ` Andrew Cooper
2024-09-26 16:03     ` Daniel P. Smith
2024-09-04  6:33   ` Jan Beulich
2024-09-26 16:04     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 06/44] x86/boot: convert consider_modules to " Daniel P. Smith
2024-09-04  6:40   ` Jan Beulich
2024-09-04 10:41     ` Andrew Cooper
2024-09-26 16:15       ` Daniel P. Smith
2024-09-26 16:10     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 07/44] x86/boot: move headroom to boot modules Daniel P. Smith
2024-09-03 23:40   ` Andrew Cooper
2024-09-26 16:21     ` Daniel P. Smith
2024-09-04  6:45   ` Jan Beulich
2024-09-26 16:26     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 08/44] x86/boot: convert setup.c mod refs to early_mod Daniel P. Smith
2024-09-03 23:50   ` Andrew Cooper
2024-09-26 16:28     ` Daniel P. Smith
2024-09-04  6:47   ` Jan Beulich
2024-09-26 16:55     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 09/44] x86/boot: split bootstrap_map_addr() out of bootstrap_map() Daniel P. Smith
2024-09-04  6:49   ` Jan Beulich
2024-09-04 10:47     ` Andrew Cooper
2024-09-26 17:06       ` Daniel P. Smith
2024-09-26 17:04     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 10/44] x86/boot: introduce boot module types Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 11/44] x86/boot: introduce boot module flags Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 12/44] x86/boot: add start and size fields to struct boot_module Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 13/44] x86/boot: update struct boot_module on module relocation Daniel P. Smith
2024-09-03 23:48   ` Andrew Cooper
2024-09-26 17:08     ` Daniel P. Smith
2024-08-30 21:46 ` [PATCH v4 14/44] x86/boot: transition relocation calculations to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 15/44] x86/boot: introduce boot module interator Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 16/44] x86/boot: introduce consumed flag for struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 17/44] x86/boot: convert microcode loading to consume struct boot_info Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 18/44] x86/boot: convert late microcode loading to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 19/44] x86/boot: use consumed boot module flag for microcode Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 20/44] x86/boot: convert xsm policy loading to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 21/44] x86/boot: convert ramdisk locating " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 22/44] x86/boot: remove module_map usage from microcode loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 23/44] x86/boot: remove module_map usage from xsm policy loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 24/44] x86/boot: remove module_map usage by ramdisk loading Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 25/44] x86/boot: convert create_dom0 to use boot info Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 26/44] x86/boot: convert construct_dom0 to use struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 27/44] x86/boot: relocate kextra into boot info Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 28/44] x86/boot: add cmdline to struct boot_module Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 29/44] x86/boot: convert dom0_construct_pv image param " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 30/44] x86/boot: convert dom0_construct_pv initrd " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 31/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 32/44] x86/boot: convert pvh_load_kernel " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 33/44] x86/boot: convert initial_images " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 34/44] x86/boot: drop the use of initial_images unit global Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 35/44] x86/boot: remove usage of mod_end by discard_initial_images Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 36/44] x86/boot: remove remaining early_mod references Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 37/44] x86/boot: remove early_mod from struct boot_module Daniel P. Smith
2024-08-30 21:47 ` Daniel P. Smith [this message]
2024-08-30 21:47 ` [PATCH v4 39/44] x86/boot: introduce domid field to struct boot_domain Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 40/44] x86/boot: add cmdline " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 41/44] x86/boot: add struct domain " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 42/44] x86/boot: convert construct_dom0 " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 43/44] x86/boot: convert dom0_construct_pv " Daniel P. Smith
2024-08-30 21:47 ` [PATCH v4 44/44] x86/boot: convert dom0_construct_pvh " Daniel P. Smith
2024-09-02 11:12 ` [PATCH v4 00/44] Boot modules for Hyperlaunch Daniel P. Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830214730.1621-39-dpsmith@apertussolutions.com \
    --to=dpsmith@apertussolutions.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=christopher.w.clark@gmail.com \
    --cc=jason.andryuk@amd.com \
    --cc=jbeulich@suse.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.