From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
Sean Nyekjaer <sean@geanix.com>, Marek Vasut <marex@denx.de>,
Denis Ciocca <denis.ciocca@st.com>,
Rui Miguel Silva <rui.silva@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Danila Tikhonov <danila@jiaxyga.com>,
Jagath Jog J <jagathjog1996@gmail.com>,
Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Vasileios Amoiridis <vassilisamir@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 15/15] iio: pressure: bmp280: use irq_get_trigger_type()
Date: Mon, 2 Sep 2024 19:21:28 +0200 [thread overview]
Message-ID: <20240902172128.GA4669@vamoiridPC> (raw)
In-Reply-To: <20240901135950.797396-16-jic23@kernel.org>
On Sun, Sep 01, 2024 at 02:59:50PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> Use irq_get_trigger_type() to replace getting the irq data then the
> type in two steps.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
> drivers/iio/pressure/bmp280-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/bmp280-core.c b/drivers/iio/pressure/bmp280-core.c
> index da379230c837..b156dd763cf3 100644
> --- a/drivers/iio/pressure/bmp280-core.c
> +++ b/drivers/iio/pressure/bmp280-core.c
> @@ -2596,7 +2596,7 @@ static int bmp085_fetch_eoc_irq(struct device *dev,
> unsigned long irq_trig;
> int ret;
>
> - irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
> + irq_trig = irq_get_trigger_type(irq);
> if (irq_trig != IRQF_TRIGGER_RISING) {
> dev_err(dev, "non-rising trigger given for EOC interrupt, trying to enforce it\n");
> irq_trig = IRQF_TRIGGER_RISING;
> --
> 2.46.0
>
Hi Jonathan,
Tested-by: Vasileios Amoiridis <vassilisamir@gmail.com>
next prev parent reply other threads:[~2024-09-02 17:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 13:59 [PATCH 00/15] IIO: use irq_get_trigger_type() instead of opencoding Jonathan Cameron
2024-09-01 13:59 ` [PATCH 01/15] iio: accel: adxl380: use irq_get_trigger_type() Jonathan Cameron
2024-09-01 13:59 ` [PATCH 02/15] iio: accel: fxls8962af: " Jonathan Cameron
2024-09-02 9:20 ` Sean Nyekjaer
2024-09-02 11:41 ` Andy Shevchenko
2024-09-01 13:59 ` [PATCH 03/15] iio: adc: ti-ads1015: " Jonathan Cameron
2024-09-02 11:42 ` Andy Shevchenko
2024-09-01 13:59 ` [PATCH 04/15] iio: common: st: " Jonathan Cameron
2024-09-02 11:44 ` Andy Shevchenko
2024-09-07 14:19 ` Jonathan Cameron
2024-09-01 13:59 ` [PATCH 05/15] iio: gyro: fxas21002c: " Jonathan Cameron
2024-09-02 11:44 ` Andy Shevchenko
2024-09-01 13:59 ` [PATCH 06/15] iio: gyro: mpu3050: " Jonathan Cameron
2024-09-02 9:13 ` Linus Walleij
2024-09-02 11:46 ` Andy Shevchenko
2024-09-01 13:59 ` [PATCH 07/15] iio: humidity: hts221: " Jonathan Cameron
2024-09-02 11:46 ` Andy Shevchenko
2024-09-02 13:42 ` Lorenzo Bianconi
2024-09-01 13:59 ` [PATCH 08/15] iio: imu: bmi160: " Jonathan Cameron
2024-09-02 11:45 ` Andy Shevchenko
2024-09-07 14:26 ` Jonathan Cameron
2024-09-01 13:59 ` [PATCH 09/15] iio: imu: bmi323: " Jonathan Cameron
2024-09-01 13:59 ` [PATCH 10/15] iio: imu: inv_icm42600: " Jonathan Cameron
2024-09-01 13:59 ` [PATCH 11/15] iio: imu: inv_mpu6050: " Jonathan Cameron
2024-09-01 13:59 ` [PATCH 12/15] iio: imu: st_lsm6dsx: " Jonathan Cameron
2024-09-02 11:40 ` Lorenzo Bianconi
2024-09-02 11:47 ` Andy Shevchenko
2024-09-01 13:59 ` [PATCH 13/15] iio: light: st_uvis25: " Jonathan Cameron
2024-09-02 11:47 ` Andy Shevchenko
2024-09-02 18:19 ` Jonathan Cameron
2024-09-03 14:12 ` Andy Shevchenko
2024-09-02 13:42 ` Lorenzo Bianconi
2024-09-01 13:59 ` [PATCH 14/15] iio: magn: ak8974: " Jonathan Cameron
2024-09-02 9:14 ` Linus Walleij
2024-09-01 13:59 ` [PATCH 15/15] iio: pressure: bmp280: " Jonathan Cameron
2024-09-02 17:21 ` Vasileios Amoiridis [this message]
2024-09-02 11:49 ` [PATCH 00/15] IIO: use irq_get_trigger_type() instead of opencoding Andy Shevchenko
2024-09-07 14:35 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240902172128.GA4669@vamoiridPC \
--to=vassilisamir@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=antoniu.miclaus@analog.com \
--cc=danila@jiaxyga.com \
--cc=denis.ciocca@st.com \
--cc=jagathjog1996@gmail.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=marex@denx.de \
--cc=rui.silva@linaro.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.