All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	linux-nvme@lists.infradead.org, Hannes Reinecke <hare@kernel.org>
Subject: [PATCH 1/2] nvme-multipath: fixup typo when clearing DISK_LIVE
Date: Tue,  3 Sep 2024 20:03:44 +0200	[thread overview]
Message-ID: <20240903180345.35253-2-hare@kernel.org> (raw)
In-Reply-To: <20240903180345.35253-1-hare@kernel.org>

NVME_NSHEAD_DISK_LIVE is a flag for 'struct nvme_ns_head', not
'struct nvme_ns'.

Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
---
 drivers/nvme/host/multipath.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index 91d9eb3c22ef..c9d23b1b8efc 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c
@@ -646,7 +646,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns)
 		rc = device_add_disk(&head->subsys->dev, head->disk,
 				     nvme_ns_attr_groups);
 		if (rc) {
-			clear_bit(NVME_NSHEAD_DISK_LIVE, &ns->flags);
+			clear_bit(NVME_NSHEAD_DISK_LIVE, &head->flags);
 			return;
 		}
 		nvme_add_ns_head_cdev(head);
-- 
2.35.3



  reply	other threads:[~2024-09-03 18:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-03 18:03 [PATCHv2 0/2] nvme: NSHEAD_DISK_LIVE fixes Hannes Reinecke
2024-09-03 18:03 ` Hannes Reinecke [this message]
2024-09-04  4:09   ` [PATCH 1/2] nvme-multipath: fixup typo when clearing DISK_LIVE Christoph Hellwig
2024-09-03 18:03 ` [PATCH 2/2] nvme-multipath: fix I/O stall when remapping namespaces Hannes Reinecke
2024-09-03 19:38   ` Sagi Grimberg
2024-09-04  8:20     ` Hannes Reinecke
2024-09-04  8:59       ` Hannes Reinecke
2024-09-05  6:43         ` Nilay Shroff
2024-09-05  7:06         ` Sagi Grimberg
2024-09-05  8:39           ` Hannes Reinecke
2024-09-05  9:06             ` Sagi Grimberg
2024-09-05  9:23               ` Hannes Reinecke
2024-09-04 14:52   ` Nilay Shroff
2024-09-04 15:55     ` Hannes Reinecke
2024-09-05  6:41       ` Nilay Shroff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240903180345.35253-2-hare@kernel.org \
    --to=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.